Commit Graph

1475 Commits

Author SHA1 Message Date
Alex Dadgar
a9e3a41407 Enable more linters 2017-09-26 15:26:33 -07:00
Chelsea Holland Komlo
be1dcd08dd fixups from code review 2017-09-25 19:42:03 +00:00
Chelsea Holland Komlo
edf14142de update acl token 2017-09-25 15:54:06 +00:00
Alex Dadgar
c80ad75c51 generated code 2017-09-19 12:17:16 -05:00
Alex Dadgar
a66f32ea58 always gzip 2017-09-19 10:37:49 -05:00
Alex Dadgar
46ab2d69b1 handle errors when streaming logs 2017-09-19 10:37:49 -05:00
Alex Dadgar
cac2480793 fix test 2017-09-19 10:28:23 -05:00
Alex Dadgar
ddc2efa4ac sync 2017-09-19 10:08:23 -05:00
Michael Schurter
c1cf162d83 Merge pull request #3105 from hashicorp/f-876-restart-unhealthy
Restart unhealthy tasks
2017-09-17 19:38:32 -07:00
Chelsea Holland Komlo
83fefabe71 add command to cli
add extra verification test
2017-09-17 18:45:32 +00:00
Chelsea Holland Komlo
57c3ab03a0 add acl token info 2017-09-17 18:45:32 +00:00
Chelsea Holland Komlo
7ee27f99e8 small fixups 2017-09-17 18:17:53 +00:00
Chelsea Holland Komlo
c651ca45b5 acl policy info 2017-09-17 18:17:17 +00:00
Chelsea Holland Komlo
38c68c36fb fixups 2017-09-17 05:15:25 +00:00
Chelsea Holland Komlo
e6adcbcdcb add acl policy delete command 2017-09-17 04:36:08 +00:00
Chelsea Holland Komlo
26a6e98cd0 update documentation 2017-09-16 00:31:11 +00:00
Chelsea Holland Komlo
d5748ec05f fix up test data 2017-09-16 00:26:44 +00:00
Chelsea Holland Komlo
82463a32da fixup helptext for acl cli delete 2017-09-16 00:26:44 +00:00
Chelsea Holland Komlo
730c5ad457 adds ACL token delete 2017-09-16 00:26:44 +00:00
Chelsea Holland Komlo
dfe23ca8eb update comment to use from other commands 2017-09-15 23:33:43 +00:00
Chelsea Holland Komlo
87295bbc05 fixups from code review 2017-09-15 23:33:43 +00:00
Chelsea Holland Komlo
899e0eba7f add acl token as meta flag
add API test for job ACL
2017-09-15 23:33:43 +00:00
Michael Schurter
967825d341 Fix comments: task -> check 2017-09-15 15:19:53 -07:00
Michael Schurter
924813d57e Test converting CheckRestart from api->structs 2017-09-15 15:01:56 -07:00
Chelsea Holland Komlo
9c42804bca embed acl subcommands 2017-09-15 20:11:37 +00:00
Chelsea Holland Komlo
c5ec17bf3a fix up comments 2017-09-15 18:12:17 +00:00
Chelsea Holland Komlo
23e0acbea4 fixups from code review 2017-09-15 18:08:46 +00:00
Armon Dadgar
3a8c21508e command: document CLI flags 2017-09-14 21:59:36 -07:00
Armon Dadgar
2a53d420e8 command: Adding acl token create 2017-09-14 21:55:25 -07:00
Armon Dadgar
e17b4a31c7 command: Adding intermediate command for help text 2017-09-14 21:31:05 -07:00
Armon Dadgar
9de9a349d7 command: Adding acl policy apply test 2017-09-14 21:19:56 -07:00
Michael Schurter
6f72270d13 Test check watch updates 2017-09-14 16:48:39 -07:00
Michael Schurter
3c0a42ba8e Rename unhealthy var and fix test indeterminism 2017-09-14 16:48:39 -07:00
Michael Schurter
5cd1d57218 Watched -> TriggersRestart
Watched was a silly name
2017-09-14 16:48:39 -07:00
Michael Schurter
40ed2625f0 Handle multiple failing checks on a single task
Before this commit if a task had 2 checks cause restarts at the same
time, both would trigger restarts of the task! This change removes all
checks for a task whenever one of them is restarted.
2017-09-14 16:48:39 -07:00
Michael Schurter
f8e872c855 RestartDelay isn't needed as checks are re-added on restarts
@dadgar made the excellent observation in #3105 that TaskRunner removes
and re-registers checks on restarts. This means checkWatcher doesn't
need to do *any* internal restart tracking. Individual checks can just
remove themselves and be re-added when the task restarts.
2017-09-14 16:48:39 -07:00
Michael Schurter
237c096661 Simplify from 2 select loops to one 2017-09-14 16:48:39 -07:00
Michael Schurter
8b8c164622 Wrap check watch updates in a struct
Reusing checkRestart for both adds/removes and the main check restarting
logic was confusing.
2017-09-14 16:48:39 -07:00
Michael Schurter
092057a32b Canonicalize and Merge CheckRestart in api 2017-09-14 16:48:39 -07:00
Michael Schurter
9fb28656c9 Fix whitespace 2017-09-14 16:47:41 -07:00
Michael Schurter
3db835cb8f Improve check watcher logging and add tests
Also expose a mock Consul Agent to allow testing ServiceClient and
checkWatcher from TaskRunner without actually talking to a real Consul.
2017-09-14 16:47:41 -07:00
Michael Schurter
78c72f8725 Default grace period to 1s 2017-09-14 16:46:54 -07:00
Michael Schurter
c2d895d47a Add comments and move delay calc to TaskRunner 2017-09-14 16:46:54 -07:00
Michael Schurter
555d1e24dc on_warning=false -> ignore_warnings=false
Treat warnings as unhealthy by default
2017-09-14 16:46:54 -07:00
Michael Schurter
ebbf87f979 Use existing restart policy infrastructure 2017-09-14 16:46:54 -07:00
Michael Schurter
1608e59415 Add check watcher for restarting unhealthy tasks 2017-09-14 16:46:54 -07:00
Michael Schurter
bd1a342a92 Nest restart fields in CheckRestart 2017-09-14 16:46:54 -07:00
Michael Schurter
a720bb5a91 Add restart fields 2017-09-14 16:46:54 -07:00
Alex Dadgar
d0a9389a27 use assert 2017-09-14 14:20:22 -07:00
Alex Dadgar
e25dff5a28 Sort /v1/agent/servers output
This PR sorts the output of the endpoint since its results are used as
part of Consul checks to avoid the value changing unnecessarily.

Fixes https://github.com/hashicorp/nomad/issues/3211
2017-09-14 14:20:22 -07:00