Commit Graph

7 Commits

Author SHA1 Message Date
Seth Hoenig
eef81c3b4f structs: fix compatibility between api and nomad/structs proxy definitions
The field names within the structs representing the Connect proxy
definition were not the same (nomad/structs/ vs api/), causing the
values to be lost in translation for the 'nomad job inspect' command.

Since the field names already shipped in v0.11.0 we cannot simply
fix the names. Instead, use the json struct tag on the structs/ structs
to remap the name to match the publicly expose api/ package on json
encoding.

This means existing jobs from v0.11.0 will continue to work, and
the JSON API for job submission will remain backwards compatible.
2020-04-13 15:59:45 -06:00
Seth Hoenig
329ea5a77e doc: add a reminder about field order for diff comparisons
After spending hours re-learning this lesson more than once,
update the jobspec contribution guide with a reminder about
how to configure FieldDiff comparisons.
2020-03-25 09:33:27 -06:00
Drew Bailey
d9ec319990 add note to check for job diff 2020-03-04 12:06:32 -05:00
Michael Schurter
98dbb685c1 docs: explicitly callout checking for prior art
Also normalize formatting.
2020-02-12 08:07:07 -08:00
Michael Schurter
ddd8a92302 docs: add sidebar to jobspec checklist 2019-10-08 10:55:53 -07:00
Michael Schurter
4a194473d7 docs: checklists don't support numbered lists
The order didn't really make sense anyway.
2019-06-12 15:35:48 -07:00
Michael Schurter
47d9996fa4 docs: move dev docs to contributing 2019-06-07 15:41:13 -07:00