Alex Dadgar
c19cd2e5cf
loader and singleton
2019-01-22 15:11:57 -08:00
Alex Dadgar
b9f36134dc
move catalog + grpcutils
2019-01-22 15:11:57 -08:00
Michael Schurter
7c45733ba4
Merge pull request #5211 from hashicorp/test-porting-08
...
Port some 0.8 TaskRunner tests
2019-01-22 14:05:53 -08:00
Michael Schurter
06119e2505
test: port TestTaskRunner_CheckWatcher_Restart
...
Added ability to adjust the number of events the TaskRunner keeps as
there's no way to observe all events otherwise.
Task events differ slightly from 0.8 because 0.9 emits Terminated every
time a task exits instead of only when it exits on its own (not due to
restart or kill).
0.9 does not emit Killing/Killed for restarts like 0.8 which seems fine
as `Restart Signaled/Terminated/Restarting` is more descriptive.
Original v0.8 events emitted:
```
expected := []string{
"Received",
"Task Setup",
"Started",
"Restart Signaled",
"Killing",
"Killed",
"Restarting",
"Started",
"Restart Signaled",
"Killing",
"Killed",
"Restarting",
"Started",
"Restart Signaled",
"Killing",
"Killed",
"Not Restarting",
}
```
2019-01-22 09:46:46 -08:00
Michael Schurter
81334cd3a1
test: port RestartTask from 0.8
2019-01-22 08:08:08 -08:00
Michael Schurter
418d360d19
test: port SignalFailure test from 0.8
...
Also fix signal error handling in mock_driver.
2019-01-22 08:08:08 -08:00
Preetha Appan
a1cc48f78d
Rename TaskKillRequest/Response to TaskPreKillRequest/Response
2019-01-22 09:54:02 -06:00
Preetha Appan
6f3e4e72b9
Fix log comments
2019-01-22 09:45:58 -06:00
Preetha Appan
c3f044291d
Rename TaskKillHook to TaskPreKillHook to more closely match usage
...
Also added/fixed comments
2019-01-22 09:41:56 -06:00
Michael Schurter
77c01c6283
Fix comment
...
Co-Authored-By: preetapan <preetha@hashicorp.com >
2019-01-22 09:41:21 -06:00
Preetha Appan
bf9a2168e7
Rename TaskKillHook to TaskPreKillHook to more closely match usage
...
Also added/fixed comments
2019-01-22 09:41:21 -06:00
Mahmood Ali
06ca7860e2
Merge pull request #5216 from hashicorp/b-fix-tests-20180118
...
tests: deflake client TestFS_Logs_TaskPending test
2019-01-21 09:54:15 -05:00
Mahmood Ali
92033f1a81
tests: deflake client TestFS_Logs_TaskPending test
2019-01-18 21:26:48 -05:00
Nick Ethier
ce7bb88010
ar: return error from hooks if occured
2019-01-18 18:31:02 -05:00
Nick Ethier
994c66f7d7
drivers: use consts for task handle version
2019-01-18 18:31:01 -05:00
Nick Ethier
2f91ac88f7
cleanup code comments and small fixes from refactor
2019-01-18 18:31:01 -05:00
Nick Ethier
07cdedec2f
driver: add pre09 migration logic
2019-01-18 18:31:01 -05:00
Mahmood Ali
9f7619344e
Merge pull request #5190 from hashicorp/f-memory-usage
...
Track Basic Memory Usage as reported by cgroups
2019-01-18 16:46:02 -05:00
Chris Baker
b43f803d36
set TaskGroupName in task_runner
2019-01-18 20:25:11 +00:00
Chris Baker
d2f3dd7530
documenting test for task runner failure to set TaskGroupName
2019-01-18 20:00:49 +00:00
Michael Schurter
4e4ecc949f
Merge pull request #5203 from hashicorp/b-terminated
...
client: restore Terminated event on every exit
2019-01-18 08:54:15 -08:00
Danielle Tomlinson
2c8c1c4529
Merge pull request #5174 from hashicorp/dani/windows
...
Some Windows fixes and CI
2019-01-18 11:21:53 +01:00
Preetha Appan
eb7663697b
Fix one more place that should be using taskResources
...
taskResources handles new resource fields in a backwards compatible way
2019-01-17 15:52:51 -06:00
Michael Schurter
64e531e7bb
client: restore Terminated event on every exit
...
v0.9.0-dev started emitting a Terminated event every time a task process
exited. While this wasn't true in previous versions, it's a useful task
event because it's the only place for job operators to view the task's
exit code.
This behavior is asserted in the e2e/taskevents tests.
2019-01-17 10:02:25 -08:00
Danielle Tomlinson
db76db4b18
allocwatcher: Stat_t is unavailable on win
2019-01-17 18:43:14 +01:00
Danielle Tomlinson
8a4ffea94a
chore: Cleanup formatting
2019-01-17 18:43:13 +01:00
Danielle Tomlinson
041c01d583
client/fs: Skip delete-while-streaming test on win
2019-01-17 18:43:13 +01:00
Danielle Tomlinson
20f40eada8
client/fs: windows error message for not found
2019-01-17 18:43:13 +01:00
Danielle Tomlinson
dcce2d7247
vaultclient: use require for error assertions
2019-01-17 18:43:13 +01:00
Danielle Tomlinson
3078c24f79
vaultclient: Update tests for vault 1.0
2019-01-17 18:43:13 +01:00
Danielle Tomlinson
b05d362eb1
fingerprinter: Use HCLogger for windows
2019-01-17 18:43:13 +01:00
Danielle Tomlinson
435a8bae96
Merge pull request #5193 from hashicorp/dani/logmon-reattach
...
logmon: Reattach to existing loggers
2019-01-16 17:34:13 +01:00
Danielle Tomlinson
828d5f5a53
logmon: Reattach to existing loggers
...
This commit prevents us from creating duplicate logmon hooks when
restoring allocations by persisting the logmon reattach config using
HookData.
2019-01-16 14:56:10 +01:00
Michael Schurter
152ba08207
test: porting TestTaskRunner_SimpleRun_Dispatch
...
Porting test from 0.8 to 0.9.
2019-01-15 15:22:13 -08:00
Michael Schurter
3a491ab2b4
Merge pull request #5187 from hashicorp/test-consul
...
Port a bunch of pre-0.9 Consul tests to 0.9
2019-01-15 07:41:50 -08:00
Alex Dadgar
109c5ef650
Merge pull request #5173 from hashicorp/b-log-levels
...
Plugins use parent loggers
2019-01-14 16:14:30 -08:00
Mahmood Ali
b5c20aa50b
Track Basic Memory Usage as reported by cgroups
...
Track current memory usage, `memory.usage_in_bytes`, in addition to
`memory.max_memory_usage_in_bytes` and friends. This number is closer
what Docker reports.
Related to https://github.com/hashicorp/nomad/issues/5165 .
2019-01-14 18:47:52 -05:00
Nick Ethier
97a73e0116
Merge pull request #5018 from hashicorp/f-executor-stats
...
executor: streaming stats api
2019-01-14 15:02:35 -05:00
Michael Schurter
7445e418ca
test: port some pre-0.9 DeploymentHealth tests
...
Skipping a failing one as I need to move to some other work and don't
want to leave this work orphaned on my machine.
2019-01-14 09:56:53 -08:00
Michael Schurter
b58a77ecc0
test: assert service interpolation behavior
...
Ported from pre-0.9 tests.
2019-01-14 09:56:53 -08:00
Michael Schurter
df0a6dc34e
test: add some extra logging
2019-01-14 09:56:53 -08:00
Michael Schurter
99a5586aed
test: assert shutdown delay deregs first
...
Restore a pre-0.9 test that asserts Consul services are deregistered
before a task's shutdown delay.
2019-01-14 09:56:53 -08:00
Michael Schurter
903779769d
Update client/allocrunner/taskrunner/stats_hook.go
...
Co-Authored-By: nickethier <ncethier@gmail.com >
2019-01-14 12:31:27 -05:00
Nick Ethier
091cdbcb12
tr: stop stats collection on Exited hook
2019-01-14 12:30:14 -05:00
Nick Ethier
fc84e8f2bc
tr: add retry /w backoff to stats_hook failure
2019-01-12 12:18:24 -05:00
Nick Ethier
9904463da2
executor: fix failing stats related test
2019-01-12 12:18:23 -05:00
Nick Ethier
fbf9a4c772
executor: implement streaming stats API
...
plugins/driver: update driver interface to support streaming stats
client/tr: use streaming stats api
TODO:
* how to handle errors and closed channel during stats streaming
* prevent tight loop if Stats(ctx) returns an error
drivers: update drivers TaskStats RPC to handle streaming results
executor: better error handling in stats rpc
docker: better control and error handling of stats rpc
driver: allow stats to return a recoverable error
2019-01-12 12:18:22 -05:00
Preetha Appan
19777b870b
linting fixes
2019-01-12 10:38:20 -06:00
Preetha Appan
c66f2abefd
Make unit test for allocrunner failure much nicer
2019-01-12 10:38:20 -06:00
Preetha Appan
a1a7a02e48
Add unit test to simulate alloc runner creation failure
2019-01-12 10:38:20 -06:00