Drew Bailey
c24a631def
Merge pull request #6670 from hashicorp/api/fallthrough-test
...
test rootfallthrough handler
2019-11-13 10:51:31 -05:00
Lars Lehtonen
75476e350d
command/agent: Prune Dead Code ( #6682 )
...
* remove unused MockPeriodicJob() from tests
* remove unused getIndex() from tests
* remove unused checkIndex() from tests
* remove unused assertIndex() from tests
* remove unused Agent.findLoopbackDevice()
2019-11-13 08:20:01 -05:00
Lars Lehtonen
bbefae5506
command: error handling before file close ( #6681 )
2019-11-13 08:18:20 -05:00
Drew Bailey
e187a7f3f9
fix so assertions are test case driven
2019-11-12 14:28:21 -05:00
Lars Lehtonen
2784f166e5
command: fix TestHelpers_LineLimitReader_TimeLimit() goroutine ( #6678 )
2019-11-12 08:35:11 -05:00
Charlie Voiselle
1ec6388145
Added service wrapper code ( #6220 )
...
This is the basic code to add the Windows Service Manager hooks to Nomad.
Includes vendoring golang.org/x/sys/windows/svc and added Docs:
* guide for installing as a windows service.
* configuration for logging to file from PR #6429
2019-11-11 15:16:07 -05:00
Drew Bailey
e84eed84d4
test /ui/ path
2019-11-11 12:12:42 -05:00
Drew Bailey
6ad44f7ea6
test rootfallthrough handler
2019-11-11 12:08:44 -05:00
Lars Lehtonen
101d0373ee
command/agent: TestAgent_ServerConfig() fix dropped errors ( #6659 )
2019-11-11 09:46:46 -05:00
Drew Bailey
29585dd341
better func name, swap conditional
2019-11-11 08:35:56 -05:00
Drew Bailey
39280e7a94
returns a 404 if not found instead of redirect to ui
2019-11-08 15:34:35 -05:00
Tim Gross
a7bc31b011
fix broken test expectation from message change ( #6635 )
2019-11-06 16:33:13 -05:00
Drew Bailey
03f0aff010
unlock before returning, no need for label
...
comment, trigger build
return length written
2019-11-05 11:44:29 -05:00
Drew Bailey
8ccb770b00
simplify logch goroutine
2019-11-05 11:44:28 -05:00
Drew Bailey
158517972b
wireup plain=true|false query param
2019-11-05 11:44:28 -05:00
Drew Bailey
79411c5e0e
coordinate closing of doneCh, use interface to simplify callers
...
comments
2019-11-05 11:44:26 -05:00
Drew Bailey
33ba36acbd
log-json -> json
...
fix typo command/agent/monitor/monitor.go
Co-Authored-By: Chris Baker <1675087+cgbaker@users.noreply.github.com >
Update command/agent/monitor/monitor.go
Co-Authored-By: Chris Baker <1675087+cgbaker@users.noreply.github.com >
address feedback, lock to prevent send on closed channel
fix lock/unlock for dropped messages
2019-11-05 09:51:59 -05:00
Drew Bailey
4f618eb1e3
simplify assert message
2019-11-05 09:51:56 -05:00
Drew Bailey
676800f03a
address feedback
2019-11-05 09:51:56 -05:00
Drew Bailey
8423ccf890
allow more time for streaming message
...
remove unused struct
2019-11-05 09:51:55 -05:00
Drew Bailey
f74bd99b2a
monitor command takes no args
...
rm extra new line
fix lint errors
return after close
fix, simplify test
2019-11-05 09:51:55 -05:00
Drew Bailey
9a96c10d4c
moving endpoints over to frames
2019-11-05 09:51:54 -05:00
Drew Bailey
f8eaf1f5af
lock in sub select
...
rm redundant lock
wip to use framing
wip switch to stream frames
2019-11-05 09:51:54 -05:00
Drew Bailey
58117c03c4
fix deadlock issue, switch to frames envelope
2019-11-05 09:51:54 -05:00
Drew Bailey
873969cf41
return 400 if invalid log_json param is given
...
Addresses feedback around monitor implementation
subselect on stopCh to prevent blocking forever.
Set up a separate goroutine to check every 3 seconds for dropped
messages.
rename returned ch to avoid confusion
2019-11-05 09:51:53 -05:00
Drew Bailey
6bf8617d02
rename function, initialize log level better
...
underscores instead of dashes for query params
2019-11-05 09:51:53 -05:00
Drew Bailey
a72bd5cf65
use channel instead of empty string to determine close
2019-11-05 09:51:52 -05:00
Drew Bailey
9bb606a0ae
update go-hclog dep
...
remove duplicate lock
2019-11-05 09:51:52 -05:00
Drew Bailey
92d6a30f86
agent:read acl policy for monitor
2019-11-05 09:51:52 -05:00
Drew Bailey
c8d60dd6f9
only look up rpchandler for node if we have nodeid
...
fix some comments and nomad monitor -h output
2019-11-05 09:51:51 -05:00
Drew Bailey
2362008e74
new hclog with standardlogger intercept
2019-11-05 09:51:49 -05:00
Drew Bailey
e7589301ea
enable json formatting, use queryoptions
2019-11-05 09:51:49 -05:00
Drew Bailey
8095b4868a
New monitor pkg for shared monitor functionality
...
Adds new package that can be used by client and server RPC endpoints to
facilitate monitoring based off of a logger
clean up old code
small comment about write
rm old comment about minsize
rename to Monitor
Removes connection logic from monitor command
Keep connection logic in endpoints, use a channel to send results from
monitoring
use new multisink logger and interfaces
small test for dropped messages
update go-hclogger and update sink/intercept logger interfaces
2019-11-05 09:51:49 -05:00
Drew Bailey
890b8a43fb
get local rpc endpoint working
2019-11-05 09:51:48 -05:00
Drew Bailey
12819975ee
remove log_writer
...
prefix output with proper spacing
update gzip handler, adjust first byte flow to allow gzip handler bypass
wip, first stab at wiring up rpc endpoint
2019-11-05 09:51:48 -05:00
Drew Bailey
a828c92403
Display error when remote side ended monitor
...
multisink logger
remove usage of logwriter
2019-11-05 09:51:48 -05:00
Drew Bailey
74cfdf55bb
Adds nomad monitor command
...
Adds nomad monitor command. Like consul monitor, this command allows you
to stream logs from a nomad agent in real time with a a specified log
level
add endpoint tests
Upgrade go-hclog to latest version
The current version of go-hclog pads log prefixes to equal lengths
so info becomes [INFO ] and debug becomes [DEBUG]. This breaks
hashicorp/logutils/level.go Check function. Upgrading to the latest
version removes this padding and fixes log filtering that uses logutils
Check
2019-11-05 09:51:47 -05:00
Drew Bailey
dc3286481a
Add Agent Monitor to receive streaming logs
...
Queries /v1/agent/monitor and receives streaming logs from client
2019-11-05 09:51:47 -05:00
Drew Bailey
91c0184773
Adds AgentMonitor Endpoint
...
AgentMonitor is an endpoint to stream logs for a given agent. It allows
callers to pass in a supplied log level, which may be different than the
agents config allowing for temporary debugging with lower log levels.
Pass in logWriter when setting up Agent
2019-11-05 09:51:46 -05:00
Drew Bailey
b20fb9e7bb
Merge pull request #6609 from hashicorp/b-alloc-status-consistency
...
Prevent nomad alloc status output inconsistency
2019-11-04 10:12:04 -05:00
Drew Bailey
6980ab0a81
Prevent nomad alloc status output inconsistency
...
Prevent random map ordering and sort alphabetically
better variable name
2019-11-01 14:01:32 -04:00
Michael Schurter
0fcb0d4016
client: fix panic from 0.8 -> 0.10 upgrade
...
makeAllocTaskServices did not do a nil check on AllocatedResources
which causes a panic when upgrading directly from 0.8 to 0.10. While
skipping 0.9 is not supported we intend to fix serious crashers caused
by such upgrades to prevent cluster outages.
I did a quick audit of the client package and everywhere else that
accesses AllocatedResources appears to be properly guarded by a nil
check.
2019-11-01 07:47:03 -07:00
Mahmood Ali
f010fe22fa
Merge pull request #6047 from hashicorp/b-ignore-server-if-disabled
...
Only warn against BootstrapExpect set in CLI flag
2019-10-29 10:55:44 -04:00
Lang Martin
f042b5e296
quota: parse network stanza in quotas ( #6511 )
2019-10-24 10:41:54 -04:00
Michael Schurter
d42ac815b4
Merge branch 'master' into release-0100
2019-10-22 08:17:57 -07:00
Nomad Release bot
25ee121d95
Generate files for 0.10.0 release
2019-10-22 12:34:56 +00:00
Seth Hoenig
8c7a7b6def
Merge pull request #6448 from hashicorp/f-set-connect-sidecar-tags
...
connect: enable setting tags on consul connect sidecar service in job…
2019-10-17 15:14:09 -05:00
Seth Hoenig
b7e83591b4
connect: enable setting tags on consul connect sidecar service in jobspec ( #6415 )
2019-10-17 19:25:20 +00:00
Mahmood Ali
31da091b57
Merge pull request #6427 from hashicorp/b-fs-endpoint-errors
...
agent: report fs log errors as http errors
2019-10-15 20:12:59 -04:00
Mahmood Ali
5282353e22
tests: avoid using unnecessary pipe
2019-10-15 17:22:03 -04:00