nomad/.changelog/24057.txt at main - nomad - Gitea: Git with a cup of tea

kemko/nomad

mirror of https://github.com/kemko/nomad.git synced 2026-01-01 16:05:42 +03:00

Files

Tim Gross cc9227b858 template: fix panic in change_mode=script on client restart (#24057 )

When we introduced change_mode=script to templates, we passed the driver handle
down into the template manager so we could call its `Exec` method directly. But
the lifecycle of the driver handle is managed by the taskrunner and isn't
available when the template manager is first created. This has led to a series
of patches trying to fixup the behavior (#15915, #15192, #23663, #23917). Part
of the challenge in getting this right is using an interface to avoid the
circular import of the driver handle.

But the taskrunner already has a way to deal with this problem using a "lazy
handle". The other template change modes already use this indirectly through the
`Lifecycle` interface. Change the driver handle `Exec` call in the template
manager to a new `Lifecycle.Exec` call that reuses the existing behavior. This
eliminates the need for the template manager to know anything at all about the
handle state.

Fixes: https://github.com/hashicorp/nomad/issues/24051

2024-09-25 08:59:01 -04:00

4 lines

96 B

Plaintext

Raw Permalink Blame History

	```release-note:bug
	`template: Fixed a panic on client restart when using change_mode=script`
	```