nomad/.changelog/24241.txt at main - nomad - Gitea: Git with a cup of tea

kemko/nomad

mirror of https://github.com/kemko/nomad.git synced 2026-01-01 16:05:42 +03:00

Files

Tim Gross 55fe05d353 heartbeat: use leader's ACL token when failing heartbeat (#24241 )

In #23838 we updated the `Node.Update` RPC handler we use for heartbeats to be
more strict about requiring node secrets. But when a node goes down, it's the
leader that sends the request to mark the node down via `Node.Update` (to
itself), and this request was missing the leader ACL needed to authenticate to
itself.

Add the leader ACL to the request and update the RPC handler test for
disconnected-clients to use ACLs, which would have detected this bug. Also added
a note to the `Authenticate` comment about how that authentication path requires
the leader ACL.

Fixes: https://github.com/hashicorp/nomad/issues/24231
Ref: https://hashicorp.atlassian.net/browse/NET-11384

2024-10-17 13:48:20 -04:00

4 lines

91 B

Plaintext

Raw Permalink Blame History

	```release-note:bug
	`heartbeat: Fixed a bug where failed nodes would not be marked down`
	```