mirror of
https://github.com/kemko/nomad.git
synced 2026-01-01 16:05:42 +03:00
b25f1b66ce
On supported platforms, the secrets directory is a 1MiB tmpfs. But some tasks need larger space for downloading large secrets. This is especially the case for tasks using `templates`, which need extra room to write a temporary file to the secrets directory that gets renamed to the old file atomically. This changeset allows increasing the size of the tmpfs in the `resources` block. Because this is a memory resource, we need to include it in the memory we allocate for scheduling purposes. The task is already prevented from using more memory in the tmpfs than the `resources.memory` field allows, but can bypass that limit by writing to the tmpfs via `template` or `artifact` blocks. Therefore, we need to account for the size of the tmpfs in the allocation resources. Simply adding it to the memory needed when we create the allocation allows it to be accounted for in all downstream consumers, and then we'll subtract that amount from the memory resources just before configuring the task driver. For backwards compatibility, the default value of 1MiB is "free" and ignored by the scheduler. Otherwise we'd be increasing the allocated resources for every existing alloc, which could cause problems across upgrades. If a user explicitly sets `resources.secrets = 1` it will no longer be free. Fixes: https://github.com/hashicorp/nomad/issues/2481 Ref: https://hashicorp.atlassian.net/browse/NET-10070
31 lines
703 B
Go
31 lines
703 B
Go
// Copyright (c) HashiCorp, Inc.
|
|
// SPDX-License-Identifier: BUSL-1.1
|
|
|
|
package allocdir
|
|
|
|
import (
|
|
"os"
|
|
"syscall"
|
|
)
|
|
|
|
// linkDir hardlinks src to dst. The src and dst must be on the same filesystem.
|
|
func linkDir(src, dst string) error {
|
|
return syscall.Link(src, dst)
|
|
}
|
|
|
|
// unlinkDir removes a directory link.
|
|
func unlinkDir(dir string) error {
|
|
return syscall.Unlink(dir)
|
|
}
|
|
|
|
// createSecretDir creates the secrets dir folder at the given path
|
|
func createSecretDir(dir string, _ int) error {
|
|
// TODO solaris has support for tmpfs so use that
|
|
return os.MkdirAll(dir, fileMode777)
|
|
}
|
|
|
|
// removeSecretDir removes the secrets dir folder
|
|
func removeSecretDir(dir string) error {
|
|
return os.RemoveAll(dir)
|
|
}
|