mirror of
https://github.com/kemko/nomad.git
synced 2026-01-01 16:05:42 +03:00
14a022cbc0
* drivers/raw_exec: enable setting cgroup override values
This PR enables configuration of cgroup override values on the `raw_exec`
task driver. WARNING: setting cgroup override values eliminates any
gauruntee Nomad can make about resource availability for *any* task on
the client node.
For cgroup v2 systems, set a single unified cgroup path using `cgroup_v2_override`.
The path may be either absolute or relative to the cgroup root.
config {
cgroup_v2_override = "custom.slice/app.scope"
}
or
config {
cgroup_v2_override = "/sys/fs/cgroup/custom.slice/app.scope"
}
For cgroup v1 systems, set a per-controller path for each controller using
`cgroup_v1_override`. The path(s) may be either absolute or relative to
the controller root.
config {
cgroup_v1_override = {
"pids": "custom/app",
"cpuset": "custom/app",
}
}
or
config {
cgroup_v1_override = {
"pids": "/sys/fs/cgroup/pids/custom/app",
"cpuset": "/sys/fs/cgroup/cpuset/custom/app",
}
}
* drivers/rawexec: ensure only one of v1/v2 cgroup override is set
* drivers/raw_exec: executor should error if setting cgroup does not work
* drivers/raw_exec: create cgroups in raw_exec tests
* drivers/raw_exec: ensure we fail to start if custom cgroup set and non-root
* move custom cgroup func into shared file
---------
Co-authored-by: Michael Schurter <mschurter@hashicorp.com>
102 lines
2.5 KiB
Go
102 lines
2.5 KiB
Go
// Copyright (c) HashiCorp, Inc.
|
|
// SPDX-License-Identifier: MPL-2.0
|
|
|
|
//go:build linux
|
|
|
|
package executor
|
|
|
|
import (
|
|
"fmt"
|
|
"testing"
|
|
|
|
"github.com/hashicorp/nomad/ci"
|
|
"github.com/hashicorp/nomad/client/lib/cgroupslib"
|
|
"github.com/hashicorp/nomad/client/testutil"
|
|
"github.com/hashicorp/nomad/helper/testlog"
|
|
"github.com/hashicorp/nomad/nomad/structs"
|
|
"github.com/hashicorp/nomad/plugins/drivers"
|
|
"github.com/shoenig/test/must"
|
|
)
|
|
|
|
func Test_computeMemory(t *testing.T) {
|
|
cases := []struct {
|
|
memory int64
|
|
memoryMax int64
|
|
expSoft int64
|
|
expHard int64
|
|
}{
|
|
{
|
|
// typical case; only 'memory' is set and that is used as the hard
|
|
// memory limit
|
|
memory: 100,
|
|
memoryMax: 0,
|
|
expSoft: 0,
|
|
expHard: mbToBytes(100),
|
|
},
|
|
{
|
|
// oversub case; both 'memory' and 'memory_max' are set and used as
|
|
// the soft and hard memory limits
|
|
memory: 100,
|
|
memoryMax: 200,
|
|
expSoft: mbToBytes(100),
|
|
expHard: mbToBytes(200),
|
|
},
|
|
{
|
|
// special oversub case; 'memory' is set and 'memory_max' is set to
|
|
// -1; which indicates there should be no hard limit (i.e. -1 / max)
|
|
memory: 100,
|
|
memoryMax: memoryNoLimit,
|
|
expSoft: mbToBytes(100),
|
|
expHard: memoryNoLimit,
|
|
},
|
|
}
|
|
|
|
for _, tc := range cases {
|
|
name := fmt.Sprintf("(%d,%d)", tc.memory, tc.memoryMax)
|
|
t.Run(name, func(t *testing.T) {
|
|
command := &ExecCommand{
|
|
Resources: &drivers.Resources{
|
|
NomadResources: &structs.AllocatedTaskResources{
|
|
Memory: structs.AllocatedMemoryResources{
|
|
MemoryMB: tc.memory,
|
|
MemoryMaxMB: tc.memoryMax,
|
|
},
|
|
},
|
|
},
|
|
}
|
|
hard, soft := (*UniversalExecutor)(nil).computeMemory(command)
|
|
must.Eq(t, tc.expSoft, soft)
|
|
must.Eq(t, tc.expHard, hard)
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestExecutor_InvalidCgroup(t *testing.T) {
|
|
ci.Parallel(t)
|
|
testutil.CgroupsCompatible(t)
|
|
|
|
factory := universalFactory
|
|
testExecCmd := testExecutorCommand(t)
|
|
execCmd, allocDir := testExecCmd.command, testExecCmd.allocDir
|
|
execCmd.Cmd = "sleep"
|
|
execCmd.Args = []string{"infinity"}
|
|
|
|
switch cgroupslib.GetMode() {
|
|
case cgroupslib.CG1:
|
|
execCmd.OverrideCgroupV1 = map[string]string{
|
|
"pid": "custom/path",
|
|
}
|
|
case cgroupslib.CG2:
|
|
execCmd.OverrideCgroupV2 = "custom.slice/test.scope"
|
|
}
|
|
|
|
factory.configureExecCmd(t, execCmd)
|
|
defer allocDir.Destroy()
|
|
executor := factory.new(testlog.HCLogger(t), compute)
|
|
defer executor.Shutdown("", 0)
|
|
|
|
_, err := executor.Launch(execCmd)
|
|
must.ErrorContains(t, err, "unable to configure cgroups: no such file or directory")
|
|
|
|
}
|