mirror of
https://github.com/kemko/nomad.git
synced 2026-01-01 16:05:42 +03:00
7647491588
Restoring scaling policies during the start of a stopped job did not account for jobs that didn't have any scaling policies, and led to a panic when users tried to restart such jobs.
281 lines
6.8 KiB
Go
281 lines
6.8 KiB
Go
// Copyright (c) HashiCorp, Inc.
|
|
// SPDX-License-Identifier: BUSL-1.1
|
|
|
|
package command
|
|
|
|
import (
|
|
"encoding/json"
|
|
"testing"
|
|
|
|
"github.com/hashicorp/cli"
|
|
"github.com/hashicorp/nomad/api"
|
|
"github.com/hashicorp/nomad/ci"
|
|
"github.com/hashicorp/nomad/command/agent"
|
|
"github.com/hashicorp/nomad/helper/pointer"
|
|
"github.com/hashicorp/nomad/helper/uuid"
|
|
"github.com/hashicorp/nomad/nomad/mock"
|
|
"github.com/hashicorp/nomad/nomad/structs"
|
|
"github.com/posener/complete"
|
|
"github.com/shoenig/test/must"
|
|
)
|
|
|
|
var _ cli.Command = (*JobStartCommand)(nil)
|
|
|
|
func TestStartCommand(t *testing.T) {
|
|
ci.Parallel(t)
|
|
|
|
testSetup := func() (*agent.TestAgent, *JobStartCommand, string) {
|
|
srv, _, addr := testServer(t, true, func(c *agent.Config) {
|
|
c.DevMode = true
|
|
})
|
|
ui := cli.NewMockUi()
|
|
cmd := &JobStartCommand{
|
|
Meta: Meta{
|
|
Ui: ui,
|
|
flagAddress: addr,
|
|
},
|
|
}
|
|
return srv, cmd, addr
|
|
}
|
|
|
|
t.Run("succeeds when starting a stopped job", func(t *testing.T) {
|
|
srv, cmd, addr := testSetup()
|
|
defer srv.Shutdown()
|
|
|
|
job := testJob(uuid.Generate())
|
|
|
|
client, err := cmd.Meta.Client()
|
|
must.NoError(t, err)
|
|
|
|
jsonBytes, err := json.Marshal(job)
|
|
must.NoError(t, err)
|
|
|
|
_, _, err = client.Jobs().RegisterOpts(job, &api.RegisterOptions{
|
|
Submission: &api.JobSubmission{
|
|
Source: string(jsonBytes),
|
|
Format: "json",
|
|
},
|
|
}, nil)
|
|
must.NoError(t, err)
|
|
|
|
waitForJobAllocsStatus(t, client, *job.ID, api.AllocClientStatusRunning, "")
|
|
|
|
_, _, err = client.Jobs().Deregister(*job.ID, false, nil)
|
|
must.Nil(t, err)
|
|
|
|
waitForJobAllocsStatus(t, client, *job.ID, api.AllocClientStatusComplete, "")
|
|
|
|
res := cmd.Run([]string{"-address", addr, *job.ID})
|
|
must.Zero(t, res)
|
|
|
|
pol, _, err := client.Scaling().ListPolicies(nil)
|
|
must.NoError(t, err)
|
|
must.One(t, len(pol))
|
|
must.True(t, *job.TaskGroups[0].Scaling.Enabled)
|
|
|
|
})
|
|
|
|
t.Run("succeeds when starting a stopped job with disabled scaling policies and no submissions", func(t *testing.T) {
|
|
srv, cmd, addr := testSetup()
|
|
defer srv.Shutdown()
|
|
|
|
job := testJob(uuid.Generate())
|
|
|
|
client, err := cmd.Meta.Client()
|
|
must.NoError(t, err)
|
|
|
|
job.TaskGroups[0].Scaling.Enabled = pointer.Of(false)
|
|
|
|
_, _, err = client.Jobs().RegisterOpts(job, &api.RegisterOptions{}, nil)
|
|
must.NoError(t, err)
|
|
|
|
waitForJobAllocsStatus(t, client, *job.ID, api.AllocClientStatusRunning, "")
|
|
|
|
_, _, err = client.Jobs().Deregister(*job.ID, false, nil)
|
|
must.Nil(t, err)
|
|
|
|
waitForJobAllocsStatus(t, client, *job.ID, api.AllocClientStatusComplete, "")
|
|
|
|
res := cmd.Run([]string{"-address", addr, *job.ID})
|
|
must.Zero(t, res)
|
|
|
|
pol, _, err := client.Scaling().ListPolicies(nil)
|
|
must.NoError(t, err)
|
|
must.One(t, len(pol))
|
|
must.False(t, *job.TaskGroups[0].Scaling.Enabled)
|
|
|
|
})
|
|
|
|
t.Run("succeeds when starting a stopped job with enabled scaling policies", func(t *testing.T) {
|
|
srv, cmd, addr := testSetup()
|
|
defer srv.Shutdown()
|
|
|
|
job := testJob(uuid.Generate())
|
|
|
|
client, err := cmd.Meta.Client()
|
|
must.NoError(t, err)
|
|
|
|
job.TaskGroups[0].Scaling.Enabled = pointer.Of(true)
|
|
|
|
jsonBytes, err := json.Marshal(job)
|
|
must.NoError(t, err)
|
|
|
|
_, _, err = client.Jobs().RegisterOpts(job, &api.RegisterOptions{
|
|
Submission: &api.JobSubmission{
|
|
Source: string(jsonBytes),
|
|
Format: "json",
|
|
},
|
|
}, nil)
|
|
must.NoError(t, err)
|
|
|
|
waitForJobAllocsStatus(t, client, *job.ID, api.AllocClientStatusRunning, "")
|
|
|
|
_, _, err = client.Jobs().Deregister(*job.ID, false, nil)
|
|
must.Nil(t, err)
|
|
|
|
waitForJobAllocsStatus(t, client, *job.ID, api.AllocClientStatusComplete, "")
|
|
|
|
res := cmd.Run([]string{"-address", addr, *job.ID})
|
|
must.Zero(t, res)
|
|
|
|
pol, _, err := client.Scaling().ListPolicies(nil)
|
|
must.NoError(t, err)
|
|
must.One(t, len(pol))
|
|
must.True(t, *job.TaskGroups[0].Scaling.Enabled)
|
|
|
|
})
|
|
|
|
t.Run("succeeds when starting a stopped job with no scaling policies", func(t *testing.T) {
|
|
srv, cmd, addr := testSetup()
|
|
defer srv.Shutdown()
|
|
|
|
job := testJob(uuid.Generate())
|
|
|
|
client, err := cmd.Meta.Client()
|
|
must.NoError(t, err)
|
|
|
|
job.TaskGroups[0].Scaling = nil
|
|
|
|
jsonBytes, err := json.Marshal(job)
|
|
must.NoError(t, err)
|
|
|
|
_, _, err = client.Jobs().RegisterOpts(job, &api.RegisterOptions{
|
|
Submission: &api.JobSubmission{
|
|
Source: string(jsonBytes),
|
|
Format: "json",
|
|
},
|
|
}, nil)
|
|
must.NoError(t, err)
|
|
|
|
waitForJobAllocsStatus(t, client, *job.ID, api.AllocClientStatusRunning, "")
|
|
|
|
_, _, err = client.Jobs().Deregister(*job.ID, false, nil)
|
|
must.Nil(t, err)
|
|
|
|
waitForJobAllocsStatus(t, client, *job.ID, api.AllocClientStatusComplete, "")
|
|
|
|
res := cmd.Run([]string{"-address", addr, *job.ID})
|
|
must.Zero(t, res)
|
|
|
|
pol, _, err := client.Scaling().ListPolicies(nil)
|
|
must.NoError(t, err)
|
|
must.Zero(t, len(pol))
|
|
})
|
|
|
|
t.Run("fails to start a job not previously stopped", func(t *testing.T) {
|
|
srv, cmd, addr := testSetup()
|
|
defer srv.Shutdown()
|
|
|
|
job := testJob(uuid.Generate())
|
|
|
|
client, err := cmd.Meta.Client()
|
|
must.NoError(t, err)
|
|
|
|
_, _, err = client.Jobs().Register(job, nil)
|
|
must.NoError(t, err)
|
|
|
|
waitForJobAllocsStatus(t, client, *job.ID, api.AllocClientStatusRunning, "")
|
|
|
|
res := cmd.Run([]string{"-address", addr, *job.ID})
|
|
must.Eq(t, 1, res)
|
|
})
|
|
|
|
t.Run("fails to start a non-existant job", func(t *testing.T) {
|
|
srv, cmd, addr := testSetup()
|
|
defer srv.Shutdown()
|
|
|
|
res := cmd.Run([]string{"-address", addr, "non-existant"})
|
|
must.Eq(t, 1, res)
|
|
})
|
|
}
|
|
|
|
func TestStartCommand_Arguments(t *testing.T) {
|
|
ci.Parallel(t)
|
|
|
|
t.Run("fails if client request fails", func(t *testing.T) {
|
|
ui := cli.NewMockUi()
|
|
cmd := &JobStartCommand{
|
|
Meta: Meta{
|
|
Ui: ui,
|
|
},
|
|
}
|
|
|
|
code := cmd.Run([]string{"-address=nope", "foo"})
|
|
must.Eq(t, code, 1)
|
|
|
|
out := ui.ErrorWriter.String()
|
|
must.StrContains(t, out, "Error querying job prefix")
|
|
})
|
|
t.Run("fails if given more than 1 argument", func(t *testing.T) {
|
|
ui := cli.NewMockUi()
|
|
cmd := &JobStartCommand{
|
|
Meta: Meta{
|
|
Ui: ui,
|
|
},
|
|
}
|
|
|
|
code := cmd.Run([]string{"foo1", "foo2"})
|
|
must.Eq(t, code, 1)
|
|
|
|
out := ui.ErrorWriter.String()
|
|
must.StrContains(t, out, "This command takes one argument: <job>")
|
|
})
|
|
t.Run("fails if given less than 1 argument", func(t *testing.T) {
|
|
ui := cli.NewMockUi()
|
|
cmd := &JobStartCommand{
|
|
Meta: Meta{
|
|
Ui: ui,
|
|
},
|
|
}
|
|
|
|
code := cmd.Run([]string{})
|
|
must.Eq(t, code, 1)
|
|
|
|
out := ui.ErrorWriter.String()
|
|
must.StrContains(t, out, "This command takes one argument: <job>")
|
|
})
|
|
}
|
|
|
|
func TestStartCommand_AutocompleteArgs(t *testing.T) {
|
|
ci.Parallel(t)
|
|
|
|
srv, _, url := testServer(t, true, nil)
|
|
defer srv.Shutdown()
|
|
|
|
ui := cli.NewMockUi()
|
|
cmd := &JobStartCommand{Meta: Meta{Ui: ui, flagAddress: url}}
|
|
|
|
// Create a fake job
|
|
state := srv.Agent.Server().State()
|
|
j := mock.Job()
|
|
must.NoError(t, state.UpsertJob(structs.MsgTypeTestSetup, 1000, nil, j))
|
|
|
|
prefix := j.ID[:len(j.ID)-5]
|
|
args := complete.Args{Last: prefix}
|
|
predictor := cmd.AutocompleteArgs()
|
|
|
|
res := predictor.Predict(args)
|
|
must.Len(t, 1, res)
|
|
must.Eq(t, j.ID, res[0])
|
|
}
|