mirror of
https://github.com/kemko/nomad.git
synced 2026-01-01 16:05:42 +03:00
fca4ee8e05
* test: use `T.TempDir` to create temporary test directory
This commit replaces `ioutil.TempDir` with `t.TempDir` in tests. The
directory created by `t.TempDir` is automatically removed when the test
and all its subtests complete.
Prior to this commit, temporary directory created using `ioutil.TempDir`
needs to be removed manually by calling `os.RemoveAll`, which is omitted
in some tests. The error handling boilerplate e.g.
defer func() {
if err := os.RemoveAll(dir); err != nil {
t.Fatal(err)
}
}
is also tedious, but `t.TempDir` handles this for us nicely.
Reference: https://pkg.go.dev/testing#T.TempDir
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
* test: fix TestLogmon_Start_restart on Windows
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
* test: fix failing TestConsul_Integration
t.TempDir fails to perform the cleanup properly because the folder is
still in use
testing.go:967: TempDir RemoveAll cleanup: unlinkat /tmp/TestConsul_Integration2837567823/002/191a6f1a-5371-cf7c-da38-220fe85d10e5/web/secrets: device or resource busy
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
91 lines
1.8 KiB
Go
91 lines
1.8 KiB
Go
package command
|
|
|
|
import (
|
|
"io/ioutil"
|
|
"path/filepath"
|
|
"testing"
|
|
|
|
"github.com/hashicorp/nomad/ci"
|
|
"github.com/mitchellh/cli"
|
|
)
|
|
|
|
func TestConfigValidateCommand_FailWithEmptyDir(t *testing.T) {
|
|
ci.Parallel(t)
|
|
fh := t.TempDir()
|
|
|
|
ui := cli.NewMockUi()
|
|
cmd := &ConfigValidateCommand{Meta: Meta{Ui: ui}}
|
|
args := []string{fh}
|
|
|
|
code := cmd.Run(args)
|
|
if code != 1 {
|
|
t.Fatalf("expected exit 1, actual: %d", code)
|
|
}
|
|
}
|
|
|
|
func TestConfigValidateCommand_SucceedWithMinimalConfigFile(t *testing.T) {
|
|
ci.Parallel(t)
|
|
fh := t.TempDir()
|
|
|
|
fp := filepath.Join(fh, "config.hcl")
|
|
err := ioutil.WriteFile(fp, []byte(`data_dir="/"
|
|
client {
|
|
enabled = true
|
|
}`), 0644)
|
|
if err != nil {
|
|
t.Fatalf("err: %s", err)
|
|
}
|
|
|
|
ui := cli.NewMockUi()
|
|
cmd := &ConfigValidateCommand{Meta: Meta{Ui: ui}}
|
|
args := []string{fh}
|
|
|
|
code := cmd.Run(args)
|
|
if code != 0 {
|
|
t.Fatalf("expected exit 0, actual: %d", code)
|
|
}
|
|
}
|
|
|
|
func TestConfigValidateCommand_FailOnParseBadConfigFile(t *testing.T) {
|
|
ci.Parallel(t)
|
|
fh := t.TempDir()
|
|
|
|
fp := filepath.Join(fh, "config.hcl")
|
|
err := ioutil.WriteFile(fp, []byte(`a: b`), 0644)
|
|
if err != nil {
|
|
t.Fatalf("err: %s", err)
|
|
}
|
|
|
|
ui := cli.NewMockUi()
|
|
cmd := &ConfigValidateCommand{Meta: Meta{Ui: ui}}
|
|
args := []string{fh}
|
|
|
|
code := cmd.Run(args)
|
|
if code != 1 {
|
|
t.Fatalf("expected exit 1, actual: %d", code)
|
|
}
|
|
}
|
|
|
|
func TestConfigValidateCommand_FailOnValidateParsableConfigFile(t *testing.T) {
|
|
ci.Parallel(t)
|
|
fh := t.TempDir()
|
|
|
|
fp := filepath.Join(fh, "config.hcl")
|
|
err := ioutil.WriteFile(fp, []byte(`data_dir="../"
|
|
client {
|
|
enabled = true
|
|
}`), 0644)
|
|
if err != nil {
|
|
t.Fatalf("err: %s", err)
|
|
}
|
|
|
|
ui := cli.NewMockUi()
|
|
cmd := &ConfigValidateCommand{Meta: Meta{Ui: ui}}
|
|
args := []string{fh}
|
|
|
|
code := cmd.Run(args)
|
|
if code != 1 {
|
|
t.Fatalf("expected exit 1, actual: %d", code)
|
|
}
|
|
}
|