mirror of
https://github.com/kemko/nomad.git
synced 2026-01-02 08:25:43 +03:00
fca4ee8e05
* test: use `T.TempDir` to create temporary test directory
This commit replaces `ioutil.TempDir` with `t.TempDir` in tests. The
directory created by `t.TempDir` is automatically removed when the test
and all its subtests complete.
Prior to this commit, temporary directory created using `ioutil.TempDir`
needs to be removed manually by calling `os.RemoveAll`, which is omitted
in some tests. The error handling boilerplate e.g.
defer func() {
if err := os.RemoveAll(dir); err != nil {
t.Fatal(err)
}
}
is also tedious, but `t.TempDir` handles this for us nicely.
Reference: https://pkg.go.dev/testing#T.TempDir
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
* test: fix TestLogmon_Start_restart on Windows
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
* test: fix failing TestConsul_Integration
t.TempDir fails to perform the cleanup properly because the folder is
still in use
testing.go:967: TempDir RemoveAll cleanup: unlinkat /tmp/TestConsul_Integration2837567823/002/191a6f1a-5371-cf7c-da38-220fe85d10e5/web/secrets: device or resource busy
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
111 lines
2.7 KiB
Go
111 lines
2.7 KiB
Go
package command
|
|
|
|
import (
|
|
"io/ioutil"
|
|
"os"
|
|
"testing"
|
|
|
|
"github.com/hashicorp/nomad/ci"
|
|
"github.com/mitchellh/cli"
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
func TestQuotaInitCommand_Implements(t *testing.T) {
|
|
ci.Parallel(t)
|
|
var _ cli.Command = &QuotaInitCommand{}
|
|
}
|
|
|
|
func TestQuotaInitCommand_Run_HCL(t *testing.T) {
|
|
ci.Parallel(t)
|
|
ui := cli.NewMockUi()
|
|
cmd := &QuotaInitCommand{Meta: Meta{Ui: ui}}
|
|
|
|
// Fails on misuse
|
|
code := cmd.Run([]string{"some", "bad", "args"})
|
|
require.Equal(t, 1, code)
|
|
require.Contains(t, ui.ErrorWriter.String(), commandErrorText(cmd))
|
|
ui.ErrorWriter.Reset()
|
|
|
|
// Ensure we change the cwd back
|
|
origDir, err := os.Getwd()
|
|
require.NoError(t, err)
|
|
defer os.Chdir(origDir)
|
|
|
|
// Create a temp dir and change into it
|
|
dir := t.TempDir()
|
|
|
|
err = os.Chdir(dir)
|
|
require.NoError(t, err)
|
|
|
|
// Works if the file doesn't exist
|
|
code = cmd.Run([]string{})
|
|
require.Empty(t, ui.ErrorWriter.String())
|
|
require.Zero(t, code)
|
|
|
|
content, err := ioutil.ReadFile(DefaultHclQuotaInitName)
|
|
require.NoError(t, err)
|
|
require.Equal(t, defaultHclQuotaSpec, string(content))
|
|
|
|
// Fails if the file exists
|
|
code = cmd.Run([]string{})
|
|
require.Contains(t, ui.ErrorWriter.String(), "exists")
|
|
require.Equal(t, 1, code)
|
|
ui.ErrorWriter.Reset()
|
|
|
|
// Works if file is passed
|
|
code = cmd.Run([]string{"mytest.hcl"})
|
|
require.Empty(t, ui.ErrorWriter.String())
|
|
require.Zero(t, code)
|
|
|
|
content, err = ioutil.ReadFile("mytest.hcl")
|
|
require.NoError(t, err)
|
|
require.Equal(t, defaultHclQuotaSpec, string(content))
|
|
}
|
|
|
|
func TestQuotaInitCommand_Run_JSON(t *testing.T) {
|
|
ci.Parallel(t)
|
|
ui := cli.NewMockUi()
|
|
cmd := &QuotaInitCommand{Meta: Meta{Ui: ui}}
|
|
|
|
// Fails on misuse
|
|
code := cmd.Run([]string{"some", "bad", "args"})
|
|
require.Equal(t, 1, code)
|
|
require.Contains(t, ui.ErrorWriter.String(), commandErrorText(cmd))
|
|
ui.ErrorWriter.Reset()
|
|
|
|
// Ensure we change the cwd back
|
|
origDir, err := os.Getwd()
|
|
require.NoError(t, err)
|
|
defer os.Chdir(origDir)
|
|
|
|
// Create a temp dir and change into it
|
|
dir := t.TempDir()
|
|
|
|
err = os.Chdir(dir)
|
|
require.NoError(t, err)
|
|
|
|
// Works if the file doesn't exist
|
|
code = cmd.Run([]string{"-json"})
|
|
require.Empty(t, ui.ErrorWriter.String())
|
|
require.Zero(t, code)
|
|
|
|
content, err := ioutil.ReadFile(DefaultJsonQuotaInitName)
|
|
require.NoError(t, err)
|
|
require.Equal(t, defaultJsonQuotaSpec, string(content))
|
|
|
|
// Fails if the file exists
|
|
code = cmd.Run([]string{"-json"})
|
|
require.Contains(t, ui.ErrorWriter.String(), "exists")
|
|
require.Equal(t, 1, code)
|
|
ui.ErrorWriter.Reset()
|
|
|
|
// Works if file is passed
|
|
code = cmd.Run([]string{"-json", "mytest.json"})
|
|
require.Empty(t, ui.ErrorWriter.String())
|
|
require.Zero(t, code)
|
|
|
|
content, err = ioutil.ReadFile("mytest.json")
|
|
require.NoError(t, err)
|
|
require.Equal(t, defaultJsonQuotaSpec, string(content))
|
|
}
|