Files
nomad/command/agent
Michael Schurter 9c418c224b consul: fix deadlock in check-based restarts
Fixes #5395
Alternative to #5957

Make task restarting asynchronous when handling check-based restarts.
This matches the pre-0.9 behavior where TaskRunner.Restart was an
asynchronous signal. The check-based restarting code was not designed
to handle blocking in TaskRunner.Restart. 0.9 made it reentrant and
could easily overwhelm the buffered update chan and deadlock.

Many thanks to @byronwolfman for his excellent debugging, PR, and
reproducer!

I created this alternative as changing the functionality of
TaskRunner.Restart has a much larger impact. This approach reverts to
old known-good behavior and minimizes the number of places changes are
made.
2019-07-17 15:22:21 -07:00
..
2018-03-11 17:43:19 +00:00
2018-09-13 10:43:40 -07:00
2018-09-13 10:43:40 -07:00
2018-03-11 18:35:30 +00:00
2018-10-16 16:56:55 -07:00
2018-09-13 10:43:40 -07:00
2018-09-13 10:43:40 -07:00
2018-09-13 10:43:40 -07:00
2018-02-15 13:59:02 -08:00
2019-01-22 15:44:31 -08:00
2019-01-22 15:44:31 -08:00