Files
nomad/command/agent/host_volume_endpoint_test.go
Tim Gross a65358da7b dynamic host volumes: HTTP API endpoint (#24380)
This changeset implements the HTTP API endpoints for Dynamic Host Volumes.

The `GET /v1/volumes` endpoint is shared between CSI and DHV with a query
parameter for the type. In the interest of getting some working handlers
available for use in development (and minimizing the size of the diff to
review), this changeset doesn't do any sort of refactoring of how the existing
List Volumes CSI endpoint works. That will come in a later PR, as will the
corresponding `api` package updates we need to support the CLI.

Ref: https://hashicorp.atlassian.net/browse/NET-11549
2024-12-19 09:25:54 -05:00

102 lines
3.0 KiB
Go

// Copyright (c) HashiCorp, Inc.
// SPDX-License-Identifier: BUSL-1.1
package agent
import (
"fmt"
"net/http"
"net/http/httptest"
"net/url"
"testing"
"github.com/hashicorp/nomad/nomad/mock"
"github.com/hashicorp/nomad/nomad/structs"
"github.com/shoenig/test/must"
)
func TestHostVolumeEndpoint_CRUD(t *testing.T) {
httpTest(t, nil, func(s *TestAgent) {
// Create a volume on the test node
vol := mock.HostVolumeRequest()
reqBody := struct {
Volumes []*structs.HostVolume
}{Volumes: []*structs.HostVolume{vol}}
buf := encodeReq(reqBody)
req, err := http.NewRequest(http.MethodPut, "/v1/volume/host/create", buf)
must.NoError(t, err)
respW := httptest.NewRecorder()
// Make the request and verify we got a valid volume back
obj, err := s.Server.HostVolumeSpecificRequest(respW, req)
must.NoError(t, err)
must.NotNil(t, obj)
resp := obj.(*structs.HostVolumeCreateResponse)
must.Len(t, 1, resp.Volumes)
must.Eq(t, vol.Name, resp.Volumes[0].Name)
must.Eq(t, s.client.NodeID(), resp.Volumes[0].NodeID)
must.NotEq(t, "", respW.Result().Header.Get("X-Nomad-Index"))
volID := resp.Volumes[0].ID
// Verify volume was created
path, err := url.JoinPath("/v1/volume/host/", volID)
must.NoError(t, err)
req, err = http.NewRequest(http.MethodGet, path, nil)
must.NoError(t, err)
obj, err = s.Server.HostVolumeSpecificRequest(respW, req)
must.NoError(t, err)
must.NotNil(t, obj)
respVol := obj.(*structs.HostVolume)
must.Eq(t, s.client.NodeID(), respVol.NodeID)
// Update the volume (note: this doesn't update the volume on the client)
vol = respVol.Copy()
vol.Parameters = map[string]string{"bar": "foo"} // swaps key and value
reqBody = struct {
Volumes []*structs.HostVolume
}{Volumes: []*structs.HostVolume{vol}}
buf = encodeReq(reqBody)
req, err = http.NewRequest(http.MethodPut, "/v1/volume/host/register", buf)
must.NoError(t, err)
obj, err = s.Server.HostVolumeSpecificRequest(respW, req)
must.NoError(t, err)
must.NotNil(t, obj)
regResp := obj.(*structs.HostVolumeRegisterResponse)
must.Len(t, 1, regResp.Volumes)
must.Eq(t, map[string]string{"bar": "foo"}, regResp.Volumes[0].Parameters)
// Verify volume was updated
path = fmt.Sprintf("/v1/volumes?type=host&node_id=%s", s.client.NodeID())
req, err = http.NewRequest(http.MethodGet, path, nil)
must.NoError(t, err)
obj, err = s.Server.HostVolumesListRequest(respW, req)
must.NoError(t, err)
vols := obj.([]*structs.HostVolumeStub)
must.Len(t, 1, vols)
// Delete the volume
req, err = http.NewRequest(http.MethodDelete, fmt.Sprintf("/v1/volume/host/%s", volID), nil)
must.NoError(t, err)
_, err = s.Server.HostVolumeSpecificRequest(respW, req)
must.NoError(t, err)
// Verify volume was deleted
path, err = url.JoinPath("/v1/volume/host/", volID)
must.NoError(t, err)
req, err = http.NewRequest(http.MethodGet, path, nil)
must.NoError(t, err)
obj, err = s.Server.HostVolumeSpecificRequest(respW, req)
must.EqError(t, err, "volume not found")
must.Nil(t, obj)
})
}