Marvin Chin
be8575a8a2
Fix server shutdown not waiting for worker run completion ( #19560 )
...
* Move group into a separate helper module for reuse
* Add shutdownCh to worker
The shutdown channel is used to signal that worker has stopped.
* Make server shutdown block on workers' shutdownCh
* Fix waiting for eval broker state change blocking indefinitely
There was a race condition in the GenericNotifier between the
Run and WaitForChange functions, where WaitForChange blocks
trying to write to a full unsubscribeCh, but the Run function never
reads from the unsubscribeCh as it has already stopped.
This commit fixes it by unblocking if the notifier has been stopped.
* Bound the amount of time server shutdown waits on worker completion
* Fix lostcancel linter error
* Fix worker test using unexpected worker constructor
* Add changelog
---------
Co-authored-by: Marvin Chin <marvinchin@users.noreply.github.com >
2024-01-05 08:45:07 -06:00
..
2023-12-11 14:20:13 -05:00
2023-08-18 07:47:24 +01:00
2023-08-14 08:43:27 -05:00
2023-12-08 08:46:55 -05:00
2023-12-06 12:28:42 +01:00
2023-09-28 22:00:43 +02:00
2024-01-05 08:12:27 +00:00
2023-12-08 08:46:55 -05:00
2023-12-20 15:51:34 -08:00
2023-08-10 17:27:09 -05:00
2024-01-03 08:24:38 -05:00
2024-01-03 08:24:38 -05:00
2023-10-16 09:30:24 -04:00
2023-10-27 16:36:10 +01:00
2023-10-12 12:21:48 -04:00
2023-12-08 08:46:55 -05:00
2023-08-18 07:47:24 +01:00
2023-08-10 17:27:09 -05:00
2023-12-08 08:46:55 -05:00
2023-08-10 17:27:09 -05:00
2023-08-10 17:27:09 -05:00
2023-08-10 17:27:09 -05:00
2023-10-24 11:22:24 -05:00
2023-12-08 08:46:55 -05:00
2023-10-31 11:25:20 -07:00
2023-10-20 07:55:22 +01:00
2023-10-31 17:06:02 -04:00
2023-12-08 08:46:55 -05:00
2023-09-18 10:30:15 -05:00
2023-12-08 08:46:55 -05:00
2023-08-10 17:27:09 -05:00
2023-12-08 08:46:55 -05:00
2023-08-10 17:27:09 -05:00
2023-12-08 08:46:55 -05:00
2023-08-10 17:27:09 -05:00
2023-08-10 17:27:09 -05:00
2023-08-10 17:27:09 -05:00
2023-12-08 08:46:55 -05:00
2023-11-06 10:26:20 -05:00
2023-08-18 07:47:24 +01:00
2023-08-18 07:47:24 +01:00
2023-08-10 17:27:09 -05:00
2023-12-11 10:07:32 -06:00
2023-10-17 13:46:49 -04:00
2023-12-08 08:46:55 -05:00
2023-12-06 12:28:42 +01:00
2023-08-10 17:27:09 -05:00
2023-10-13 09:06:36 -04:00
2023-12-08 08:46:55 -05:00
2023-08-10 17:27:09 -05:00
2023-12-08 08:46:55 -05:00
2023-08-10 17:27:09 -05:00
2023-08-14 16:17:25 -04:00
2023-08-10 17:27:09 -05:00
2023-12-07 14:15:08 -05:00
2023-12-07 14:15:08 -05:00
2023-08-18 07:47:24 +01:00
2024-01-05 08:45:07 -06:00
2024-01-05 08:45:07 -06:00
2023-10-05 11:56:17 -05:00
2023-12-08 08:46:55 -05:00
2023-08-10 17:27:09 -05:00
2023-08-10 17:27:09 -05:00
2023-08-18 07:47:24 +01:00
2023-09-04 11:31:55 +01:00
2024-01-05 08:12:27 +00:00
2024-01-05 08:12:27 +00:00
2023-08-10 17:27:09 -05:00
2023-12-08 08:46:55 -05:00
2023-11-06 10:26:20 -05:00
2023-09-21 14:12:51 -04:00
2023-12-12 11:44:54 -05:00
2023-12-12 11:44:54 -05:00
2023-09-28 16:50:21 -04:00
2023-11-07 08:37:06 -05:00
2023-09-15 13:58:37 -04:00
2023-08-10 17:27:09 -05:00
2023-08-10 17:27:09 -05:00
2023-12-01 13:51:21 -05:00
2023-12-01 13:51:21 -05:00
2023-08-18 07:47:24 +01:00
2023-08-10 17:27:09 -05:00
2023-10-19 15:09:30 -05:00
2023-10-19 15:09:30 -05:00
2023-10-19 15:09:30 -05:00
2024-01-02 16:46:34 -05:00
2023-10-19 15:09:30 -05:00
2024-01-02 16:46:34 -05:00
2023-11-16 12:05:59 -05:00
2023-11-16 12:05:59 -05:00
2023-11-23 08:10:56 +00:00
2023-08-10 17:27:09 -05:00
2023-08-10 17:27:09 -05:00
2023-12-08 08:46:55 -05:00
2023-10-31 11:25:20 -07:00
2023-12-08 08:46:55 -05:00
2023-10-05 09:32:54 +02:00
2023-10-11 09:47:10 +02:00
2023-12-08 08:46:55 -05:00
2023-08-18 07:47:24 +01:00
2023-08-23 15:42:13 -05:00
2023-10-31 11:25:20 -07:00
2023-09-21 17:56:33 +02:00
2023-08-10 17:27:09 -05:00
2023-08-10 17:27:09 -05:00
2023-12-08 08:46:55 -05:00
2023-12-01 13:25:43 -05:00
2023-12-08 08:46:55 -05:00
2023-08-18 07:47:24 +01:00
2023-10-31 11:25:20 -07:00
2023-12-08 08:46:55 -05:00
2023-10-31 11:25:20 -07:00
2023-10-16 09:30:24 -04:00
2023-08-10 17:27:09 -05:00
2023-12-08 08:46:55 -05:00
2023-08-10 17:27:09 -05:00
2023-08-10 17:27:09 -05:00
2023-08-18 07:47:24 +01:00
2023-08-10 17:27:09 -05:00
2023-12-08 08:46:55 -05:00
2023-08-10 17:27:09 -05:00
2023-08-10 17:27:09 -05:00
2023-10-19 15:09:30 -05:00
2023-12-08 08:46:55 -05:00
2023-08-25 13:51:36 +01:00
2023-12-08 08:46:55 -05:00
2023-08-10 17:27:09 -05:00
2023-08-10 17:27:09 -05:00
2023-12-08 08:46:55 -05:00
2023-08-10 17:27:09 -05:00
2023-08-10 17:27:09 -05:00
2023-08-10 17:27:09 -05:00
2023-12-08 08:46:55 -05:00
2023-10-12 12:21:48 -04:00
2023-12-08 08:46:55 -05:00
2023-08-10 17:27:09 -05:00
2023-12-08 08:46:55 -05:00
2023-08-18 07:47:24 +01:00
2023-08-23 15:42:13 -05:00
2023-12-08 08:46:55 -05:00
2023-08-10 17:27:09 -05:00
2023-08-10 17:27:09 -05:00
2023-08-18 07:47:24 +01:00
2023-11-06 10:26:20 -05:00
2024-01-05 08:45:07 -06:00
2023-10-31 11:25:20 -07:00
2023-12-08 08:46:55 -05:00
2023-08-10 17:27:09 -05:00
2023-08-10 17:27:09 -05:00
2023-08-10 17:27:09 -05:00
2023-10-16 09:30:24 -04:00
2023-08-10 17:27:09 -05:00
2023-10-16 09:30:24 -04:00
2023-08-18 07:47:24 +01:00
2023-11-06 10:26:20 -05:00
2023-08-10 17:27:09 -05:00
2023-08-10 17:27:09 -05:00
2023-08-25 13:51:36 +01:00
2023-10-12 12:21:48 -04:00
2023-10-31 11:25:20 -07:00
2023-12-08 08:46:55 -05:00
2023-10-16 19:37:57 -04:00
2023-10-13 07:39:06 +01:00
2023-08-10 17:27:09 -05:00
2023-12-08 08:46:55 -05:00
2022-01-06 11:56:13 -05:00
2022-01-06 11:56:13 -05:00
2024-01-05 08:45:07 -06:00
2024-01-05 08:45:07 -06:00