mirror of
https://github.com/kemko/nomad.git
synced 2026-01-06 10:25:42 +03:00
2b04d47ac2
also ensure that volume ID is uuid-shaped so user-provided input like `id = "../../../"` which is used as part of the target directory can not find its way very far into the volume submission process
95 lines
3.0 KiB
Go
95 lines
3.0 KiB
Go
// Copyright (c) HashiCorp, Inc.
|
|
// SPDX-License-Identifier: BUSL-1.1
|
|
|
|
package client
|
|
|
|
import (
|
|
"path/filepath"
|
|
"testing"
|
|
|
|
"github.com/hashicorp/nomad/ci"
|
|
"github.com/hashicorp/nomad/client/hostvolumemanager"
|
|
cstructs "github.com/hashicorp/nomad/client/structs"
|
|
"github.com/hashicorp/nomad/helper/testlog"
|
|
"github.com/shoenig/test/must"
|
|
)
|
|
|
|
func TestHostVolume(t *testing.T) {
|
|
ci.Parallel(t)
|
|
|
|
client, cleanup := TestClient(t, nil)
|
|
defer cleanup()
|
|
|
|
tmp := t.TempDir()
|
|
expectDir := filepath.Join(tmp, "test-vol-id")
|
|
hvm := hostvolumemanager.NewHostVolumeManager(tmp, testlog.HCLogger(t))
|
|
client.hostVolumeManager = hvm
|
|
|
|
t.Run("happy", func(t *testing.T) {
|
|
req := &cstructs.ClientHostVolumeCreateRequest{
|
|
ID: "test-vol-id",
|
|
Name: "test-vol-name",
|
|
PluginID: "mkdir", // real plugin really makes a dir
|
|
}
|
|
var resp cstructs.ClientHostVolumeCreateResponse
|
|
err := client.ClientRPC("HostVolume.Create", req, &resp)
|
|
must.NoError(t, err)
|
|
must.Eq(t, cstructs.ClientHostVolumeCreateResponse{
|
|
HostPath: expectDir,
|
|
CapacityBytes: 0, // "mkdir" always returns zero
|
|
}, resp)
|
|
// technically this is testing "mkdir" more than the RPC
|
|
must.DirExists(t, expectDir)
|
|
|
|
delReq := &cstructs.ClientHostVolumeDeleteRequest{
|
|
ID: "test-vol-id",
|
|
PluginID: "mkdir",
|
|
HostPath: expectDir,
|
|
}
|
|
var delResp cstructs.ClientHostVolumeDeleteResponse
|
|
err = client.ClientRPC("HostVolume.Delete", delReq, &delResp)
|
|
must.NoError(t, err)
|
|
must.NotNil(t, delResp)
|
|
// again, actually testing the "mkdir" plugin
|
|
must.DirNotExists(t, expectDir)
|
|
})
|
|
|
|
t.Run("missing plugin", func(t *testing.T) {
|
|
req := &cstructs.ClientHostVolumeCreateRequest{
|
|
PluginID: "non-existent",
|
|
}
|
|
var resp cstructs.ClientHostVolumeCreateResponse
|
|
err := client.ClientRPC("HostVolume.Create", req, &resp)
|
|
must.EqError(t, err, `no such plugin "non-existent"`)
|
|
|
|
delReq := &cstructs.ClientHostVolumeDeleteRequest{
|
|
PluginID: "non-existent",
|
|
}
|
|
var delResp cstructs.ClientHostVolumeDeleteResponse
|
|
err = client.ClientRPC("HostVolume.Delete", delReq, &delResp)
|
|
must.EqError(t, err, `no such plugin "non-existent"`)
|
|
})
|
|
|
|
t.Run("error from plugin", func(t *testing.T) {
|
|
// "mkdir" plugin can't create a directory within a file
|
|
client.hostVolumeManager = hostvolumemanager.NewHostVolumeManager("host_volume_endpoint_test.go", testlog.HCLogger(t))
|
|
|
|
req := &cstructs.ClientHostVolumeCreateRequest{
|
|
ID: "test-vol-id",
|
|
Name: "test-vol-name",
|
|
PluginID: "mkdir",
|
|
}
|
|
var resp cstructs.ClientHostVolumeCreateResponse
|
|
err := client.ClientRPC("HostVolume.Create", req, &resp)
|
|
must.ErrorContains(t, err, "host_volume_endpoint_test.go/test-vol-id: not a directory")
|
|
|
|
delReq := &cstructs.ClientHostVolumeDeleteRequest{
|
|
ID: "test-vol-id",
|
|
PluginID: "mkdir",
|
|
}
|
|
var delResp cstructs.ClientHostVolumeDeleteResponse
|
|
err = client.ClientRPC("HostVolume.Delete", delReq, &delResp)
|
|
must.ErrorContains(t, err, "host_volume_endpoint_test.go/test-vol-id: not a directory")
|
|
})
|
|
}
|