mirror of
https://github.com/kemko/nomad.git
synced 2026-01-03 08:55:43 +03:00
7d0f87b910
CSI `CreateVolume` RPC is idempotent given that the topology, capabilities, and parameters are unchanged. CSI volumes have many user-defined fields that are immutable once set, and many fields that are not user-settable. Update the `Register` RPC so that updating a volume via the API merges onto any existing volume without touching Nomad-controlled fields, while validating it with the same strict requirements expected for idempotent `CreateVolume` RPCs. Also, clarify that this state store method is used for everything, not just for the `Register` RPC.
59 lines
1.3 KiB
Go
59 lines
1.3 KiB
Go
package command
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/hashicorp/nomad/helper/uuid"
|
|
"github.com/hashicorp/nomad/nomad/structs"
|
|
"github.com/mitchellh/cli"
|
|
"github.com/posener/complete"
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
func TestCSIVolumeStatusCommand_Implements(t *testing.T) {
|
|
t.Parallel()
|
|
var _ cli.Command = &VolumeStatusCommand{}
|
|
}
|
|
|
|
func TestCSIVolumeStatusCommand_Fails(t *testing.T) {
|
|
t.Parallel()
|
|
ui := cli.NewMockUi()
|
|
cmd := &VolumeStatusCommand{Meta: Meta{Ui: ui}}
|
|
|
|
// Fails on misuse
|
|
code := cmd.Run([]string{"some", "bad", "args"})
|
|
require.Equal(t, 1, code)
|
|
|
|
out := ui.ErrorWriter.String()
|
|
require.Contains(t, out, commandErrorText(cmd))
|
|
ui.ErrorWriter.Reset()
|
|
}
|
|
|
|
func TestCSIVolumeStatusCommand_AutocompleteArgs(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
srv, _, url := testServer(t, true, nil)
|
|
defer srv.Shutdown()
|
|
|
|
ui := cli.NewMockUi()
|
|
cmd := &VolumeStatusCommand{Meta: Meta{Ui: ui, flagAddress: url}}
|
|
|
|
state := srv.Agent.Server().State()
|
|
|
|
vol := &structs.CSIVolume{
|
|
ID: uuid.Generate(),
|
|
Namespace: "default",
|
|
PluginID: "glade",
|
|
}
|
|
|
|
require.NoError(t, state.UpsertCSIVolume(1000, []*structs.CSIVolume{vol}))
|
|
|
|
prefix := vol.ID[:len(vol.ID)-5]
|
|
args := complete.Args{Last: prefix}
|
|
predictor := cmd.AutocompleteArgs()
|
|
|
|
res := predictor.Predict(args)
|
|
require.Equal(t, 1, len(res))
|
|
require.Equal(t, vol.ID, res[0])
|
|
}
|