mirror of
https://github.com/kemko/nomad.git
synced 2026-01-05 18:05:42 +03:00
Several commands that inspect objects where the names are user-controlled share a bug where the user cannot inspect the object if it has a name that is an exact prefix of the name of another object (in the same namespace, where applicable). For example, the object "test" can't be inspected if there's an object with the name "testing". Copy existing logic we have for jobs, node pools, etc. to the impacted commands: * `plugin status` * `quota inspect` * `quota status` * `scaling policy info` * `service info` * `volume deregister` * `volume detach` * `volume status` If we get multiple objects for the prefix query, we check if any of them are an exact match and use that object instead of returning an error. Where possible because the prefix query signatures are the same, use a generic function that can be shared across multiple commands. Fixes: https://github.com/hashicorp/nomad/issues/13920 Fixes: https://github.com/hashicorp/nomad/issues/17132 Fixes: https://github.com/hashicorp/nomad/issues/23236 Ref: https://hashicorp.atlassian.net/browse/NET-10054 Ref: https://hashicorp.atlassian.net/browse/NET-10055
206 lines
5.2 KiB
Go
206 lines
5.2 KiB
Go
// Copyright (c) HashiCorp, Inc.
|
|
// SPDX-License-Identifier: BUSL-1.1
|
|
|
|
package command
|
|
|
|
import (
|
|
"fmt"
|
|
"strings"
|
|
|
|
"github.com/mitchellh/cli"
|
|
"github.com/posener/complete"
|
|
|
|
"github.com/hashicorp/nomad/api"
|
|
"github.com/hashicorp/nomad/api/contexts"
|
|
)
|
|
|
|
// Ensure ScalingPolicyInfoCommand satisfies the cli.Command interface.
|
|
var _ cli.Command = &ScalingPolicyInfoCommand{}
|
|
|
|
// ScalingPolicyListCommand implements cli.Command.
|
|
type ScalingPolicyInfoCommand struct {
|
|
Meta
|
|
}
|
|
|
|
// Help satisfies the cli.Command Help function.
|
|
func (s *ScalingPolicyInfoCommand) Help() string {
|
|
helpText := `
|
|
Usage: nomad scaling policy info [options] <policy_id>
|
|
|
|
Info is used to read the specified scaling policy.
|
|
|
|
If ACLs are enabled, this command requires a token with the 'read-job' and
|
|
'list-jobs' capabilities for the policy's namespace.
|
|
|
|
General Options:
|
|
|
|
` + generalOptionsUsage(usageOptsDefault) + `
|
|
|
|
Policy Info Options:
|
|
|
|
-verbose
|
|
Display full information.
|
|
|
|
-json
|
|
Output the scaling policy in its JSON format.
|
|
|
|
-t
|
|
Format and display the scaling policy using a Go template.
|
|
`
|
|
return strings.TrimSpace(helpText)
|
|
}
|
|
|
|
// Synopsis satisfies the cli.Command Synopsis function.
|
|
func (s *ScalingPolicyInfoCommand) Synopsis() string {
|
|
return "Display an individual Nomad scaling policy"
|
|
}
|
|
|
|
func (s *ScalingPolicyInfoCommand) AutocompleteFlags() complete.Flags {
|
|
return mergeAutocompleteFlags(s.Meta.AutocompleteFlags(FlagSetClient),
|
|
complete.Flags{
|
|
"-verbose": complete.PredictNothing,
|
|
"-json": complete.PredictNothing,
|
|
"-t": complete.PredictAnything,
|
|
})
|
|
}
|
|
|
|
func (s *ScalingPolicyInfoCommand) AutocompleteArgs() complete.Predictor {
|
|
return complete.PredictFunc(func(a complete.Args) []string {
|
|
client, err := s.Meta.Client()
|
|
if err != nil {
|
|
return nil
|
|
}
|
|
|
|
resp, _, err := client.Search().PrefixSearch(a.Last, contexts.ScalingPolicies, nil)
|
|
if err != nil {
|
|
return []string{}
|
|
}
|
|
return resp.Matches[contexts.ScalingPolicies]
|
|
})
|
|
}
|
|
|
|
// Name returns the name of this command.
|
|
func (s *ScalingPolicyInfoCommand) Name() string { return "scaling policy info" }
|
|
|
|
// Run satisfies the cli.Command Run function.
|
|
func (s *ScalingPolicyInfoCommand) Run(args []string) int {
|
|
var json, verbose bool
|
|
var tmpl string
|
|
|
|
flags := s.Meta.FlagSet(s.Name(), FlagSetClient)
|
|
flags.Usage = func() { s.Ui.Output(s.Help()) }
|
|
flags.BoolVar(&verbose, "verbose", false, "")
|
|
flags.BoolVar(&json, "json", false, "")
|
|
flags.StringVar(&tmpl, "t", "", "")
|
|
if err := flags.Parse(args); err != nil {
|
|
return 1
|
|
}
|
|
|
|
// Truncate the id unless full length is requested
|
|
length := shortId
|
|
if verbose {
|
|
length = fullId
|
|
}
|
|
|
|
// Get the HTTP client.
|
|
client, err := s.Meta.Client()
|
|
if err != nil {
|
|
s.Ui.Error(fmt.Sprintf("Error initializing client: %s", err))
|
|
return 1
|
|
}
|
|
|
|
args = flags.Args()
|
|
|
|
// Formatted list mode if no policy ID
|
|
if len(args) == 0 && (json || len(tmpl) > 0) {
|
|
policies, _, err := client.Scaling().ListPolicies(nil)
|
|
if err != nil {
|
|
s.Ui.Error(fmt.Sprintf("Error listing scaling policies: %v", err))
|
|
return 1
|
|
}
|
|
out, err := Format(json, tmpl, policies)
|
|
if err != nil {
|
|
s.Ui.Error(err.Error())
|
|
return 1
|
|
}
|
|
s.Ui.Output(out)
|
|
return 0
|
|
}
|
|
|
|
if len(args) != 1 {
|
|
s.Ui.Error("This command takes one of the following argument conditions:")
|
|
s.Ui.Error(" * A single <policy_id>")
|
|
s.Ui.Error(" * No arguments, with output format specified")
|
|
s.Ui.Error(commandErrorText(s))
|
|
return 1
|
|
}
|
|
policyID := args[0]
|
|
if len(policyID) == 1 {
|
|
s.Ui.Error("Identifier must contain at least two characters.")
|
|
return 1
|
|
}
|
|
|
|
policyID = sanitizeUUIDPrefix(policyID)
|
|
|
|
// get a policy that matches the given prefix or a list of all matches if an
|
|
// exact match is not found.
|
|
policyStub, possible, err := getByPrefix[api.ScalingPolicyListStub]("scaling policies",
|
|
client.Scaling().ListPolicies,
|
|
func(policy *api.ScalingPolicyListStub, prefix string) bool { return policy.ID == prefix },
|
|
&api.QueryOptions{
|
|
Prefix: policyID,
|
|
})
|
|
if err != nil {
|
|
s.Ui.Error(fmt.Sprintf("Error querying scaling policy: %v", err))
|
|
return 1
|
|
}
|
|
if len(possible) > 0 {
|
|
out := formatScalingPolicies(possible, length)
|
|
s.Ui.Error(fmt.Sprintf("Prefix matched multiple scaling policies\n\n%s", out))
|
|
return 1
|
|
}
|
|
policyID = policyStub.ID
|
|
|
|
policy, _, err := client.Scaling().GetPolicy(policyID, nil)
|
|
if err != nil {
|
|
s.Ui.Error(fmt.Sprintf("Error querying scaling policy: %s", err))
|
|
return 1
|
|
}
|
|
|
|
if json || len(tmpl) > 0 {
|
|
out, err := Format(json, tmpl, policy)
|
|
if err != nil {
|
|
s.Ui.Error(err.Error())
|
|
return 1
|
|
}
|
|
|
|
s.Ui.Output(out)
|
|
return 0
|
|
}
|
|
|
|
// Format the policy document which is a freeform map[string]interface{}
|
|
// and therefore can only be made pretty to a certain extent. Do this
|
|
// before the rest of the formatting so any errors are clearly passed back
|
|
// to the CLI.
|
|
out := "<empty>"
|
|
if len(policy.Policy) > 0 {
|
|
out, err = Format(true, "", policy.Policy)
|
|
if err != nil {
|
|
s.Ui.Error(err.Error())
|
|
return 1
|
|
}
|
|
}
|
|
|
|
info := []string{
|
|
fmt.Sprintf("ID|%s", limit(policy.ID, length)),
|
|
fmt.Sprintf("Enabled|%v", *policy.Enabled),
|
|
fmt.Sprintf("Target|%s", formatScalingPolicyTarget(policy.Target)),
|
|
fmt.Sprintf("Min|%v", *policy.Min),
|
|
fmt.Sprintf("Max|%v", *policy.Max),
|
|
}
|
|
s.Ui.Output(formatKV(info))
|
|
s.Ui.Output("\nPolicy:")
|
|
s.Ui.Output(out)
|
|
return 0
|
|
}
|