Michael Schurter
f998a2b77b
core: merge reserved_ports into host_networks ( #13651 )
...
Fixes #13505
This fixes #13505 by treating reserved_ports like we treat a lot of jobspec settings: merging settings from more global stanzas (client.reserved.reserved_ports) "down" into more specific stanzas (client.host_networks[].reserved_ports).
As discussed in #13505 there are other options, and since it's totally broken right now we have some flexibility:
Treat overlapping reserved_ports on addresses as invalid and refuse to start agents. However, I'm not sure there's a cohesive model we want to publish right now since so much 0.9-0.12 compat code still exists! We would have to explain to folks that if their -network-interface and host_network addresses overlapped, they could only specify reserved_ports in one place or the other?! It gets ugly.
Use the global client.reserved.reserved_ports value as the default and treat host_network[].reserverd_ports as overrides. My first suggestion in the issue, but @groggemans made me realize the addresses on the agent's interface (as configured by -network-interface) may overlap with host_networks, so you'd need to remove the global reserved_ports from addresses shared with a shared network?! This seemed really confusing and subtle for users to me.
So I think "merging down" creates the most expressive yet understandable approach. I've played around with it a bit, and it doesn't seem too surprising. The only frustrating part is how difficult it is to observe the available addresses and ports on a node! However that's a job for another PR.
2022-07-12 14:40:25 -07:00
..
2022-07-12 14:40:25 -07:00
2022-06-08 15:06:00 -04:00
2022-02-23 14:43:59 -06:00
2022-05-19 12:13:34 -05:00
2022-06-03 07:37:24 -04:00
2022-06-03 07:37:24 -04:00
2022-03-15 12:58:52 -05:00
2020-11-20 13:38:29 -05:00
2022-03-15 12:58:52 -05:00
2020-11-20 13:38:29 -05:00
2022-03-15 12:58:52 -05:00
2020-11-20 13:38:29 -05:00
2022-03-15 12:58:52 -05:00
2020-12-09 11:05:18 -08:00
2020-10-12 08:47:05 -04:00
2022-03-15 12:58:52 -05:00
2020-11-19 16:28:39 -05:00
2022-03-15 12:58:52 -05:00
2020-11-19 16:28:39 -05:00
2022-03-15 12:58:52 -05:00
2020-11-19 16:28:39 -05:00
2022-03-15 12:58:52 -05:00
2020-12-09 11:05:18 -08:00
2022-03-15 12:58:52 -05:00
2020-11-19 16:28:39 -05:00
2022-03-15 12:58:52 -05:00
2020-11-19 16:28:39 -05:00
2018-04-18 12:02:11 -04:00
2018-04-18 12:02:11 -04:00
2022-03-15 12:58:52 -05:00
2021-06-11 15:39:28 -04:00
2022-03-15 12:58:52 -05:00
2020-12-09 11:05:18 -08:00
2022-03-15 12:58:52 -05:00
2021-10-01 10:14:28 -04:00
2019-05-12 22:04:50 -04:00
2022-06-26 15:35:27 +02:00
2022-03-15 12:58:52 -05:00
2021-12-20 11:44:21 +01:00
2022-03-15 12:58:52 -05:00
2021-12-20 11:44:21 +01:00
2022-03-15 12:58:52 -05:00
2022-05-27 13:18:47 +02:00
2022-03-15 12:58:52 -05:00
2021-12-20 11:44:21 +01:00
2022-05-12 11:42:40 -04:00
2022-04-15 09:26:19 -04:00
2022-03-15 12:58:52 -05:00
2021-12-20 11:44:21 +01:00
2018-04-18 12:02:11 -04:00
2022-03-15 12:58:52 -05:00
2020-11-19 16:28:39 -05:00
2021-10-01 10:14:28 -04:00
2022-07-12 12:49:39 -04:00
2022-05-12 11:42:40 -04:00
2022-02-08 16:52:35 -05:00
2022-02-08 16:52:35 -05:00
2022-03-15 12:58:52 -05:00
2020-03-31 09:45:21 -04:00
2022-03-15 12:58:52 -05:00
2022-06-21 06:01:23 -04:00
2022-03-15 12:58:52 -05:00
2022-02-16 11:40:30 -05:00
2022-03-15 12:58:52 -05:00
2020-11-20 13:38:29 -05:00
2022-03-15 12:58:52 -05:00
2022-06-21 06:01:23 -04:00
2022-03-15 12:58:52 -05:00
2022-06-21 06:01:23 -04:00
2022-03-15 12:58:52 -05:00
2022-06-26 15:35:27 +02:00
2022-03-15 12:58:52 -05:00
2022-06-21 06:01:23 -04:00
2018-05-24 12:44:21 -04:00
2022-07-06 16:30:11 +02:00
2022-07-07 13:13:34 -04:00
2022-03-15 12:58:52 -05:00
2022-07-07 13:13:34 -04:00
2022-03-15 12:58:52 -05:00
2022-07-07 13:13:34 -04:00
2022-07-07 13:13:34 -04:00
2022-03-15 12:58:52 -05:00
2020-11-02 18:00:53 -05:00
2022-03-15 12:58:52 -05:00
2018-12-10 12:18:24 -05:00
2022-04-21 13:20:36 -07:00
2022-05-24 16:29:39 -04:00
2022-05-25 08:19:40 -05:00
2022-03-15 12:58:52 -05:00
2021-10-19 16:52:11 -07:00
2022-03-15 12:58:52 -05:00
2021-10-19 16:52:11 -07:00
2022-03-15 12:58:52 -05:00
2021-10-22 12:39:05 -04:00
2022-03-15 12:58:52 -05:00
2020-11-20 13:38:29 -05:00
2022-03-15 12:58:52 -05:00
2021-10-19 16:52:11 -07:00
2022-05-12 11:42:40 -04:00
2022-06-08 15:06:00 -04:00
2019-12-19 14:59:12 -05:00
2022-03-15 12:58:52 -05:00
2021-10-19 16:52:11 -07:00
2022-03-15 12:58:52 -05:00
2020-11-20 13:38:29 -05:00
2019-04-12 20:55:55 +00:00
2022-04-21 13:20:36 -07:00
2022-04-21 13:20:36 -07:00
2022-03-15 12:58:52 -05:00
2022-06-21 06:01:23 -04:00
2022-03-15 12:58:52 -05:00
2022-06-15 14:20:29 -04:00
2022-04-21 13:20:36 -07:00
2022-04-22 10:46:34 -04:00
2022-03-15 12:58:52 -05:00
2020-11-20 13:38:29 -05:00
2022-03-15 12:58:52 -05:00
2020-11-20 13:38:29 -05:00
2022-03-15 12:58:52 -05:00
2022-04-05 17:12:23 -04:00
2022-03-15 12:58:52 -05:00
2021-12-13 14:54:53 -05:00
2022-05-19 12:13:34 -05:00
2022-05-19 12:13:34 -05:00
2018-04-18 12:02:11 -04:00
2022-03-15 12:58:52 -05:00
2021-04-28 12:00:30 -04:00
2021-04-28 12:00:30 -04:00
2022-03-15 12:58:52 -05:00
2022-03-23 12:56:48 +01:00
2022-03-15 12:58:52 -05:00
2020-12-08 12:47:04 -08:00
2022-03-15 12:58:52 -05:00
2022-07-06 16:13:48 +02:00
2022-03-15 12:58:52 -05:00
2022-04-21 14:53:45 -04:00
2022-03-15 12:58:52 -05:00
2020-11-20 13:38:29 -05:00
2022-03-15 12:58:52 -05:00
2020-11-20 13:38:29 -05:00
2022-03-15 12:58:52 -05:00
2020-11-20 13:38:29 -05:00
2022-03-04 14:13:48 -08:00
2022-03-15 12:58:52 -05:00
2022-03-04 14:13:48 -08:00
2021-02-23 08:31:19 -08:00
2022-03-15 12:58:52 -05:00
2020-12-09 11:05:18 -08:00
2022-03-15 12:58:52 -05:00
2022-07-11 09:50:42 +02:00
2022-03-15 12:58:52 -05:00
2020-12-09 11:05:18 -08:00
2022-04-05 15:53:43 -04:00
2022-07-11 09:50:42 +02:00
2020-11-30 11:12:06 -05:00
2022-03-15 12:58:52 -05:00
2022-03-01 16:44:15 -08:00
2022-03-15 12:58:52 -05:00
2020-11-20 13:38:29 -05:00
2022-03-15 12:58:52 -05:00
2020-12-14 10:07:27 -06:00
2022-03-15 12:58:52 -05:00
2018-04-18 12:02:11 -04:00
2022-04-28 13:18:55 -04:00
2022-07-06 10:57:44 -04:00
2022-07-11 13:34:06 -04:00
2022-07-11 13:34:06 -04:00
2022-07-11 13:34:06 -04:00
2022-07-11 13:34:06 -04:00
2022-07-11 13:34:06 -04:00
2022-07-11 13:34:06 -04:00
2022-07-11 13:34:06 -04:00
2022-07-11 13:34:06 -04:00
2021-12-16 10:32:11 -05:00
2022-03-15 12:58:52 -05:00
2020-11-20 13:38:29 -05:00
2021-12-16 13:38:58 -05:00
2022-03-15 12:58:52 -05:00
2020-11-20 13:38:29 -05:00
2021-12-16 10:32:11 -05:00
2022-03-15 12:58:52 -05:00
2021-12-16 10:32:11 -05:00
2022-07-06 16:13:48 +02:00
2022-07-06 16:13:48 +02:00
2022-07-06 16:13:48 +02:00
2022-07-06 16:13:48 +02:00
2022-07-06 16:13:48 +02:00
2022-07-11 13:34:05 -04:00
2022-07-11 13:34:05 -04:00
2022-07-11 13:34:05 -04:00
2022-07-11 13:34:05 -04:00
2022-07-11 13:34:06 -04:00
2022-05-12 11:42:40 -04:00
2020-06-19 12:19:38 -04:00
2022-05-12 11:42:40 -04:00
2020-11-19 16:28:39 -05:00
2022-05-12 11:42:40 -04:00
2020-11-19 16:28:39 -05:00
2022-07-11 10:48:00 -04:00
2020-05-21 20:04:38 -04:00
2022-03-15 12:58:52 -05:00
2018-04-18 12:02:11 -04:00
2022-03-22 09:48:38 -04:00
2022-03-15 12:58:52 -05:00
2021-06-07 13:53:28 +02:00
2020-03-23 13:58:30 -04:00
2022-03-15 12:58:52 -05:00
2021-04-30 09:48:03 -04:00
2022-03-15 12:58:52 -05:00
2020-11-20 13:38:29 -05:00
2022-05-12 11:42:40 -04:00
2021-04-30 09:48:03 -04:00
2022-03-15 12:58:52 -05:00
2020-11-20 13:38:29 -05:00
2022-03-15 12:58:52 -05:00
2020-11-20 13:38:29 -05:00
2022-03-15 12:58:52 -05:00
2021-05-19 16:56:06 -04:00
2018-04-18 12:02:11 -04:00
2022-03-15 12:58:52 -05:00
2020-12-09 11:05:18 -08:00
2022-03-15 12:58:52 -05:00
2020-12-09 11:05:18 -08:00
2022-03-15 12:58:52 -05:00
2020-11-20 13:38:29 -05:00
2022-03-30 08:48:23 -05:00
2020-11-20 13:38:29 -05:00
2020-11-06 11:16:24 +01:00
2022-03-15 12:58:52 -05:00
2021-12-20 11:44:21 +01:00
2022-03-15 12:58:52 -05:00
2021-02-04 15:08:13 +00:00
2022-03-15 12:58:52 -05:00
2020-10-06 12:18:17 +02:00
2020-10-05 15:18:30 +02:00
2022-03-15 12:58:52 -05:00
2020-11-20 13:38:29 -05:00
2022-03-15 12:58:52 -05:00
2020-11-20 13:38:29 -05:00
2022-03-15 12:58:52 -05:00
2020-11-20 13:38:29 -05:00
2022-03-15 12:58:52 -05:00
2020-11-20 13:38:29 -05:00
2018-04-18 12:02:11 -04:00
2022-03-15 12:58:52 -05:00
2020-11-20 13:38:29 -05:00
2022-03-15 12:58:52 -05:00
2020-11-19 16:28:39 -05:00
2022-03-17 14:15:10 -04:00
2022-03-17 14:15:10 -04:00
2018-04-18 12:02:11 -04:00
2022-04-06 08:36:23 +01:00
2022-03-24 09:08:45 +01:00
2022-04-22 09:14:29 -05:00
2022-04-22 09:15:51 -05:00
2022-03-24 08:45:13 +01:00
2022-03-24 09:08:45 +01:00
2022-03-21 11:59:03 +01:00
2022-03-15 12:58:52 -05:00
2021-12-20 11:44:21 +01:00
2022-03-15 12:58:52 -05:00
2021-06-28 10:57:50 +02:00
2022-03-15 12:58:52 -05:00
2021-06-28 10:57:50 +02:00
2022-03-15 12:58:52 -05:00
2020-01-13 11:34:46 +01:00
2022-03-15 12:58:52 -05:00
2020-01-13 11:34:46 +01:00
2022-03-15 12:58:52 -05:00
2021-10-21 16:24:39 -04:00
2022-04-07 15:00:07 -04:00
2022-07-12 12:49:39 -04:00
2022-07-12 12:49:39 -04:00
2022-07-12 12:49:39 -04:00
2022-03-15 12:58:52 -05:00
2018-04-18 12:02:11 -04:00
2021-03-31 16:37:09 -04:00
2021-03-31 16:37:09 -04:00
2022-04-05 08:59:11 -04:00
2022-03-01 07:57:29 -05:00
2022-03-01 07:57:29 -05:00
2022-03-29 14:46:39 -04:00
2022-03-07 11:06:59 -05:00
2022-03-29 14:46:39 -04:00
2020-11-20 13:38:29 -05:00
2022-03-24 10:29:50 -04:00
2022-03-24 10:29:50 -04:00
2022-04-01 19:24:02 -05:00
2022-03-01 13:30:30 -05:00
2022-04-22 09:25:04 -04:00
2022-03-15 12:58:52 -05:00
2022-03-22 09:48:38 -04:00
2021-03-31 16:37:09 -04:00