mirror of
https://github.com/kemko/nomad.git
synced 2026-01-01 16:05:42 +03:00
fca4ee8e05
* test: use `T.TempDir` to create temporary test directory
This commit replaces `ioutil.TempDir` with `t.TempDir` in tests. The
directory created by `t.TempDir` is automatically removed when the test
and all its subtests complete.
Prior to this commit, temporary directory created using `ioutil.TempDir`
needs to be removed manually by calling `os.RemoveAll`, which is omitted
in some tests. The error handling boilerplate e.g.
defer func() {
if err := os.RemoveAll(dir); err != nil {
t.Fatal(err)
}
}
is also tedious, but `t.TempDir` handles this for us nicely.
Reference: https://pkg.go.dev/testing#T.TempDir
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
* test: fix TestLogmon_Start_restart on Windows
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
* test: fix failing TestConsul_Integration
t.TempDir fails to perform the cleanup properly because the folder is
still in use
testing.go:967: TempDir RemoveAll cleanup: unlinkat /tmp/TestConsul_Integration2837567823/002/191a6f1a-5371-cf7c-da38-220fe85d10e5/web/secrets: device or resource busy
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
67 lines
1.5 KiB
Go
67 lines
1.5 KiB
Go
package command
|
|
|
|
import (
|
|
"os"
|
|
"path/filepath"
|
|
"testing"
|
|
|
|
"github.com/hashicorp/nomad/ci"
|
|
"github.com/hashicorp/nomad/command/agent"
|
|
"github.com/hashicorp/nomad/helper/snapshot"
|
|
"github.com/mitchellh/cli"
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
func TestOperatorSnapshotSave_Works(t *testing.T) {
|
|
ci.Parallel(t)
|
|
|
|
tmpDir := t.TempDir()
|
|
|
|
srv, _, url := testServer(t, false, func(c *agent.Config) {
|
|
c.DevMode = false
|
|
c.DataDir = filepath.Join(tmpDir, "server")
|
|
|
|
c.AdvertiseAddrs.HTTP = "127.0.0.1"
|
|
c.AdvertiseAddrs.RPC = "127.0.0.1"
|
|
c.AdvertiseAddrs.Serf = "127.0.0.1"
|
|
})
|
|
|
|
defer srv.Shutdown()
|
|
|
|
ui := cli.NewMockUi()
|
|
cmd := &OperatorSnapshotSaveCommand{Meta: Meta{Ui: ui}}
|
|
|
|
dest := filepath.Join(tmpDir, "backup.snap")
|
|
code := cmd.Run([]string{
|
|
"--address=" + url,
|
|
dest,
|
|
})
|
|
require.Zero(t, code)
|
|
require.Contains(t, ui.OutputWriter.String(), "State file written to "+dest)
|
|
|
|
f, err := os.Open(dest)
|
|
require.NoError(t, err)
|
|
|
|
meta, err := snapshot.Verify(f)
|
|
require.NoError(t, err)
|
|
require.NotZero(t, meta.Index)
|
|
}
|
|
|
|
func TestOperatorSnapshotSave_Fails(t *testing.T) {
|
|
ci.Parallel(t)
|
|
|
|
ui := cli.NewMockUi()
|
|
cmd := &OperatorSnapshotSaveCommand{Meta: Meta{Ui: ui}}
|
|
|
|
// Fails on misuse
|
|
code := cmd.Run([]string{"some", "bad", "args"})
|
|
require.Equal(t, 1, code)
|
|
require.Contains(t, ui.ErrorWriter.String(), commandErrorText(cmd))
|
|
ui.ErrorWriter.Reset()
|
|
|
|
// Fails when specified file does not exist
|
|
code = cmd.Run([]string{"/unicorns/leprechauns"})
|
|
require.Equal(t, 1, code)
|
|
require.Contains(t, ui.ErrorWriter.String(), "no such file")
|
|
}
|