From 34d9f4d1d52827a610e52d67b59af0971bb9b729 Mon Sep 17 00:00:00 2001 From: Umputun Date: Mon, 27 Feb 2023 00:00:04 -0600 Subject: [PATCH] lint: minor warn on deferred close --- app/discovery/provider/consulcatalog/client.go | 4 ++-- app/discovery/provider/docker.go | 2 +- lib/plugin.go | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/app/discovery/provider/consulcatalog/client.go b/app/discovery/provider/consulcatalog/client.go index 410d754..6f2ff35 100644 --- a/app/discovery/provider/consulcatalog/client.go +++ b/app/discovery/provider/consulcatalog/client.go @@ -66,7 +66,7 @@ func (cl *consulClient) getServiceNames() ([]string, error) { if err != nil { return nil, fmt.Errorf("error send request to consul, %w", err) } - defer resp.Body.Close() + defer resp.Body.Close() // nolint if resp.StatusCode != http.StatusOK { return nil, fmt.Errorf("unexpected response status code %d", resp.StatusCode) @@ -107,7 +107,7 @@ func (cl *consulClient) getServices(serviceName string) ([]consulService, error) if err != nil { return nil, fmt.Errorf("error send request to consul, %w", err) } - defer resp.Body.Close() + defer resp.Body.Close() // nolint if resp.StatusCode != http.StatusOK { return nil, fmt.Errorf("unexpected response status code %d", resp.StatusCode) diff --git a/app/discovery/provider/docker.go b/app/discovery/provider/docker.go index d0fa7dc..d7354b9 100644 --- a/app/discovery/provider/docker.go +++ b/app/discovery/provider/docker.go @@ -372,7 +372,7 @@ func (d *dockerClient) ListContainers() ([]containerInfo, error) { return nil, fmt.Errorf("failed connection to docker socket: %w", err) } - defer resp.Body.Close() + defer resp.Body.Close() // nolint if resp.StatusCode != http.StatusOK { e := struct { diff --git a/lib/plugin.go b/lib/plugin.go index 84d5963..5b4441a 100644 --- a/lib/plugin.go +++ b/lib/plugin.go @@ -103,7 +103,7 @@ func (p *Plugin) send(client *http.Client, conductor, method string) error { if err != nil { return err } - defer resp.Body.Close() + defer resp.Body.Close() // nolint if resp.StatusCode != http.StatusOK { return fmt.Errorf("invalid status %s", resp.Status)