kemko/liquid
1
0
Fork 0
mirror of https://github.com/kemko/liquid.git synced 2026-01-01 15:55:40 +03:00
Code Issues Actions Packages Projects Releases Wiki Activity

Avoid allocating arrays of key value pairs for hashes in assign_score_of

Browse Source
This commit is contained in:
Dylan Thacker-Smith
2020-10-21 10:09:02 -04:00
parent b872eac2b9
commit 001fde7694
2 changed files with 10 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
lib/liquid/tags/assign.rb
View File

@@ -45,11 +45,18 @@ module Liquid
def assign_score_of(val)
if val.instance_of?(String)
val.bytesize
elsif val.instance_of?(Array) || val.instance_of?(Hash)
elsif val.instance_of?(Array)
sum = 1
# Uses #each to avoid extra allocations.
val.each { |child| sum += assign_score_of(child) }
sum
elsif val.instance_of?(Hash)
sum = 1
val.each do |key, entry_value|
sum += assign_score_of(key)
sum += assign_score_of(entry_value)
end
sum
else
1
end

4
test/integration/assign_test.rb
View File

@@ -88,8 +88,8 @@ class AssignTest < Minitest::Test
def test_assign_score_of_hash
assert_equal(1, assign_score_of({}))
assert_equal(6, assign_score_of('int' => 123))
assert_equal(14, assign_score_of('int' => 123, 'str' => 'abcd'))
assert_equal(5, assign_score_of('int' => 123))
assert_equal(12, assign_score_of('int' => 123, 'str' => 'abcd'))
end
private