mirror of
https://github.com/kemko/liquid.git
synced 2026-01-01 15:55:40 +03:00
Merge pull request #734 from Shopify/concat-liquid-error
Raise a Liquid::Error when a non-array is passed into the concat filter.
This commit is contained in:
@@ -216,6 +216,9 @@ module Liquid
|
||||
end
|
||||
|
||||
def concat(input, array)
|
||||
unless array.respond_to?(:to_ary)
|
||||
raise ArgumentError.new("concat filter requires an array argument")
|
||||
end
|
||||
InputIterator.new(input).concat(array)
|
||||
end
|
||||
|
||||
@@ -370,7 +373,7 @@ module Liquid
|
||||
end
|
||||
|
||||
def concat(args)
|
||||
to_a.concat args
|
||||
to_a.concat(args)
|
||||
end
|
||||
|
||||
def reverse
|
||||
|
||||
@@ -463,8 +463,7 @@ class StandardFiltersTest < Minitest::Test
|
||||
assert_equal [1, 2, 'a'], @filters.concat([1, 2], ['a'])
|
||||
assert_equal [1, 2, 10], @filters.concat([1, 2], [10])
|
||||
|
||||
assert_raises(TypeError) do
|
||||
# no implicit conversion of Fixnum into Array
|
||||
assert_raises(Liquid::ArgumentError, "concat filter requires an array argument") do
|
||||
@filters.concat([1, 2], 10)
|
||||
end
|
||||
end
|
||||
|
||||
Reference in New Issue
Block a user