Use same approach in scope and environment

This commit is contained in:
Mike Angell
2019-08-28 23:35:14 +10:00
parent 56c667d8f9
commit 6fd5e4e6ce
2 changed files with 4 additions and 7 deletions

View File

@@ -143,10 +143,10 @@ module Liquid
def find_variable(key, raise_on_not_found: true)
# This was changed from find() to find_index() because this is a very hot
# path and find_index() is optimized in MRI to reduce object allocation
index = @scopes.find_index { |s| s.key?(key) }
scope = @scopes[index] if index
scope ||= @environments.find { |e| !e[key].nil? || @strict_variables && raise_on_not_found } || {}
scope = (index = @scopes.find_index { |s| s.key?(key) }) && @scopes[index]
scope ||= (index = @environments.find_index { |s| s.key?(key) }) && @environments[index]
scope ||= {}
variable = lookup_and_evaluate(scope, key, raise_on_not_found: raise_on_not_found).to_liquid
variable.context = self if variable.respond_to?(:context=)

View File

@@ -80,10 +80,7 @@ class VariableTest < Minitest::Test
assigns['test'] = 'Tobi'
assert_equal 'Hello Tobi', template.render!(assigns)
assigns.delete('test')
e = assert_raises(RuntimeError) do
template.render!(assigns)
end
assert_equal "Unknown variable 'test'", e.message
assert_equal "Hello ", template.render!(assigns)
end
def test_multiline_variable