Convert array to string interpolation, use 'unless' rather than 'if x !='

Only output media attribute if needed, delete redundant type attribute in stylesheet_tag
Delete redudant type attribute in script_tag
2026-01-01 15:55:40 +03:00 · 2021-05-14 10:19:15 -07:00 · 2021-05-14 08:02:57 -07:00 · 2021-05-14 08:02:57 -07:00
1 changed files with 2 additions and 2 deletions
--- a/performance/shopify/shop_filter.rb
+++ b/performance/shopify/shop_filter.rb
@@ -14,11 +14,11 @@ module ShopFilter
  end

  def script_tag(url)
-    %(<script src="#{url}" type="text/javascript"></script>)
+    %(<script src="#{url}"></script>)
  end

  def stylesheet_tag(url, media = "all")
-    %(<link href="#{url}" rel="stylesheet" type="text/css"  media="#{media}"  />)
+    %(<link href="#{url}" rel="stylesheet" #{%(media="#{media}" ) unless media == 'all'}/>)
  end

  def link_to(link, url, title = "")
Author	SHA1	Message	Date
Kaelig	be02670a54	Convert array to string interpolation, use 'unless' rather than 'if x !='	2021-05-14 10:19:15 -07:00
Kaelig	b1cdd31858	Only output media attribute if needed, delete redundant type attribute in stylesheet_tag	2021-05-14 08:02:57 -07:00
Kaelig	8ece160330	Delete redudant type attribute in script_tag	2021-05-14 08:02:57 -07:00