kemko/nomad
1
0
Fork 0
mirror of https://github.com/kemko/nomad.git synced 2026-01-06 10:25:42 +03:00
Code Issues Packages Projects Releases Wiki Activity

Change job search navigation to use id (#8560)

Browse Source 
This fixes #8548. It was a significant oversight to use the
name instead of the id!
This commit is contained in:
Buck Doyle
2020-07-30 09:10:08 -05:00
committed by GitHub
parent a63c4fb39d
commit 11fb89d8d7
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
ui/app/components/global-search/control.js
View File

@@ -92,7 +92,7 @@ export default class GlobalSearchControl extends Component {
const itemModelName = model.constructor.modelName;
if (itemModelName === 'job') {
this.router.transitionTo('jobs.job', model.name, {
this.router.transitionTo('jobs.job', model.plainId, {
queryParams: { namespace: model.get('namespace.name') },
});
} else if (itemModelName === 'node') {

4
ui/tests/acceptance/search-test.js
View File

@@ -22,7 +22,7 @@ module('Acceptance | search', function(hooks) {
const otherNode = server.create('node', { name: 'aaa' });
server.create('job', { id: 'vwxyz', namespaceId: 'default' });
server.create('job', { id: 'xyz', namespace: 'default' });
server.create('job', { id: 'xyz', name: 'xyz job', namespace: 'default' });
server.create('job', { id: 'abc', namespace: 'default' });
await visit('/');
@@ -43,7 +43,7 @@ module('Acceptance | search', function(hooks) {
search.groups[0].as(jobs => {
assert.equal(jobs.name, 'Jobs (2)');
assert.equal(jobs.options.length, 2);
assert.equal(jobs.options[0].text, 'xyz');
assert.equal(jobs.options[0].text, 'xyz job');
assert.equal(jobs.options[1].text, 'vwxyz');
});