mirror of
https://github.com/kemko/nomad.git
synced 2026-01-06 10:25:42 +03:00
csi: fix incorrect comment on csi_hook context lifetime
This commit is contained in:
@@ -34,12 +34,10 @@ func (c *csiHook) Prerun() error {
|
||||
return nil
|
||||
}
|
||||
|
||||
// TODO(tgross): the contexts for the CSI RPC calls made during
|
||||
// mounting can have very long timeouts. Until these are better
|
||||
// tuned, there's not a good value to put here for a WithCancel
|
||||
// without risking conflicts with the grpc retries/timeouts in the
|
||||
// pluginmanager package.
|
||||
ctx := context.TODO()
|
||||
// We use this context only to attach hclog to the gRPC context. The
|
||||
// lifetime is the lifetime of the gRPC stream, not specific RPC timeouts,
|
||||
// but we manage the stream lifetime via Close in the pluginmanager.
|
||||
ctx := context.Background()
|
||||
|
||||
volumes, err := c.claimVolumesFromAlloc()
|
||||
if err != nil {
|
||||
|
||||
Reference in New Issue
Block a user