kemko/nomad
1
0
Fork 0
mirror of https://github.com/kemko/nomad.git synced 2026-01-01 16:05:42 +03:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #12304 from th0m/tlefebvre/fix-wrong-drivernetworkmanager-interface

Browse Source 
fix: update incorrect DriverNetworkManager interface implementation
This commit is contained in:
James Rasell
2022-04-04 11:29:22 +02:00
committed by GitHub
parent 7c589fd773 80b4eeaba5
commit 245dd801dd
2 changed files with 7 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/mock/driver.go
View File

@@ -670,8 +670,10 @@ func (d *Driver) GetHandle(taskID string) *taskHandle {
return h
}
func (d *Driver) CreateNetwork(allocID string) (*drivers.NetworkIsolationSpec, error) {
return nil, nil
var _ drivers.DriverNetworkManager = (*Driver)(nil)
func (d *Driver) CreateNetwork(allocID string, request *drivers.NetworkCreateRequest) (*drivers.NetworkIsolationSpec, bool, error) {
return nil, true, nil
}
func (d *Driver) DestroyNetwork(allocID string, spec *drivers.NetworkIsolationSpec) error {

4
plugins/drivers/client.go
View File

@@ -468,7 +468,9 @@ func (d *driverPluginClient) ExecTaskStreamingRaw(ctx context.Context,
}
}
func (d *driverPluginClient) CreateNetwork(allocID string) (*NetworkIsolationSpec, bool, error) {
var _ DriverNetworkManager = (*driverPluginClient)(nil)
func (d *driverPluginClient) CreateNetwork(allocID string, _ *NetworkCreateRequest) (*NetworkIsolationSpec, bool, error) {
req := &proto.CreateNetworkRequest{
AllocId: allocID,
}