mirror of
https://github.com/kemko/nomad.git
synced 2026-01-06 18:35:44 +03:00
Fix exec escaping for emoji task name (#7813)
This closes #7459. While emoji don’t actually need escaping, expanding the expression that enumerates all task name characters that don’t need escaping to include emoji is prohibitive, since it’s a discontinuous range. The emoji-regex project has such an expression and it’s 12kB. This fixes the regular expression to property escape emoji as a single character instead of as its component bytes. Thanks to @DingoEatingFuzz for the suggestion.
This commit is contained in:
@@ -1,4 +1,4 @@
|
||||
export default function escapeTaskName(taskName) {
|
||||
// Regular expression is taken from here: https://stackoverflow.com/a/20053121
|
||||
return taskName.replace(/[^a-zA-Z0-9,._+@%/-]/g, '\\$&');
|
||||
return taskName.replace(/[^a-zA-Z0-9,._+@%/-]/gu, '\\$&');
|
||||
}
|
||||
|
||||
@@ -6,5 +6,6 @@ module('Unit | Utility | escape-task-name', function() {
|
||||
assert.equal(escapeTaskName('plain'), 'plain');
|
||||
assert.equal(escapeTaskName('a space'), 'a\\ space');
|
||||
assert.equal(escapeTaskName('dollar $ign'), 'dollar\\ \\$ign');
|
||||
assert.equal(escapeTaskName('emoji🥳'), 'emoji\\🥳');
|
||||
});
|
||||
});
|
||||
|
||||
Reference in New Issue
Block a user