Add a field to track the next allocation during a replacement

This commit is contained in:
Preetha Appan
2018-01-24 14:56:57 -06:00
parent 76d78d768f
commit 64e9cf9733
4 changed files with 20 additions and 1 deletions

View File

@@ -91,6 +91,7 @@ type Allocation struct {
DeploymentID string
DeploymentStatus *AllocDeploymentStatus
PreviousAllocation string
NextAllocation string
CreateIndex uint64
ModifyIndex uint64
AllocModifyIndex uint64

View File

@@ -1889,6 +1889,21 @@ func (s *StateStore) upsertAllocsImpl(index uint64, allocs []*structs.Allocation
return fmt.Errorf("alloc insert failed: %v", err)
}
if alloc.PreviousAllocation != "" {
prevAlloc, err := txn.First("allocs", "id", alloc.PreviousAllocation)
if err != nil {
return fmt.Errorf("alloc lookup failed: %v", err)
}
existingPrevAlloc, _ := prevAlloc.(*structs.Allocation)
if existingPrevAlloc != nil {
prevAllocCopy := existingPrevAlloc.Copy()
prevAllocCopy.NextAllocation = alloc.ID
if err := txn.Insert("allocs", prevAllocCopy); err != nil {
return fmt.Errorf("alloc insert failed: %v", err)
}
}
}
// If the allocation is running, force the job to running status.
forceStatus := ""
if !alloc.TerminalStatus() {

View File

@@ -4910,6 +4910,9 @@ type Allocation struct {
// PreviousAllocation is the allocation that this allocation is replacing
PreviousAllocation string
// NextAllocation is the allocation that this allocation is being replaced by
NextAllocation string
// DeploymentID identifies an allocation as being created from a
// particular deployment
DeploymentID string

View File

@@ -3443,7 +3443,7 @@ func TestGenericSched_ChainedAlloc(t *testing.T) {
}
sort.Strings(prevAllocs)
// Ensure that the new allocations has their corresponging original
// Ensure that the new allocations has their corresponding original
// allocation ids
if !reflect.DeepEqual(prevAllocs, allocIDs) {
t.Fatalf("expected: %v, actual: %v", len(allocIDs), len(prevAllocs))