kemko/nomad
1
0
Fork 0
mirror of https://github.com/kemko/nomad.git synced 2026-01-06 02:15:43 +03:00
Code Issues Packages Projects Releases Wiki Activity

Update the reason why the router service is still not used

Browse Source
This commit is contained in:
Michael Lange
2017-12-13 11:03:11 -08:00
parent c5c2c2bd14
commit 8100dc94e4
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
ui/app/components/server-agent-row.js
View File

@@ -4,7 +4,8 @@ import { lazyClick } from '../helpers/lazy-click';
const { Component, inject, computed } = Ember;
export default Component.extend({
// TODO Switch back to the router service style when it is no longer feature-flagged
// TODO Switch back to the router service once the service behaves more like Route
// https://github.com/emberjs/ember.js/issues/15801
// router: inject.service('router'),
_router: inject.service('-routing'),
router: computed.alias('_router.router'),
@@ -15,7 +16,8 @@ export default Component.extend({
agent: null,
isActive: computed('agent', 'router.currentURL', function() {
// TODO Switch back to the router service style when it is no longer feature-flagged
// TODO Switch back to the router service once the service behaves more like Route
// https://github.com/emberjs/ember.js/issues/15801
// const targetURL = this.get('router').urlFor('servers.server', this.get('agent'));
// const currentURL = `${this.get('router.rootURL').slice(0, -1)}${this.get('router.currentURL')}`;