kemko/nomad
1
0
Fork 0
mirror of https://github.com/kemko/nomad.git synced 2026-01-06 18:35:44 +03:00
Code Issues Packages Projects Releases Wiki Activity

testing: fix configuration for retry tests (#18731)

Browse Source 
The retry tests in the `api` package set up a client but don't use `NewClient`,
so the address never gets parsed into a `url.URL` and that's causing some test
failures.
This commit is contained in:
Tim Gross
2023-10-11 14:06:31 -04:00
committed by GitHub
parent 7266d267b0
commit b39632fa6f
1 changed files with 23 additions and 31 deletions
Download Patch File Download Diff File Expand all files Collapse all files

54
api/retry_test.go
View File

@@ -43,18 +43,15 @@ func Test_RetryPut_multiple_calls(t *testing.T) {
}
server := httptest.NewServer(http.HandlerFunc(mh.Handle))
cm := &Client{
httpClient: server.Client(),
config: Config{
Address: server.URL,
retryOptions: &retryOptions{
delayBase: 10 * time.Millisecond,
maxRetries: 10,
maxBackoffDelay: 100 * time.Millisecond,
},
cm, err := NewClient(&Config{
Address: server.URL,
retryOptions: &retryOptions{
delayBase: 10 * time.Millisecond,
maxRetries: 10,
maxBackoffDelay: 100 * time.Millisecond,
},
}
})
must.NoError(t, err)
md, err := cm.retryPut(context.TODO(), "/endpoint", nil, nil, &WriteOptions{})
must.NoError(t, err)
@@ -78,17 +75,14 @@ func Test_RetryPut_one_call(t *testing.T) {
}
server := httptest.NewServer(http.HandlerFunc(mh.Handle))
cm := &Client{
httpClient: server.Client(),
config: Config{
Address: server.URL,
retryOptions: &retryOptions{
delayBase: 10 * time.Millisecond,
maxRetries: 1,
},
cm, err := NewClient(&Config{
Address: server.URL,
retryOptions: &retryOptions{
delayBase: 10 * time.Millisecond,
maxRetries: 1,
},
}
})
must.NoError(t, err)
md, err := cm.retryPut(context.TODO(), "/endpoint/", nil, nil, &WriteOptions{})
must.Error(t, err)
@@ -105,17 +99,15 @@ func Test_RetryPut_capped_base_too_big(t *testing.T) {
}
server := httptest.NewServer(http.HandlerFunc(mh.Handle))
cm := &Client{
httpClient: server.Client(),
config: Config{
Address: server.URL,
retryOptions: &retryOptions{
delayBase: math.MaxInt64 * time.Nanosecond,
maxRetries: 3,
maxBackoffDelay: 200 * time.Millisecond,
},
cm, err := NewClient(&Config{
Address: server.URL,
retryOptions: &retryOptions{
delayBase: math.MaxInt64 * time.Nanosecond,
maxRetries: 3,
maxBackoffDelay: 200 * time.Millisecond,
},
}
})
must.NoError(t, err)
md, err := cm.retryPut(context.TODO(), "/endpoint", nil, nil, &WriteOptions{})
must.Error(t, err)