go vet

client/driver/logrotator/logs.go

@@ -136,7 +136,6 @@ func (l *LogRotator) Start(r io.Reader) error {
 			}
 		}
 	}
-	return nil
 }
 
 // PurgeOldFiles removes older files and keeps only the last N files rotated for

client/task_runner.go

@@ -320,8 +320,6 @@ func (r *TaskRunner) run() {
 		// Set force start because we are restarting the task.
 		forceStart = true
 	}
-
-	return
 }
 
 // handleUpdate takes an updated allocation and updates internal state to

nomad/blocked_evals.go

@@ -259,8 +259,6 @@ SCAN:
 	case <-b.duplicateCh:
 		goto SCAN
 	}
-
-	return nil
 }
 
 // Flush is used to clear the state of blocked evaluations.

scheduler/generic_sched_test.go

@@ -580,7 +580,7 @@ func TestServiceSched_JobModify_InPlace(t *testing.T) {
 	h.AssertEvalStatus(t, structs.EvalStatusComplete)
 
 	// Verify the network did not change
-	rp := structs.Port{"main", 5000}
+	rp := structs.Port{Label: "main", Value: 5000}
 	for _, alloc := range out {
 		for _, resources := range alloc.TaskResources {
 			if resources.Networks[0].ReservedPorts[0] != rp {

scheduler/system_sched_test.go

@@ -468,7 +468,7 @@ func TestSystemSched_JobModify_InPlace(t *testing.T) {
 	h.AssertEvalStatus(t, structs.EvalStatusComplete)
 
 	// Verify the network did not change
-	rp := structs.Port{"main", 5000}
+	rp := structs.Port{Label: "main", Value: 5000}
 	for _, alloc := range out {
 		for _, resources := range alloc.TaskResources {
 			if resources.Networks[0].ReservedPorts[0] != rp {