Charlie Voiselle
1cb52865bc
Canonicalize task and remove merge with MinResources
...
The current code would merge the job with the output of MinResources causing the nil to be replaced with MemoryMB=helper.IntToPtr(10). When later `Canonicalize`d, the 10 would cause the default of 300 not to be applied. Running `Canonicalize` on the task itself guarantees that CPU, MemoryMB, and IOPS is set, so we can remove the Merge withMinResources.
2017-11-09 10:10:11 -05:00
Charlie Voiselle
7c98e466fc
Rolled back documentation change in favor of correcting the default
2017-11-07 17:17:49 -05:00
Charlie Voiselle
264d999b8b
memory default is 10, not 300
...
Verified by creating sample job and removing memory from resources
```
Task "redis" is "running"
Task Resources
CPU Memory Disk IOPS Addresses
3/100 MHz 976 KiB/10 MiB 300 MiB 0 db: **.**.**.**:20824
```
2017-11-07 15:33:32 -05:00
Michael Schurter
fad4a33649
Merge pull request #3515 from jrasell/patch-1
...
Update securing-nomad.html.md address flag example
2017-11-07 11:03:40 -08:00
James Rasell
3b1fa0a77f
Update securing-nomad.html.md address flag example
...
The `nomad node-status` command incorrectly used the `-addr` flag; whereas the correct flag key is `-address`.
2017-11-07 09:05:06 +00:00
Alex Dadgar
088d832c87
Merge pull request #3505 from multani/fix-typos-guides
...
doc: fix some typos in the "Guides" documentation
2017-11-06 15:58:40 -08:00
Alex Dadgar
d9d8918c39
changelog
2017-11-06 15:48:05 -08:00
Alex Dadgar
0592629547
Merge pull request #3504 from james-powis/fix_consul_address
...
[3503] adding consul-address flag to command.go
2017-11-06 15:46:01 -08:00
Michael Schurter
7ce14b025a
Add #3509 to changelog
2017-11-06 11:26:04 -08:00
Michael Schurter
ed142eb942
Merge pull request #3509 from jrasell/gh_3508
...
Fix panic on every run of the keyring command.
2017-11-06 09:39:11 -08:00
James Rasell
9f595ae797
Fix panic on every run of the keyring command.
...
This change removes the flag token declaration within keyring.go
which caused a flag redefined panic on every command run as the
token flag is specified in the command meta.
2017-11-06 10:15:42 +00:00
Jonathan Ballet
9b48a2da72
doc: fix some typos in the "Guides" documentation
2017-11-05 09:39:42 +01:00
James Powis
6d3cc25097
[3503] adding consul-address flag to command.go
2017-11-04 18:05:20 -06:00
Preetha Appan
0b3476aabd
Update deployments API documentation to add clarifying sentence about rollbacks triggering only when job spec is different.
2017-11-04 09:28:27 -05:00
Alex Dadgar
cf5cdfd634
changelog and website
2017-11-03 16:43:16 -07:00
Alex Dadgar
80b434d467
Merge pull request #3411 from cheeseprocedure/f-qemu-graceful-shutdown
...
Qemu driver: graceful shutdown feature
2017-11-03 16:41:34 -07:00
Alex Dadgar
a72fa701a5
changelog
2017-11-03 16:33:23 -07:00
Michael Schurter
6ab0e8f2c8
Merge pull request #3501 from hashicorp/b-build-log-fixes
...
Fix git commit build flag and remove unneeded log line
2017-11-03 16:11:26 -07:00
Michael Schurter
f84bd23e7a
Fix git commit build flag
2017-11-03 16:01:01 -07:00
Michael Schurter
e93d625d44
Remove noisy log line
...
Didn't mean to commit this
2017-11-03 16:00:30 -07:00
Matt Mercer
f734d842f5
Qemu driver: clean up logging; fail unsupported features on Windows
2017-11-03 15:40:20 -07:00
Preetha
651c06bec6
Update CHANGELOG.md
2017-11-03 17:34:09 -05:00
Preetha
df0e6acfe1
Merge pull request #3496 from hashicorp/b-auto-revert-stable
...
Makes auto reverts robust against infinite revert cycles
2017-11-03 17:28:28 -05:00
Preetha Appan
04feeef1cc
Adds comment to handleRollbackValidity method and other small test readability fixes.
2017-11-03 17:05:15 -05:00
Alex Dadgar
a94bab6491
fix spelling mistake
2017-11-03 15:04:59 -07:00
Preetha Appan
f92e564e76
Added more unit tests for testing rollback when job has identical spec to AllocHealth and DeploymentStatus endpoints.
2017-11-03 16:07:06 -05:00
Preetha Appan
05af7bd711
Check that job version doesn't change when rollback does not occur due to identical spec
2017-11-03 15:46:37 -05:00
Alex Dadgar
57133fe380
changelog
2017-11-03 13:45:15 -07:00
Alex Dadgar
eca9e09f37
Merge pull request #3402 from hashicorp/leader-loop
...
Applies leader loop fixes from Consul.
2017-11-03 13:40:59 -07:00
Preetha Appan
145a959f75
Adds SpecChanged check to alloc health and fail deployment end points, and other code review comments.
2017-11-03 15:33:34 -05:00
Alex Dadgar
8a3fc18bff
changelog
2017-11-03 13:24:45 -07:00
Alex Dadgar
11184c7514
Merge pull request #3459 from multani/docker-oom-notification
...
docker: log that a container has been killed by the OOM killer
2017-11-03 13:24:03 -07:00
Preetha Appan
ba6c808f59
Clarify comment about infinite revert cycles
2017-11-03 14:25:14 -05:00
Matt Mercer
66f9840dd0
Qemu driver: tweaks in response to PR feedback
...
Remove attribute for long qemu monitor path; misc cleanup; update tests
2017-11-03 11:28:56 -07:00
Preetha Appan
927b10edc1
Update CHANGELOG.md
2017-11-03 13:07:40 -05:00
Preetha
657747e5fa
Merge pull request #3486 from hashicorp/f-event-messages-api
...
Move event messages logic into task_runner
2017-11-03 13:01:51 -05:00
Preetha Appan
48f90089d5
Fix formatting
2017-11-03 12:48:55 -05:00
Preetha Appan
aa253b07ab
Adds deprecation notice to API struct definition.
2017-11-03 10:12:37 -05:00
Preetha Appan
b3631f3d32
Remove event GenericSource, and address other code review comments. Also added deprecation info in comments.
2017-11-03 10:10:06 -05:00
Preetha Appan
17584d9088
Revert unintentional change to plan_apply.go during rebase
2017-11-03 09:13:01 -05:00
Preetha Appan
6bc2553eb7
Address some code review comments
2017-11-03 09:13:01 -05:00
Preetha Appan
f588b0e0c3
Unit test for PopulateEventDisplayMessage
2017-11-03 09:13:01 -05:00
Preetha Appan
b7764fcd8e
Added explanatory comment
2017-11-03 09:13:01 -05:00
Preetha Appan
d63e693679
Move logic for determinic event display message to task_runner, added two new fields DisplayMessage and Details.
2017-11-03 09:13:01 -05:00
Preetha Appan
a19dd17100
Add ModifyTime to Allocation and update it both on plan applies and client initiated updates
2017-11-03 09:13:01 -05:00
Preetha Appan
48844e0b3c
Remove extra newline
2017-11-03 08:15:11 -05:00
Preetha Appan
99c57eed07
Update rollback test to add a spec change, and add new test for rollback failed status
2017-11-02 19:53:27 -05:00
Preetha Appan
f83c540261
Fixes auto revert to check if the job's spec has changed before reverting. This prevents infinite reverting when reverting to a job version that was previously stable, but not so after attempting a revert.
2017-11-02 19:53:27 -05:00
Alex Dadgar
7600a4e44b
Merge pull request #3495 from hashicorp/t-test
...
Run linter
2017-11-02 17:40:02 -07:00
Alex Dadgar
b6ac0a7fa0
Merge pull request #3494 from hashicorp/b-ar-metrics-restore
...
Alloc Runner doesn't panic on restoration.
2017-11-02 17:39:06 -07:00
