Commit Graph

20191 Commits

Author SHA1 Message Date
Michael Schurter
2dbc47ba5f docs: may->will after confirming with Consul
Consul 1.9 switched to agentless intentions which no longer require
synchronous communication from Envoy to Consul.
2020-12-03 13:48:06 -08:00
Michael Schurter
068d5a2603 docs: clarify connect upgrade procedure
During testing we discovered old versions of Nomad and Consul seemed to
prevent Envoy from accepting new connections while the Nomad agent was
being upgraded.
2020-12-03 13:36:13 -08:00
Seth Hoenig
a0ea33d3a6 Merge pull request #9513 from hashicorp/f-e2e-upgrade-consul-more
e2e: upgrade terraform consul to 1.9.0
2020-12-03 13:09:25 -06:00
Seth Hoenig
f9b5c4e7a9 e2e: upgrade terraform consul to 1.9.0 2020-12-03 13:01:14 -06:00
Drew Bailey
800d56609d ensure node secret ID is not included in event stream (#9510) 2020-12-03 12:27:14 -05:00
Drew Bailey
6318a8ac7b API: Event stream use full name instead of Eval/Alloc (#9509)
* use full name for events

use evaluation and allocation instead of short name

* update api event stream package and shortnames

* update docs

* make sync; fix typo

* backwards compat not from 1.0.0-beta event stream api changes

* use api types instead of string

* rm backwards compat note that only changed between prereleases

* remove backwards incompat that only existed in prereleases
2020-12-03 11:48:18 -05:00
Seth Hoenig
dcfc7091b1 Merge pull request #9508 from hashicorp/docs-docker-windows-issues
docs: fix link to windows docker issues
2020-12-03 09:28:18 -06:00
Seth Hoenig
641c089ef1 docs: fix link to windows docker issues 2020-12-03 09:19:22 -06:00
Charlie Voiselle
e64d528664 Small website updates (#9504)
* systemd should be downcased
* containerd should be downcased
* spellchecking, adjust list item spacing
* QEMU should be upcased
* spelling, it's->its
* Fewer exclamation points; drive-by list spacing
* Update website/pages/docs/internals/security.mdx
* Namespace is not ent only now.
Co-authored-by: Tim Gross <tgross@hashicorp.com>
2020-12-02 19:02:03 -05:00
Chris Baker
ee7c97fe91 Merge pull request #9501 from hashicorp/docs-hcl-note
added some discussion of HCL parsing context
2020-12-02 17:00:24 -06:00
Chris Baker
0e13770397 formatting fix from github-based commit 2020-12-02 22:25:36 +00:00
Chris Baker
e68b66253b Update website/pages/docs/job-specification/hcl2/index.mdx
Co-authored-by: Michael Schurter <mschurter@hashicorp.com>
2020-12-02 16:12:07 -06:00
Tim Gross
dc2bec7f45 docker: kill signal API should include timeout context (#9502)
When the Docker driver kills as task, we send a request via the Docker API for
dockerd to fire the signal. We send that signal and then block for the
`kill_timeout` waiting for the container to exit. But if the Docker API
blocks, we will block indefinitely because we haven't configured the API call
with the same timeout.

This changeset is a minimal intervention to add the timeout to the Docker API
call _only_ when we have the `kill_timeout` set. Future work should examine
whether we should be threading contexts through other `go-dockerclient` API
calls.
2020-12-02 16:53:17 -05:00
Tim Gross
a1bfc0320e docker: kill signal API should include timeout context
When the Docker driver kills as task, we send a request via the Docker API for
dockerd to fire the signal. We send that signal and then block for the
`kill_timeout` waiting for the container to exit. But if the Docker API
blocks, we will block indefinitely because we haven't configured the API call
with the same timeout.

This changeset is a minimal intervention to add the timeout to the Docker API
call _only_ when we have the `kill_timeout` set. Future work should examine
whether we should be threading contexts through other `go-dockerclient` API
calls.
2020-12-02 16:51:57 -05:00
Chris Baker
934f622f95 added some discussion of HCL parsing context 2020-12-02 20:41:53 +00:00
Seth Hoenig
cf6055ef55 Merge pull request #9498 from hashicorp/f-update-e2e-cpu
env_aws: run ec2info to update ec2 info
2020-12-02 09:47:27 -06:00
Seth Hoenig
6c8ea087d6 env_aws: run ec2info to update ec2 info
Use `tools/ec2info` to update the generated table of instance types.
`$ go run .`
2020-12-02 09:35:03 -06:00
Tim Gross
44c2767f4f docs: using interpolation for volumes (#9449)
Expand `volume` and `volume_mount` sections to describe how to use HCL2
dynamic blocks and interpolation to have finer-grained control over how
allocations get volumes.
2020-12-02 08:57:47 -05:00
James Rasell
5fbcf82cee Merge pull request #9494 from hashicorp/e2e-poststop-sigterm
lifecycle: update e2e test for service job with new docker signal #8932
2020-12-02 09:06:14 +01:00
Jasmine Dahilig
64d72ece43 lifecycle: update e2e test for service job with new docker signal #8932 2020-12-01 23:41:32 -08:00
Seth Hoenig
4d6a166989 Merge pull request #9487 from hashicorp/f-connect-sidecar-concurrency
consul/connect: default envoy concurrency to 1
2020-12-01 15:51:41 -06:00
Drew Bailey
db3bfb77b3 Events switch on memdb change table instead of type to prevent duplicates (#9486)
* prevent duplicate job events

when a job is updated, the job_version table is updated with a structs.Job, this caused there to be multiple job events since we are switching off the change type and not the table

* test length

* add table value to tests
2020-12-01 15:14:05 -05:00
Michael Schurter
5ddaa1bb78 Merge pull request #9485 from hashicorp/docs-check-restart
docs: check_restart is broken for group networks
2020-12-01 11:39:45 -08:00
Seth Hoenig
2a397dbda2 consul/connect: default envoy concurrency to 1
Previously, every Envoy Connect sidecar would spawn as many worker
threads as logical CPU cores. That is Envoy's default behavior when
`--concurrency` is not explicitly set. Nomad now sets the concurrency
flag to 1, which is sensible for the default cpu = 250 Mhz resources
allocated for sidecar proxies. The concurrency value can be configured
in Client configuration by setting `meta.connect.proxy_concurrency`.

Closes #9341
2020-12-01 13:12:45 -06:00
Drew Bailey
246855c072 pass in msgType for UpsertJob (#9475) 2020-12-01 14:00:52 -05:00
Dave May
d8070e99b1 nomad operator debug - add pprof duration / csi details (#9346)
* debug: add pprof duration CLI argument
* debug: add CSI plugin details
* update help text with ACL requirements
* debug: provide ACL hints upon permission failures
* debug: only write file when pprof retrieve is successful
* debug: add helper function to clean bad characters from dynamic filenames
* debug: ensure files are unable to escape the capture directory
2020-12-01 12:36:05 -05:00
Tim Gross
2c9850176f docs: move agent lifecycle doc under Operations heading (#9411) 2020-12-01 11:55:08 -05:00
Michael Schurter
16aced1dff docs: check_restart is broken for group networks
Add a warning about check_restart being limited to task networks and
link to the relevant issue: #9176.
2020-12-01 08:52:00 -08:00
Michael Schurter
c60d9a98a5 Merge pull request #9435 from hashicorp/f-allocupdate-timer
client: always wait 200ms before sending updates
2020-12-01 08:45:17 -08:00
Drew Bailey
61ce743228 Event Stream: Track ACL changes, unsubscribe on invalidating changes (#9447)
* upsertaclpolicies

* delete acl policies msgtype

* upsert acl policies msgtype

* delete acl tokens msgtype

* acl bootstrap msgtype

wip unsubscribe on token delete

test that subscriptions are closed after an ACL token has been deleted

Start writing policyupdated test

* update test to use before/after policy

* add SubscribeWithACLCheck to run acl checks on subscribe

* update rpc endpoint to use broker acl check

* Add and use subscriptions.closeSubscriptionFunc

This fixes the issue of not being able to defer unlocking the mutex on
the event broker in the for loop.

handle acl policy updates

* rpc endpoint test for terminating acl change

* add comments

Co-authored-by: Kris Hicks <khicks@hashicorp.com>
2020-12-01 11:11:34 -05:00
Drew Bailey
d9257f73f5 return potential errors from txn.Commit (#9483) 2020-12-01 10:05:37 -05:00
Tim Gross
a340f00ca4 docs: warn about Docker auth_soft_fail behavior
If Docker auth helpers are used but aith fails or the image isn't found, we
hard fail the task. Users may set `auth_soft_fail` to fallback to the public
Docker Hub on a per-job basis. But users that mix public and private images
have to set `auth_soft_fail=true` for every job using a public image if Docker
auth helpers are used.
2020-12-01 09:05:35 -05:00
Mark Lewis
124f128137 Update proxy.mdx 2020-12-01 08:26:32 -05:00
Mark Lewis
5d4eb68658 Update reschedule.mdx 2020-12-01 08:26:12 -05:00
Mark Lewis
d54fa32486 Update restart.mdx 2020-12-01 08:22:13 -05:00
Luiz Aoqui
2461c61e9a Merge pull request #9476 from hashicorp/website-update-general-help
website: update general help guidance
2020-11-30 19:29:52 -05:00
Luiz Aoqui
2c1160db2d website: update general help guidance 2020-11-30 19:12:43 -05:00
Benjamin Buzbee
6a6547b0b6 Fix RPC retry logic in nomad client's rpc.go for blocking queries (#9266) 2020-11-30 15:11:10 -05:00
Drew Bailey
bf225f7179 Remove Managed Sinks from Nomad (#9470)
* Remove Managed Sinks from Nomad

Managed Sinks were a beta feature in Nomad 1.0-beta2. During the beta
period it was determined that this was not a scalable approach to
support community and third party sinks.

* update comment

* changelog
2020-11-30 14:00:31 -05:00
Seth Hoenig
f5806ee0b0 Merge pull request #9472 from hashicorp/f-connect-upstream-datacenter
consul/connect: enable setting datacenter in upstream
2020-11-30 12:29:05 -06:00
Seth Hoenig
8faf997065 docs: better clarify connect upstream datacenter 2020-11-30 12:28:08 -06:00
Michael Schurter
26127c088c docs: add #9435 to changelog 2020-11-30 10:27:13 -08:00
Seth Hoenig
ce32e31195 consul/connect: enable setting datacenter in connect upstream
Before, upstreams could only be defined using the default datacenter.
Now, the `datacenter` field can be set in a connect upstream definition,
informing consul of the desire for an instance of the upstream service
in the specified datacenter. The field is optional and continues to
default to the local datacenter.

Closes #8964
2020-11-30 10:38:30 -06:00
Chris Piwarski
57fe67ce53 command: Fix node help error 2020-11-30 11:12:06 -05:00
Seth Hoenig
cfb9c8c465 docs: note manual jobspec parsing generally no longer required 2020-11-30 09:46:40 -06:00
Mark Lewis
a0f1174a8c Update migrate.mdx 2020-11-30 10:35:25 -05:00
Mahmood Ali
77e5f8c8db docs: add sidebar title for cidrsubnets (#9469) 2020-11-30 10:34:51 -05:00
Seth Hoenig
8f4a3d65b6 Merge pull request #9468 from hashicorp/b-fix-hcl2-doc-typo
docs: spell preceding the normal way
2020-11-30 09:30:56 -06:00
Seth Hoenig
9a7a82e09b docs: spell preceding the normal way 2020-11-30 09:29:24 -06:00
Seth Hoenig
dbb0d2f600 Merge pull request #9454 from hashicorp/f-add-ig-demo-e2e
e2e: add e2e test for consul connect ingress gateway demo
2020-11-30 09:01:42 -06:00