Danielle Tomlinson
3287c3f019
chore: General Cleanup
2019-01-17 18:43:14 +01:00
Michael Schurter
f40d243cbd
Update testutil/vault.go
...
Co-Authored-By: dantoml <dani@tomlinson.io >
2019-01-17 18:43:14 +01:00
Michael Schurter
9e4e2d812d
Update helper/testtask/testtask_windows.go
...
Co-Authored-By: dantoml <dani@tomlinson.io >
2019-01-17 18:43:14 +01:00
Mahmood Ali
fe8c60e157
chore: Stylistic cleanup
...
Co-Authored-By: dantoml <dani@tomlinson.io >
2019-01-17 18:43:14 +01:00
Danielle Tomlinson
06ea0b5377
appveyor: disable tests on windows again
2019-01-17 18:43:14 +01:00
Danielle Tomlinson
db76db4b18
allocwatcher: Stat_t is unavailable on win
2019-01-17 18:43:14 +01:00
Danielle Tomlinson
8966c20155
docker: Only run Cleanup test on unix os'
2019-01-17 18:43:14 +01:00
Danielle Tomlinson
2b3f5f2cb7
chore: goimports exec driver
2019-01-17 18:43:14 +01:00
Danielle Tomlinson
070558e18d
fixup: Typo in docker test
2019-01-17 18:43:14 +01:00
Danielle Tomlinson
0bc1dbef56
chore: Fix docklog linting
2019-01-17 18:43:14 +01:00
Danielle Tomlinson
3f3eb68a27
chore: Fix docker test linting
...
Due to https://github.com/tsenart/deadcode/issues/3 we can't specify
these consts on their own. This moves them into the _platform_test.go
files to avoid creating a package that only exposes a couple of values.
2019-01-17 18:43:14 +01:00
Danielle Tomlinson
8731fe3730
drivers/exec: SIGINT unavailable on windows
2019-01-17 18:43:14 +01:00
Danielle Tomlinson
0ecef70715
rawexec: Fix Exec test on windows
2019-01-17 18:43:14 +01:00
Danielle Tomlinson
ffcd76f03f
rawexec: SIGINT is not available on Windows
2019-01-17 18:43:14 +01:00
Danielle Tomlinson
1e0825388e
docker: Test cleanup for windows
...
* Docker for Windows does not support ulimits
* Use filepath.ToSlash to test workdir
* Convert expected mount paths to system style
* Skip security-opt test on windows
- Windows does not support seccomp, and it's unclear which options are
available.
* Skip StartN due to lack of sigint
* docker: Use api to get image info on windows
* No bridge on windows
* Stop hardcoding /bin/
2019-01-17 18:43:14 +01:00
Danielle Tomlinson
76ee0240ab
docker: ExpandPath tests validate slashpath
2019-01-17 18:43:13 +01:00
Danielle Tomlinson
8a4ffea94a
chore: Cleanup formatting
2019-01-17 18:43:13 +01:00
Danielle Tomlinson
a587be44a7
dockerlogger: Fix tests on windows
...
Uses the home directory and windows path expansion, as c:\tmp doesn't
necessarily exist, and mktemp would involve unnecessarily complicating
the commands.
2019-01-17 18:43:13 +01:00
Danielle Tomlinson
347b4ad247
Expand unix build definition
2019-01-17 18:43:13 +01:00
Danielle Tomlinson
08267885ab
appveyor: GOMAXPROCS: 1
2019-01-17 18:43:13 +01:00
Danielle Tomlinson
041c01d583
client/fs: Skip delete-while-streaming test on win
2019-01-17 18:43:13 +01:00
Danielle Tomlinson
20f40eada8
client/fs: windows error message for not found
2019-01-17 18:43:13 +01:00
Danielle Tomlinson
cf08f85413
api: Validate the slash variant of a given path
...
This validates the slash variant of a RelativeDest, rather than the
platform native version, to support test execution on windows.
2019-01-17 18:43:13 +01:00
Danielle Tomlinson
4014ee30ae
appveyor: Add gopath/bin to PATH
2019-01-17 18:43:13 +01:00
Danielle Tomlinson
4ce7cc1ee4
appveyor: Push test results as an artifact
2019-01-17 18:43:13 +01:00
Danielle Tomlinson
c9edd612ef
appveyor: Fix env access?
2019-01-17 18:43:13 +01:00
Danielle Tomlinson
8547428807
plugins: Load plugins on windows
2019-01-17 18:43:13 +01:00
Danielle Tomlinson
e9a7978367
DROP: disable consul tests on windows
2019-01-17 18:43:13 +01:00
Danielle Tomlinson
d81e632157
testutil: Start vault in the same routine as waiting
...
This is a workaround for the windows process model.
Go os/exec does not pass the parent process handle to the child
processes STARTUPINFO struct, this means that unless we wait in
the _same_ execution context as Starting the process, the
handle will be lost, and we cannot kill it without regaining
a handle.
A better long term solution would be a higher level process
abstraction that uses windows.CreateProcess on windows.
2019-01-17 18:43:13 +01:00
Danielle Tomlinson
dcce2d7247
vaultclient: use require for error assertions
2019-01-17 18:43:13 +01:00
Danielle Tomlinson
d33809b886
fingerprint: Limit vault shutdown waiting
...
When vault is installed through chocolatey, it also installs a shim that
will not pass kill signals to the child. This means the process will
never actually terminate, and we lose the process handle.
Here, rather than waiting forever, we timeout fast.
2019-01-17 18:43:13 +01:00
Danielle Tomlinson
3078c24f79
vaultclient: Update tests for vault 1.0
2019-01-17 18:43:13 +01:00
Danielle Tomlinson
b05d362eb1
fingerprinter: Use HCLogger for windows
2019-01-17 18:43:13 +01:00
Danielle Tomlinson
a51aeb224f
testtask: Build on windows
2019-01-17 18:43:13 +01:00
Danielle Tomlinson
eab62662de
chore: Setup appveyor for windows test execution
2019-01-17 18:43:13 +01:00
Mahmood Ali
4ff1e16706
Merge pull request #5202 from hashicorp/b-no-gpl-gopsutil
...
Update shirou/gopsutil dep to use non-GPL code
2019-01-17 11:40:04 -05:00
Mahmood Ali
d6c3626d16
Update shirou/gopsutil dep to use non-GPL code
...
Previously used `github.com/shirou/gopsutil`[1], used some GPL code [2].
This was somewhat unintentional, and was addressed later [3].
Due to being late in the cycle of Nomad release when this is noticed,
and time elapsed since we updated the dependency, we want to be
conservative in our package updates.
As such, we opted to go with forking the repo to use the previously used
version with the GPL removal code commit, done in [4].
[1] 5776ff9c7c
[2] 5776ff9c7c/host/include/smc.c
[3] c95755e4bc
[4] 62d5761ddb
2019-01-17 11:08:30 -05:00
Mahmood Ali
3c9de20820
fix imports
2019-01-16 19:53:48 -05:00
Michael Schurter
10068422e0
Merge pull request #5197 from hashicorp/b-rkt-cpu
...
rkt: revert to pre-0.9 --cpu flag
2019-01-16 15:05:21 -08:00
Preetha
dab186a4a2
Merge pull request #5182 from hashicorp/b-docker-fingerprint-log-once
...
Make driver logging less redundant
2019-01-16 11:35:33 -06:00
Preetha Appan
3e16b52361
clean up read access
2019-01-16 11:04:11 -06:00
Danielle Tomlinson
435a8bae96
Merge pull request #5193 from hashicorp/dani/logmon-reattach
...
logmon: Reattach to existing loggers
2019-01-16 17:34:13 +01:00
Preetha Appan
80c00fc268
Refactor logging in drivers to use a tri-state boolean
...
Changes logging warnings/errors only if the state changes
from healthy to unhealthy
2019-01-16 10:19:31 -06:00
Preetha Appan
35ab26658c
Make docker driver logging less redundant
2019-01-16 10:16:57 -06:00
Michael Schurter
4dc1ce02cd
Merge pull request #5199 from hashicorp/test-dispatch
...
test: porting TestTaskRunner_SimpleRun_Dispatch
2019-01-16 06:33:51 -08:00
Danielle Tomlinson
828d5f5a53
logmon: Reattach to existing loggers
...
This commit prevents us from creating duplicate logmon hooks when
restoring allocations by persisting the logmon reattach config using
HookData.
2019-01-16 14:56:10 +01:00
Michael Schurter
152ba08207
test: porting TestTaskRunner_SimpleRun_Dispatch
...
Porting test from 0.8 to 0.9.
2019-01-15 15:22:13 -08:00
Alex Dadgar
8e9fefcb94
Merge pull request #5046 from oleksii-shyman/docker_runtimes
...
Nvidia runtime
2019-01-15 14:34:14 -08:00
Michael Schurter
97be19b176
rkt: revert to pre-0.9 --cpu flag
...
See
https://github.com/hashicorp/nomad/issues/3394#issuecomment-453296121
for details. During 0.9 development we switched to shares, but we'd
prefer to maintain backward compat.
2019-01-15 13:15:28 -08:00
Chris Baker
bb57f00f2c
Merge pull request #5194 from hashicorp/f-minor-update-docs-tense
...
docs: updated tense around fixed bug
2019-01-15 14:50:57 -05:00