kemko/nomad
1
0
Fork 0
mirror of https://github.com/kemko/nomad.git synced 2026-01-07 19:05:42 +03:00
Code Issues Packages Projects Releases Wiki Activity
21,817 Commits 1 Branch 0 Tags
6aa8913392949d1feed052afd5ec44a7ee327aaa
Commit Graph

21817 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Mahmood Ali
6aa8913392 logmon: Fix a memory leak on task restart 
Fix a logmon leak causing high goroutine and memory usage when a task
restarts.

Logmon `FileRotator` buffers the task stdout/stderr streams and
periodically flushing them to log files. Logmon creates a new
FileRotator for each stream for each task run. However, the
`flushPeriodically` goroutine is leaked when a task restarts,
holding a reference to a no-longer-needed `FileRotator` instance
along with its 64kb buffer.

The cause is that the code assumed `time.Ticker.Stop()` closes the
ticker channel, thereby terminating the goroutine, but the documentation
says otherwise:

> Stop turns off a ticker. After Stop, no more ticks will be sent. Stop does not close the channel, to prevent a concurrent goroutine reading from the channel from seeing an erroneous "tick".
https://pkg.go.dev/time#Ticker.Stop
 2021-10-05 12:11:53 -04:00
Mahmood Ali
60a66a14b1 logmon: add a test for leaked goroutines 2021-10-05 12:11:42 -04:00
Mahmood Ali
39b72a2501 logmon: refactor Logging tests 
Mostly to use testify assertions and close open resources
 2021-10-05 12:10:58 -04:00
Mahmood Ali
88ff7f40de Merge pull request #11089 from hashicorp/b-cve-2021-37218 
Apply authZ for nomad Raft RPC layer
 2021-10-05 08:49:21 -04:00
Luiz Aoqui
6cd62b3ef0 fix panic when Connect mesh gateway doesn't have a proxy block (#11257) 
Co-authored-by: Michael Schurter <mschurter@hashicorp.com>
 2021-10-04 15:52:07 -04:00
Michael Schurter
b40a21597b Merge pull request #11235 from hashicorp/test-evalbroker 
test: fix fake by increasing time window
 2021-10-04 11:16:41 -07:00
Mahmood Ali
4b81337a88 Merge pull request #11251 from hashicorp/f-golang-1.17.1 
Upgrade Golang to 1.17.1
 2021-10-04 13:52:00 -04:00
Mahmood Ali
0d34b22880 update docs and changelog 2021-10-04 13:50:42 -04:00
James Rasell
efa9d4b43a Merge pull request #11249 from hashicorp/f-gh-11237 
deps: update hashicorp/go-discover.
 2021-10-04 09:32:42 +02:00
Luiz Aoqui
f639f71874 docs: document that network mode is only supported on Linux (#11192) 
Co-authored-by: Michael Schurter <mschurter@hashicorp.com>
Co-authored-by: Michael Schurter <mschurter@hashicorp.com>
 2021-10-01 23:17:20 -04:00
Mahmood Ali
6c414cd5f9 gofmt all the files 
mostly to handle build directives in 1.17.
 2021-10-01 10:14:28 -04:00
Mahmood Ali
5cd5c2c9ee build: Update to golang 1.17.1 2021-10-01 09:41:25 -04:00
James Rasell
05efead600 changelog: add entry for #11249 2021-10-01 12:50:51 +01:00
James Rasell
cad7cdb7bc deps: update hashicorp/go-discover. 2021-10-01 12:27:39 +01:00
Michael Schurter
da345ef7c5 Merge pull request #10796 from hashicorp/external-nvidia 
devices: externalize nvidia device driver
 2021-09-29 15:52:45 -07:00
Tim Gross
420bce0af0 devices: externalize nvidia device driver 2021-09-29 13:43:37 -07:00
Michael Schurter
c09447e414 Merge pull request #11236 from hashicorp/test-flaky-autopilot 
test: fix flaky TestAutopilot_CleanupDeadServer
 2021-09-29 13:15:43 -07:00
Luiz Aoqui
0d46e762fb docs: add Nomad version requirement note for sysbatch (#11231) 2021-09-29 15:14:51 -04:00
Michael Schurter
ff2f48f8c1 Merge pull request #10992 from ggriffiths/px_csi_driver_example 
Add Portworx CSI Driver example
 2021-09-29 10:53:08 -07:00
Michael Schurter
04a3f94692 docs: add @ggriffiths as author 2021-09-29 10:50:51 -07:00
Michael Schurter
524ffbd8dd Merge pull request #11234 from hashicorp/docs-csi-demo 
docs: note demos/csi is unsupported
 2021-09-29 08:54:56 -07:00
Michael Schurter
34bf59a3d0 test: fix flaky TestAutopilot_CleanupDeadServer 
The fix seems to be related to the pointer comparison and swapping we
did around killing a non-leader. I actually can't quite explain it, but
when comparing against Consul's version of this test I noticed they used
the slice index to track the killed server instead of pointer swapping.

As soon as I switched to slice index tracking I could no longer
reproduce the failure.

In addition:
- Tested membership counts on all servers instead of just 1 for added
  correctness.
- Stopped testing raft v1 because it is unsupported.
 2021-09-28 16:38:56 -07:00
Michael Schurter
251098e9dd test: fix fake by increasing time window 
Test originally only had a 10ms time window tolerance. Increased to
100ms and also improved assertions and docstrings.
 2021-09-28 12:22:59 -07:00
Michael Schurter
de89aca494 docs: note demos/csi is unsupported 
Also start tagging authors to ease support by third parties.
 2021-09-28 11:11:19 -07:00
jmwilkinson
28bd7fe021 Update filesystem.mdx (#11182) 
* Update filesystem.mdx

Update summary of alloc directory to include information on access differences between task drivers and filesystem isolation modes.

Co-authored-by: Tim Gross <tim@0x74696d.com>
 2021-09-27 16:36:04 -07:00
Noel Quiles
33775bbff2 Update alert banner for HashiConf Global 2021 (#11229) 2021-09-27 14:49:33 -04:00
James Rasell
7cb309f13b Merge pull request #11224 from hashicorp/b-docs-node-eval-apidocs 
docs: fix API docs node evaluate example call.
 2021-09-24 15:18:49 +02:00
James Rasell
e8e25a2f38 docs: fix API docs node evaluate example call. 2021-09-24 10:28:22 +01:00
Michael Schurter
d486e1d500 Merge pull request #11218 from hashicorp/docs-update-reserved 
DOCS: Clarify the reservation example
 2021-09-22 16:15:34 -07:00
Charlie Voiselle
9065bdb83f Clarify that reservation example 
The current wording can lead someone to believe that you can use percentage values.
 2021-09-22 18:30:39 -04:00
Luiz Aoqui
2904a0710a Disable PowerShell profile and simplify fingerprinting link speed on Windows (#11183) 2021-09-22 11:17:47 -04:00
Michael Schurter
1301649b9b Merge pull request #11215 from hashicorp/b-license-env-deny 
client: add NOMAD_LICENSE to default env deny list
 2021-09-21 16:53:26 -07:00
Luiz Aoqui
4eb902d890 docs: add some extra documentation around client host environment variables (#11208) 
Co-authored-by: Michael Schurter <mschurter@hashicorp.com>
 2021-09-21 17:23:30 -04:00
Michael Schurter
33c91fd734 client: add NOMAD_LICENSE to default env deny list 
By default we should not expose the NOMAD_LICENSE environment variable
to tasks.

Also refactor where the DefaultEnvDenyList lives so we don't have to
maintain 2 copies of it. Since client/config is the most obvious
location, keep a reference there to its unfortunate home buried deep
in command/agent/host. Since the agent uses this list as well for the
/agent/host endpoint the list must be accessible from both command/agent
and client.
 2021-09-21 13:51:17 -07:00
Michael Schurter
2c607fc9fa Merge pull request #11214 from hashicorp/docs-1.1.5-changelog 
Update changelog for v1.1.5 and v1.0.11
 2021-09-21 09:59:41 -07:00
Michael Schurter
89d4885a7b Update changelog for v1.1.5 and v1.0.11 2021-09-21 09:09:40 -07:00
Michael Schurter
a3d30748df Merge pull request #11210 from hashicorp/docs-1.1.5 
website: update to 1.1.5
 2021-09-21 08:59:58 -07:00
Michael Schurter
79c04b816f website: update to 1.1.5 
Also update LAST_RELEASE in makefile to 1.1.5
 2021-09-20 16:50:37 -07:00
Michael Schurter
d7f9180a49 Merge pull request #11206 from hashicorp/b-gh-11202 
client: task env vars should take precedence over host env vars.
 2021-09-20 11:22:58 -07:00
James Rasell
81faab7ceb changelog: add entry for #11206 2021-09-20 18:05:42 +01:00
James Rasell
fdc96d9010 client: task env vars should take precendece over host env vars. 2021-09-20 09:15:28 +01:00
Florian Apolloner
f6c1e1dc3c Fixed usage of NOMAD_CLI_NO_COLOR env variable. (#11168) 2021-09-17 20:37:05 -04:00
Michael Schurter
33a6bbcf1d Merge pull request #11198 from hashicorp/f-no-audit-log-timestamp 
docs: add upgrade guide entry for audit log naming
 2021-09-17 11:57:46 -07:00
James Rasell
017c51f9df Merge pull request #11194 from hashicorp/b-fix-e2e-acl-tls-provision 
e2e: fix provisioning when ACLs and TLS enabled.
 2021-09-17 08:11:10 +02:00
Michael Schurter
7c73e59d88 docs: add changelog entry for audit log naming 2021-09-16 16:21:57 -07:00
Michael Schurter
5e17917738 docs: add upgrade guide entry for audit log naming 2021-09-16 16:19:52 -07:00
James Rasell
5e25277183 e2e: fix provisioning when ACLs and TLS enabled; no nightly TLS. 2021-09-16 17:15:41 +02:00
Luiz Aoqui
b4e222f6cc Log network device name during fingerprinting (#11184) 2021-09-16 10:48:31 -04:00
Luiz Aoqui
fe3112a129 connect: update allowed protocols in ingress gateway config (#11187) 2021-09-16 10:47:53 -04:00
James Rasell
001579a598 Merge pull request #11189 from hashicorp/f-gh-11173-docs 
docs: add changelog and website entry for #11173
 2021-09-16 08:13:29 +02:00