Commit Graph

14343 Commits

Author SHA1 Message Date
Michael Schurter
74aca9a465 Merge pull request #5443 from hashicorp/f-systemd-fixes
docs: sync systemd unit files; update deploy guide
2019-03-20 10:40:53 -07:00
Michael Schurter
673a168b72 docs: remove partial sig/checksum verification
Point users to security doc instead. Right now it takes a lot of
explaining to describe to users exactly how to validate the binary and
what the output of the tools used means.

For example, this is the output when validating according to the
instructions in this guide and the linked doc:

```
vagrant@linux:/tmp$ gpg --verify nomad_0.8.7_SHA256SUMS.sig
nomad_0.8.7_SHA256SUMS
gpg: Signature made Fri 11 Jan 2019 09:47:56 PM UTC using RSA key ID
348FFC4C
gpg: Good signature from "HashiCorp Security <security@hashicorp.com>"
gpg: WARNING: This key is not certified with a trusted signature!
gpg:          There is no indication that the signature belongs to the
owner.
Primary key fingerprint: 91A6 E7F8 5D05 C656 30BE  F189 5185 2D87 348F
FC4C
vagrant@linux:/tmp$ shasum -a 256 -c nomad_0.8.7_SHA256SUMS
shasum: ./nomad_0.8.7_darwin_amd64.zip:
./nomad_0.8.7_darwin_amd64.zip: FAILED open or read
shasum: ./nomad_0.8.7_linux_386.zip: No such file or directory
./nomad_0.8.7_linux_386.zip: FAILED open or read
shasum: ./nomad_0.8.7_linux_amd64-lxc.zip: No such file or directory
./nomad_0.8.7_linux_amd64-lxc.zip: FAILED open or read
./nomad_0.8.7_linux_amd64.zip: OK
shasum: ./nomad_0.8.7_linux_arm64.zip: No such file or directory
./nomad_0.8.7_linux_arm64.zip: FAILED open or read
shasum: ./nomad_0.8.7_linux_arm.zip: No such file or directory
./nomad_0.8.7_linux_arm.zip: FAILED open or read
shasum: ./nomad_0.8.7_windows_386.zip: No such file or directory
./nomad_0.8.7_windows_386.zip: FAILED open or read
shasum: ./nomad_0.8.7_windows_amd64.zip: No such file or directory
./nomad_0.8.7_windows_amd64.zip: FAILED open or read
shasum: WARNING: 7 listed files could not be read
```

There are only two lines that matter in all of that output:

```
...
gpg: Good signature from "HashiCorp Security <security@hashicorp.com>"
...
./nomad_0.8.7_linux_amd64.zip: OK
...
```

I feel like trying to teach users how to use and interpret these tools
in our deployment guide may be as likely to reduce confidence as
increase it.
2019-03-20 09:36:29 -07:00
Mahmood Ali
b1ce0d8204 doc: fix tls_cipher_suites type (#5441)
tls_cipher_suites only accept a comma-separated string, as evident in:

0535dfd414/nomad/structs/config/tls.go (L61)
d37ed5c193/helper/tlsutil/config.go (L405)
2019-03-20 12:17:38 -04:00
Mahmood Ali
ce959931c5 update some changelog items 2019-03-20 11:20:25 -04:00
Mahmood Ali
608f17e7c9 Don't use "datacenter" in a confusing way
Co-Authored-By: schmichael <michael.schurter@gmail.com>
2019-03-20 08:08:37 -07:00
Michael Schurter
f6d670a096 Merge pull request #5450 from hashicorp/docs-changelog
docs: add #5381 to changelog
2019-03-20 07:53:49 -07:00
Michael Schurter
c827232581 docs: add #5381 to changelog 2019-03-20 07:05:05 -07:00
Mahmood Ali
ba5078f7ca Merge pull request #5430 from HashedDan/server-typo
server: inconsistent receiver notation corrected
2019-03-20 08:48:17 -04:00
Mahmood Ali
a0d025e90d Revert "executor: synchronize exitState accesses" (#5449)
Reverts hashicorp/nomad#5433

Apparently, channel communications can constitute Happens-Before even for proximate variables, so this syncing isn't necessary.

> _The closing of a channel happens before a receive that returns a zero value because the channel is closed._
https://golang.org/ref/mem#tmp_7
2019-03-20 07:33:05 -04:00
Mahmood Ali
c28b59267c Merge pull request #5435 from hashicorp/release-scripts-20190318
Scripts for automating binary building
2019-03-20 07:26:10 -04:00
Mahmood Ali
a8c255665d release: Upgrade to use 1.11.6 golang on macOS
To correspond to the Linux scripts in 855761a5df
2019-03-19 21:18:44 -04:00
Mahmood Ali
5ad4c10a58 Add some release script comments 2019-03-19 21:18:27 -04:00
Michael Schurter
475bcaafd6 docs: sync systemd unit files; update deploy guide
The systemd configs spread across our repo were fairly out of sync. This
should get them on our best practices.

The deployment guide also had some strange things like running Nomad as
a non-root user. It would be fine for servers but completely breaks
clients. For simplicity I simply removed the non-root user references.
2019-03-19 15:18:12 -07:00
Nick Ethier
d9d90fa5f0 Merge pull request #5429 from hashicorp/b-blocking-executor-shutdown
executor: block shutdown on process exiting
2019-03-19 15:18:01 -04:00
Michael Schurter
d37ed5c193 Merge pull request #5436 from hashicorp/f-vagrant-go1.11.6
vagrant: upgrade to Go 1.11.6
2019-03-19 08:20:13 -07:00
Michael Schurter
855761a5df vagrant: upgrade to Go 1.11.6 2019-03-18 13:38:00 -07:00
Mahmood Ali
f3a186cef5 accept macos host as a env-var with a default 2019-03-18 15:05:32 -04:00
Mahmood Ali
55dea4faaa use bash set long form 2019-03-18 14:34:09 -04:00
Mahmood Ali
31e89623df ensure node is present in PATH 2019-03-18 14:31:31 -04:00
Mahmood Ali
b3bedeb330 Merge pull request #5433 from hashicorp/b-exit-state-lock
executor: synchronize exitState accesses
2019-03-18 13:50:16 -04:00
Mahmood Ali
38aa059e43 scripts: only shellcheck shell scripts 2019-03-18 08:45:25 -04:00
Mahmood Ali
60b045b13f handle when no files are generated 2019-03-18 08:29:25 -04:00
Mahmood Ali
bf48fe2403 initial attempt at building mac 2019-03-18 08:29:25 -04:00
Mahmood Ali
f2760b55c4 remove chown 2019-03-18 08:29:22 -04:00
Mahmood Ali
989175fc59 executor: synchronize exitState accesses
exitState is set in `wait()` goroutine but accessed in a different
`Wait()` goroutine, so accesses must be synchronized by a lock.
2019-03-17 11:56:58 -04:00
Mahmood Ali
d5d6477c87 Add a Docker release scripts
Also tease out some dev and docker bits from Vagrant scripts to ease
sharing with Docker script
2019-03-17 10:37:36 -04:00
Mahmood Ali
27924bccc4 Merge pull request #5425 from sarcasticadmin/sa/freebsd-vagrant-fix
Freebsd vagrant fixes
2019-03-16 21:00:03 -04:00
HashedDan
2678407ea1 server: inconsistent receiver notation corrected
Signed-off-by: HashedDan <georgedanielmangum@gmail.com>
2019-03-16 17:53:53 -05:00
Nick Ethier
c2c984ea50 executor: block shutdown on process exiting 2019-03-15 23:50:17 -04:00
Omar Khawaja
24eaa4b9f9 AWS env update (#5423)
* update versions of all products and add consul-template

* update client and server user_data scripts

* modify README.md and terraform.tfvars

* fix typo in consul-template system unit file

* update AMI id
2019-03-15 15:55:34 -04:00
Mahmood Ali
5aba4f1a72 Merge pull request #5415 from hashicorp/b-fix-libcontainer-panic
fix possible panic in libcontainer shim init
2019-03-15 15:29:57 -04:00
Omar Khawaja
a1b9b32210 Portworx guide (#5399)
* skeleton

* configure portworx

* destroy and redeploy mysql with data intact

* rename all directories and references from persistent storage to stateful workloads

* add considerations and remove references to StorageOS

* update wording and headings

* create portworx volume externally and modify jobfile to reflect that

* fix typo

* Update website/source/guides/stateful-workloads/portworx.html.md

Co-Authored-By: Omar-Khawaja <Omar-Khawaja@users.noreply.github.com>

* Update website/source/guides/stateful-workloads/portworx.html.md

Co-Authored-By: Omar-Khawaja <Omar-Khawaja@users.noreply.github.com>
2019-03-15 11:33:46 -04:00
Robert James Hernandez
20a16348fe Update vagrant box to freebsd 11.2 STABLE
Freebsd 11.1 went EOL 9/30/18:
https://lists.freebsd.org/pipermail/freebsd-announce/2018-September/001842.html

Was seeing a failure with shared object "libdl.so.1" not found which
is required for bash
2019-03-14 18:36:30 -07:00
Mahmood Ali
2b3d324a7f Handle when cannot fetch docker logs (#5420)
Fix #5418

When using a docker logger that doesn't support log streaming through
API, currently docker logger runs a tight loop of Docker API calls
unexpectedly. This change ensures we stop fetching logs early.

Also, this adds some basic backoff strategy when Docker API logging
fails unexpectedly, to avoid accidentally DoSing the docker daemon.
2019-03-14 16:23:11 -04:00
Mahmood Ali
eb5ab38ae5 Regenerate Proto files (#5421)
Noticed that the protobuf files are out of sync with ones generated by 1.2.0 protoc go plugin.

The cause for these files seem to be related to release processes, e.g. [0.9.0-beta1 preperation](ecec3d38de (diff-da4da188ee496377d456025c2eab4e87)), and [0.9.0-beta3 preperation](b849d84f2f).

This restores the changes to that of the pinned protoc version and fails build if protobuf files are out of sync.  Sample failing Travis job is that of the first commit change: https://travis-ci.org/hashicorp/nomad/jobs/506285085
2019-03-14 10:56:27 -04:00
Robert James Hernandez
c22facf3a5 Set shell to sh and networking to host dhcp
Set shell to sh which is present by default on freebsd. Also set
networking to host dhcp due to limitations with NFS sharing:
https://github.com/hashicorp/vagrant/issues/9063
2019-03-13 20:58:25 -07:00
Robert James Hernandez
31bad0ffb7 Fix freebsd vagrant priv config for vim-tiny 2019-03-13 19:21:59 -07:00
Preetha
2ca6229625 Merge pull request #5413 from hashicorp/b-alloc-metrics
Fix bug with score metadata overridden during inplace upgrades
2019-03-13 13:29:04 -05:00
Preetha
5ccec41e31 Merge pull request #5416 from hashicorp/b-docker-email
Fix regression with requiring docker auth email
2019-03-13 13:28:34 -05:00
Preetha Appan
e8284caae8 minor review feedback 2019-03-13 13:27:28 -05:00
Preetha Appan
d1ca05c80b Validate all auth fields being empty rather than just email
This fixes a regression in 0.9 beta3 compared to 0.8.7 in validating
docker auth config
2019-03-13 11:47:37 -05:00
Preetha Appan
1893f10bb6 Dont require email address for docker auth 2019-03-13 11:08:56 -05:00
Preetha Appan
1323b4d5cc Fix bug where scoring metadata would be overridden during an inplace upgrade. 2019-03-12 23:36:46 -05:00
Michael Schurter
4bacdcd403 Merge pull request #5386 from hashicorp/b-logmon-stop
Fix task/logmon leak after crash
2019-03-12 15:23:02 -07:00
Michael Schurter
e9e1d788b5 client: cleanup and document context uses
Some of the context uses in TR hooks are useless (Killed during Stop
never seems meaningful).

None of the hooks are interruptable for graceful shutdown which is
unfortunate and probably needs fixing.
2019-03-12 15:03:54 -07:00
Michael Schurter
bfff8d8e25 Merge pull request #5371 from hashicorp/docs-backincompat
Backward compat note about task config validation
2019-03-12 14:33:05 -07:00
Nick Ethier
caf87fdf59 fix possible panic in libcontainer shim init 2019-03-11 21:57:21 -04:00
Chris Baker
783c49b34b Merge pull request #5373 from hashicorp/docs-artifact-stanza
artifact stanza documentation
2019-03-11 14:09:28 -04:00
Charlie Voiselle
e7bd312580 Merge pull request #5401 from hashicorp/doc-rkt-needs-root
Note rkt driver needs Nomad client run as root
2019-03-11 10:29:45 -04:00
Mahmood Ali
086677b0df run TestAllocations_Stats in CI 2019-03-08 07:57:37 -05:00