Commit Graph

20248 Commits

Author SHA1 Message Date
Buck Doyle
863c194733 Fix job recommendation test flakiness (#9591)
Instead of creating recommendations for all the jobs used
across these tests, this creates a specific job with
a higher group count, which reduces the likelihood
of having no recommendations to 0.0001%.

It was incorrect to assume that each task group would always
have recommendations, since there’s a 1% chance that a task
won’t have a recommendation. (10% chance for CPU and memory.)
This uses the number of groups with recommendations instead.
2020-12-10 10:10:25 -06:00
Kris Hicks
7747124ef0 Apply some suggested fixes from staticcheck (#9598) 2020-12-10 07:29:18 -08:00
Kris Hicks
74cb28ec30 pluginmanager: WaitForFirstFingerprint times out (#9597)
As pointed out by @tgross[1], prior to this change we would have been blocking
until all managers waited for first fingerprint rather than timing out as
intended.

1: https://github.com/hashicorp/nomad/pull/9590#discussion_r539534906
2020-12-10 07:27:15 -08:00
André Peters
82828aaa00 Update index.mdx
"Invalid argument name; Argument names must not be quoted."
2020-12-10 08:21:47 -05:00
Mahmood Ali
09a3056518 Tweak early return website workflow (#9593)
* ci: only spin up a docker engine if necessary

Halt the website-docker-image job early if no changes are detected. We
halt early before spinning up the remote docker engine, as the remote
docker engine step can add some delay (seconds to minutes) and is more
likely to suffer circleci instability.

* ci: Only run website workflow in OSS repo

Add a CircleCI conditional to avoid running website worklows on forks.
2020-12-09 17:54:36 -05:00
Seth Hoenig
b38ccaac3d Merge pull request #9586 from hashicorp/f-connect-interp
consul/connect: interpolate connect block
2020-12-09 13:21:50 -06:00
Mahmood Ali
6bfbadc199 actually honor var files (#9592)
Apparently, we missed passing VarFile argument, so var files were
ignored.

Fixes #9588
2020-12-09 14:12:48 -05:00
Kris Hicks
85ed8ddd4f Add gosimple linter (#9590) 2020-12-09 11:05:18 -08:00
Kris Hicks
8333ab9f80 circleci: Allow expanding Makefile in enterpise (#9587)
OSS no longer needs the multi-file config Makefile content, so it was
removed. However, enterprise does benefit from having that around. We
can allow enterprise to expand on OSS' CircleCI Makefile by adding an
include directive in OSS. This will allow the Makefile to be the same on
both OSS and Enterprise, so merge conflicts cannot occur.
2020-12-09 09:53:26 -08:00
Seth Hoenig
edf1e25d30 consul/connect: avoid extra copy of connect stanza while interpolating 2020-12-09 11:44:07 -06:00
Seth Hoenig
54653d265e docs: fixup changelog
Co-authored-by: Tim Gross <tgross@hashicorp.com>
2020-12-09 11:27:12 -06:00
Seth Hoenig
c1f1b1573c Merge pull request #9589 from hashicorp/f-aws-graviton
client/fingerprint/cpu: use fallback total compute value if cpu not detected
2020-12-09 11:19:44 -06:00
Seth Hoenig
da1235f35b client/fingerprint/cpu: use fallback total compute value if cpu not detected
Previously, Nomad would fail to startup if the CPU fingerprinter could
not detect the cpu total compute (i.e. cores * mhz). This is common on
some EC2 instance types (graviton class), where the env_aws fingerprinter
will override the detected CPU performance with a more accurate value
anyway.

Instead of crashing on startup, have Nomad use a low default for available
cpu performance of 1000 ticks (e.g. 1 core * 1 GHz). This enables Nomad
to get past the useless cpu fingerprinting on those EC2 instances. The
crashing error message is now a log statement suggesting the setting of
cpu_total_compute in client config.

Fixes #7989
2020-12-09 10:35:58 -06:00
Seth Hoenig
4d0e74585a consul/connect: interpolate connect block
This PR enables job submitters to use interpolation in the connect
block of jobs making use of consul connect. Before, only the name of
the connect service would be interpolated, and only for a few select
identifiers related to the job itself (#6853). Now, all connect fields
can be interpolated using the full spectrum of runtime parameters.

Note that the service name is interpolated at job-submission time,
and cannot make use of values known only at runtime.

Fixes #7221
2020-12-09 09:10:00 -06:00
Kris Hicks
0c03202ce5 circleci: Remove GO_TAGS from build-binaries job (#9579)
These tags default to the same value in GNUMakefile. This will also help
fix a discrepancy between the build-binaries job in OSS and Ent.
2020-12-09 06:56:56 -08:00
Drew Bailey
e76add702d use concrete type helper instead of interface surfing (#9585)
* use concrete type helper instead of interface surfing

* wrap err
2020-12-09 09:02:37 -05:00
Kris Hicks
bbf1eaa833 Remove multi-file CircleCI config (#9571) 2020-12-08 13:18:11 -08:00
Kris Hicks
071f4c7596 Add gocritic to golangci-lint config (#9556) 2020-12-08 12:47:04 -08:00
Michael Schurter
dfcdc9c53d Merge pull request #9574 from hashicorp/docs-20-to-1
docs: fix cpu comment for 10->1 to 20->1
2020-12-08 11:10:28 -08:00
Michael Schurter
b53cdefda7 docs: fix cpu comment for 10->1 to 20->1
Reported by https://github.com/hashicorp/nomad/pull/8996/files#r538702174
2020-12-08 10:59:19 -08:00
Michael Schurter
da3b3c3008 Merge pull request #9573 from hashicorp/docs-alert-100
docs: add an announcement for 1.0
2020-12-08 10:29:40 -08:00
Dennis Schön
d294a7888b return 405 on non-GET requests to /v1/event/stream (fixes #9526) (#9564) 2020-12-08 13:09:20 -05:00
Michael Schurter
5d250fc732 docs: add an announcement for 1.0 2020-12-08 09:59:49 -08:00
Kris Hicks
be6e5e9e6d scheduler: Fix always-false sort func (#9547)
Co-authored-by: Mahmood Ali <mahmood@hashicorp.com>
2020-12-08 09:57:47 -08:00
Michael Schurter
9027e8b94c Merge pull request #9572 from hashicorp/docs-100-date
docs: add the release date for 1.0
2020-12-08 09:28:31 -08:00
Michael Schurter
cfbcc995dd docs: add the release date for 1.0 2020-12-08 09:27:26 -08:00
Michael Schurter
a50187c5e9 Merge pull request #9569 from hashicorp/docs-100
docs: 1.0.0 download link
2020-12-08 09:09:29 -08:00
Mike Wickett
a0fd438d9d website: Update k8s comparison docs, ecosystem and community (#9557)
* website: add k8s vs callout to homepage

* website: move resources to community

* website: add k8s comparison, ecosytem to docs

* website: update redirects

* website: fix homepage link

* website: fix sidebar data

* Update website/pages/docs/nomad-vs-kubernetes/index.mdx

Co-authored-by: changli0617 <39781496+changli0617@users.noreply.github.com>

* Update website/pages/docs/nomad-vs-kubernetes/alternative.mdx

Co-authored-by: changli0617 <39781496+changli0617@users.noreply.github.com>

* Update website/pages/docs/nomad-vs-kubernetes/alternative.mdx

Co-authored-by: changli0617 <39781496+changli0617@users.noreply.github.com>

* Update website/pages/docs/nomad-vs-kubernetes/alternative.mdx

Co-authored-by: changli0617 <39781496+changli0617@users.noreply.github.com>

Co-authored-by: changli0617 <39781496+changli0617@users.noreply.github.com>
2020-12-08 12:09:15 -05:00
Michael Schurter
6a1af2de51 docs: 1.0.0 download link 2020-12-08 08:00:21 -08:00
Mahmood Ali
c7c386474d Remove Beta tag from 1.0 features (#9562)
* docs: Remove 1.0 beta warning about HCL2.0 docs

* docs: multiregion is not beta anymore either

* docs: scaling isn't beta

* docs: neither is events api
2020-12-08 09:39:25 -05:00
Tim Gross
399d49bd64 changelog entry for #9495 2020-12-08 09:21:52 -05:00
davemay99
bb5b0b826f nomad operator debug changelog / doc updates 2020-12-08 08:51:45 -05:00
davemay99
1fb1c48f2f Update golang version table 2020-12-08 08:51:34 -05:00
Charlie Voiselle
c8e2c910d6 Upgade links to guides 2020-12-08 08:51:21 -05:00
Dave May
d757507341 fix AgentHostRequest panic found in GH-9546 (#9554)
* debug: refactor nodeclass test
* debug: add case to track down SIGSEGV on client to server Agent.Host RPC
* verify server to avoid panic on AgentHostRequest RPC call, fixes GH-9546
* simplify Agent.Host RPC lookup logic
2020-12-07 17:34:40 -05:00
Michael Lange
44c236788e Merge pull request #9553 from hashicorp/b-ui/missing-scale-events
UI: Guard against null Meta on scale events
2020-12-07 14:10:13 -08:00
Shishir
6cab345633 Update containerd task driver docs. (#9550) 2020-12-07 16:51:19 -05:00
Mark Lewis
3e4be747f2 docs: grammatical fixes in service jobspec 2020-12-07 15:41:44 -05:00
Michael Lange
2af9430db5 Test coverage for the scale event serializer 2020-12-07 12:28:47 -08:00
Michael Lange
a93e95d259 Guard against a null Meta property in the scale event API 2020-12-07 12:28:23 -08:00
Mahmood Ali
6b43ecb425 document some hcl2 quarks (#9545)
Mainly note that block labels need to be string literals, and that decimals without a leading significant digits aren't acceptable anymore (e.g. .9 are required to be 0.9).

Dynamic blocks can be used here, but feels too much of a hack, or a hammer to highlight it here, specially given the error reporting and debugging isn't so straightforward. I'd advocate internally for relaxing the restriction and allowing expressions in block labels instead.

Related to https://github.com/hashicorp/nomad/issues/9522
2020-12-07 12:31:25 -05:00
Tim Gross
2f110804d1 changelog entry for #8822 2020-12-07 11:25:37 -05:00
Luiz Aoqui
0dcf6035b7 docs: update autoscaling docs for the new query interface (#8917)
* update autoscaling docs for the new query interface
* update default value for query_window in scaling policy
2020-12-07 10:43:08 -05:00
Dennis Schön
582d3b7092 use os.ErrDeadlineExceeded in tests 2020-12-07 10:40:28 -05:00
Seth Hoenig
bd6776b9fd Merge pull request #9541 from hashicorp/docs-cni-note-conflist
docs: note conflist extension for cni plugin configuration files
2020-12-07 09:40:00 -06:00
Seth Hoenig
572ed2f723 docs: note conflist extension for cni plugin configuration files 2020-12-07 09:36:39 -06:00
Buck Doyle
e84a360e42 Fix allocation count in CSI volumes table (#9515)
This closes #9495. As detailed in there, the collection query GET
/v1/volumes?type=csi doesn’t return ReadAllocs and WriteAllocs, so the #
Allocs cell was always showing 0 upon first load because it was derived
from the lengths of those arrays. This uses the heretofore-ignored
CurrentReaders and CurrentWriters values to calculate the total instead.

The single-resource query GET /v1/volume/csi%2F:id doesn’t return
CurrentReaders and CurrentWriters that absence doesn’t override the
stored values when visiting an individual item.

Thanks to @apollo13 for reporting this and to @tgross for the API logs
and suggestion.
2020-12-07 08:51:41 -06:00
Buck Doyle
3b59e1bec7 Migrate preview deployments from Netlify to Vercel (#9471)
This adds:

* a script for building and deploying the Ember UI and Storybook to
  Vercel
* configuration for that deployment
* a header link to the UI to link to Storybook when built with
  STORYBOOK_LINK=true

It also removes a file used to configure Netlify redirects.

The Netlify setup had two “sites”: nomad-storybook and nomad-ui. I
attempted to replicate that here but ran into some platform limitations
with Vercel: two “projects” cannot share the same root directory without
also sharing the same vercel.json that lets us specify configuration
such as the rewrite needed to handle deep linking into the Ember UI. I
tried having Storybook use /ui/storybook as the root directory (and
adding a symbolically-linked package.json to bypass Vercel’s refusal
to build without it) but that produced broken Storybook deployments.

This instead combines the two projects into one
(nomad-storybook-and-ui), defaults to forwarding / to /ui/, and
adds the header link to the UI to navigate to Storybook.

Rather than have a complex build script in the Vercel configuration UI,
this delegates to a script in the repository.
2020-12-07 08:33:49 -06:00
Drew Bailey
d76340f0f7 fix allocation spelling error, update docs (#9527)
* fix allocation spelling error, update docs

* assign TopicACLPolicy and TopicACLToken properly
2020-12-04 12:04:58 -05:00
James Rasell
574868b4ae Merge pull request #9520 from hashicorp/b-fix-nullchar-error-msg
core: fix typo msg used when job ID/name contains a null char.
2020-12-04 17:40:08 +01:00