Commit Graph

14715 Commits

Author SHA1 Message Date
Mahmood Ali
a321901ad8 retry grpc unavailable errors even if not shutting down 2019-04-25 18:39:17 -04:00
Mahmood Ali
658a734912 try checking process status 2019-04-25 18:16:13 -04:00
Mahmood Ali
1f1551a4ae add logging about attempts 2019-04-25 18:09:36 -04:00
Mahmood Ali
ba373fee2a try sleeping for stop signal to take effect 2019-04-25 17:16:29 -04:00
Mahmood Ali
978fc65a2b add a test that simulates logmon dying during Start() call 2019-04-25 16:41:17 -04:00
Mahmood Ali
b21849cb02 logmon: retry starting logmon if it exits
Retry if we detect shutting down during Start() api call is started,
locally.
2019-04-25 15:10:16 -04:00
Mahmood Ali
c23d673b7e logmon client to handle grpc closing errors 2019-04-25 14:32:24 -04:00
Mahmood Ali
2764fc8c3c Merge pull request #5609 from hashicorp/b-docker-tty-logs
driver/docker: collect tty container logs
2019-04-25 08:28:32 -04:00
Danielle
a4ed10902b Merge pull request #5597 from hashicorp/dani/doc-alloc-stop
Documentation for `nomad alloc stop`
2019-04-25 12:23:09 +02:00
Mahmood Ali
ce8a8a5326 driver/docker: collect tty container logs
Fixes https://github.com/hashicorp/nomad/issues/5475

When container is a tty container, we need to get raw terminal output
without any additional processing.
2019-04-24 22:01:51 -04:00
Arshneet Singh
8d48b77bca Merge pull request #5602 from hashicorp/normalized-plan
Normalize plan to increase the plan apply throughput
2019-04-24 14:07:26 -07:00
Michael Schurter
653b89e8fd Merge pull request #5607 from ArangoGutierrez/website_singularity
singularity_path -> singularity_cache
2019-04-24 14:02:49 -07:00
Chris Baker
3116f79967 Minor typo fix 2019-04-24 15:51:26 -04:00
Arshneet Singh
23bc1f2680 Change min version required for plan optimization 2019-04-24 12:36:07 -07:00
Arshneet Singh
ab2718c850 Return error when preempted/stopped alloc doesn't exist during denormalization 2019-04-24 12:36:07 -07:00
Michael Lange
712e774ccf Merge pull request #5594 from hashicorp/f-ui-preemptions
UI: Preemptions
2019-04-24 10:53:53 -07:00
Eduardo Arango
a54f322814 singularity_path -> singularity_cache
Signed-off-by: Eduardo Arango <eduardo@sylabs.io>
2019-04-24 12:43:16 -05:00
Preetha
93e115e14e Merge pull request #5606 from hashicorp/docs-ea-update-0.9
Docs ea update 0.9
2019-04-24 10:48:57 -05:00
Arshneet Singh
ee268a58db Add comments to functions, and use require instead of assert 2019-04-23 09:57:21 -07:00
Arshneet Singh
97686e371f Remove allowPlanOptimization from schedulers 2019-04-23 09:18:02 -07:00
Arshneet Singh
02b832c3ff Compat tags 2019-04-23 09:18:01 -07:00
Arshneet Singh
f75c6b4bdb Add tests for plan normalization 2019-04-23 09:18:01 -07:00
Arshneet Singh
4eedab18a7 Add code for plan normalization 2019-04-23 09:18:01 -07:00
Michael Schurter
987ed01b11 Merge pull request #5599 from hashicorp/docs-091rc1
docs: add download link to 0.9.1-rc1
2019-04-23 08:54:41 -07:00
Michael Schurter
c2ffc69a41 docs: add download link to 0.9.1-rc1 2019-04-23 08:47:21 -07:00
Nick Ethier
cfad24c976 website: add plugin docs (#5501)
website: add plugin docs
2019-04-23 11:22:08 -04:00
Nick Ethier
ff9b3e370a website: fixs a few errors in new plugin docs 2019-04-23 11:15:26 -04:00
Mahmood Ali
c76130c052 Merge pull request #5598 from hashicorp/b-dont-forward-logs
fix crash when executor parent nomad process dies
2019-04-23 10:15:30 -04:00
Mahmood Ali
c07c0c810f fix crash when executor parent nomad process dies
Fixes https://github.com/hashicorp/nomad/issues/5593

Executor seems to die unexpectedly after nomad agent dies or is
restarted.  The crash seems to occur at the first log message after
the nomad agent dies.

To ease debugging we forward executor log messages to executor.log as
well as to Stderr.  `go-plugin` sets up plugins with Stderr pointing to
a pipe being read by plugin client, the nomad agent in our case[1].
When the nomad agent dies, the pipe is closed, and any subsequent
executor logs fail with ErrClosedPipe and SIGPIPE signal.  SIGPIPE
results into executor process dying.

I considered adding a handler to ignore SIGPIPE, but hc-log library
currently panics when logging write operation fails[2]

This we opt to revert to v0.8 behavior of exclusively writing logs to
executor.log, while we investigate alternative options.

[1] https://github.com/hashicorp/nomad/blob/v0.9.0/vendor/github.com/hashicorp/go-plugin/client.go#L528-L535
[2] https://github.com/hashicorp/nomad/blob/v0.9.0/vendor/github.com/hashicorp/go-hclog/int.go#L320-L323
2019-04-23 09:52:46 -04:00
Danielle Lancashire
e4f57902f7 api docs: Add allocation stop 2019-04-23 13:28:21 +02:00
Danielle Lancashire
bc6b422d08 docs: Add documentation for 2019-04-23 13:22:27 +02:00
Danielle Lancashire
04d4d86e16 changelog: Update for GH-5512 and GH-5577 2019-04-23 13:12:08 +02:00
Danielle
9a4fe5e98f Merge pull request #5512 from hashicorp/dani/f-alloc-stop
alloc-lifecycle: nomad alloc stop
2019-04-23 13:05:08 +02:00
Danielle Lancashire
bb142af5d6 allocs: Add nomad alloc stop
This adds a `nomad alloc stop` command that can be used to stop and
force migrate an allocation to a different node.

This is built on top of the AllocUpdateDesiredTransitionRequest and
explicitly limits the scope of access to that transition to expose it
under the alloc-lifecycle ACL.

The API returns the follow up eval that can be used as part of
monitoring in the CLI or parsed and used in an external tool.
2019-04-23 12:50:23 +02:00
Michael Lange
4166a715fb Updated serializer unit tests 2019-04-22 17:20:52 -07:00
Michael Lange
d092723f89 Test coverage for preemption on the client detail page 2019-04-22 16:40:10 -07:00
Michael Lange
5aa938e121 Test coverage for preemption on the allocation detail page 2019-04-22 16:40:09 -07:00
Michael Lange
c7e1598ed3 Preemption modeling as page objects 2019-04-22 16:40:08 -07:00
Michael Lange
d4ae0a2819 Integration test for the alloc row icon 2019-04-22 16:40:07 -07:00
Michael Lange
4c773a1f3c Add preemption properties to Mirage allocation factory 2019-04-22 16:40:07 -07:00
Michael Lange
4752950cae Show which allocations an allocation preempted on the alloc page 2019-04-22 16:40:06 -07:00
Michael Lange
400deae4ce Show which alloc, if any, preempted an alloc on the alloc detail page 2019-04-22 16:40:05 -07:00
Michael Lange
7ae2081282 Preemptions count and filtering on client detail page
Show the count in the allocations table next to the existing total alloc
count badge. Clicking either will filter by all or by preemptions.
2019-04-22 16:40:04 -07:00
Michael Lange
a33b105181 Add preempted icon to alloc row 2019-04-22 16:40:04 -07:00
Michael Lange
dca386ca70 Make sure tooltips show up over the top of the side bar 2019-04-22 16:40:03 -07:00
Michael Lange
384a0e5a54 Add wasPreempted bool to allocs 2019-04-22 16:40:02 -07:00
Michael Lange
c456c5eed0 Show preemptions on the job plan phase of job submission 2019-04-22 16:40:01 -07:00
Michael Lange
cf1d4a3a1e Data modeling for preemptions 2019-04-22 16:40:00 -07:00
Chris Baker
09c998a4a1 Merge pull request #5591 from hashicorp/cgbaker/changelog
changelog: added entry for #5540 fix
2019-04-22 15:31:22 -04:00
Michael Schurter
95bc6fe301 Merge pull request #5586 from hashicorp/docs-deploy-ver
docs: bump deployment guide to 0.9.0
2019-04-22 12:29:22 -07:00