Commit Graph

9773 Commits

Author SHA1 Message Date
Michael Schurter
afd5bca566 Move service hash logic to Service.Hash method 2017-12-08 12:03:43 -08:00
Michael Schurter
65bfbe54c8 Hash fields used in task service IDs
Fixes #3620

Previously we concatenated tags into task service IDs. This could break
deregistration of tag names that contained double //s like some Fabio
tags.

This change breaks service ID backward compatibility so on upgrade all
users services and checks will be removed and re-added with new IDs.

This change has the side effect of including all service fields in the
ID's hash, so we no longer have to track PortLabel and AddressMode
changes independently.
2017-12-08 12:03:43 -08:00
Michael Schurter
7bf5cec82e Improve port label validation and diff testing 2017-12-08 12:03:43 -08:00
Michael Schurter
fa5faa5a09 Prevent using port 0 with address_mode=driver 2017-12-08 12:03:43 -08:00
Michael Schurter
b999358892 Validate port label for host address mode
Also skip getting an address for script checks which don't use them.

Fixed a weird invalid reserved port in a TaskRunner test helper as well
as a problem with our mock Alloc/Job. Hopefully the latter doesn't cause
other tests to fail, but we were referencing an invalid PortLabel and
just not catching it before.
2017-12-08 12:03:43 -08:00
Michael Schurter
f11360acf8 Add Using Driver Address Mode docs 2017-12-08 12:03:43 -08:00
Michael Schurter
f2d47156ec Document service/check address_mode/port changes 2017-12-08 12:03:43 -08:00
Michael Schurter
29e6f7cbfd Fix interpolation bug with service/check updates
Previously if only an interpolated variable used in a service or check
was changed we interpolated the old and new services and checks with the
new variable, so nothing appeared to have changed.
2017-12-08 12:03:00 -08:00
Michael Schurter
74e7d57b75 Test Consul from TaskRunner thoroughly
Rely less on the mockConsulServiceClient because the real
consul.ServiceClient needs all the testing it can get!
2017-12-08 12:03:00 -08:00
Michael Schurter
25569282b9 Allow custom ports for services and checks
Fixes #3380

Adds address_mode to checks (but no auto) and allows services and checks
to set literal port numbers when using address_mode=driver.

This allows SDNs, overlays, etc to advertise internal and host addresses
as well as do checks against either.
2017-12-08 12:03:00 -08:00
Michael Schurter
0921368fc9 Merge pull request #3608 from hashicorp/b-3342-windows-log-leak
Fix bug in log framer only affecting Windows
2017-12-08 10:59:26 -08:00
Preetha
f553ac8120 Merge pull request #3635 from hashicorp/clarify_node_vs_task_vars
Clarify difference between node and task metadata interpolated vars.
2017-12-08 11:50:20 -06:00
Preetha Appan
b1ca49fbca Clarify difference between node and task metadata interpolated vars. 2017-12-08 11:44:15 -06:00
Alex Dadgar
9f1955e474 Merge pull request #3630 from hashicorp/b-periodic
Handle race between fingerprinters and registration
2017-12-07 16:11:13 -08:00
Alex Dadgar
974b38f34e Review feedback 2017-12-07 16:10:57 -08:00
Michael Lange
8fd793e059 Adds UI changes to the changelog 2017-12-07 15:44:12 -08:00
Michael Lange
b09974e221 Merge pull request #3631 from hashicorp/b-ui-expand-definition
UI Show full job definition by default
2017-12-07 14:42:01 -08:00
Michael Lange
a78a2e333c Merge pull request #3607 from hashicorp/f-ui-modify-time-over-modify-index
UI Use ModifyTime instead of ModifyIndex in allocation lists
2017-12-07 14:25:28 -08:00
Michael Lange
f75123026d Expand the entire job definition by default 2017-12-07 14:06:51 -08:00
Chelsea Komlo
dfb95fd659 Merge pull request #3591 from hashicorp/b-1755-stop
Allow controlling the stop signal for drivers
2017-12-07 17:06:43 -05:00
Alex Dadgar
2e462d6e85 Handle race between fingerprinters and registration 2017-12-07 13:09:37 -08:00
Chelsea Holland Komlo
ae10b638db code review fixes 2017-12-07 13:46:25 -05:00
Rob Genova
34e6f447c9 Update README.md 2017-12-07 10:35:46 -08:00
Alex Dadgar
7c7eb2eeb9 Merge pull request #3628 from hashicorp/b-heartbeat
Add logging around heartbeats
2017-12-07 10:12:02 -08:00
Chelsea Holland Komlo
73a4a4620d add documention 2017-12-07 12:35:02 -05:00
Chelsea Holland Komlo
7d8dda8942 add test for kill signal in required signals
update changelog
2017-12-07 11:40:15 -05:00
Chelsea Holland Komlo
f09e3ec798 set default kill signal on executor shutdown 2017-12-07 11:40:15 -05:00
Chelsea Holland Komlo
27b666e935 extend configurable kill signal to java driver 2017-12-07 11:40:10 -05:00
Alex Dadgar
77fe78cce2 Drop trace logging 2017-12-06 18:02:24 -08:00
Alex Dadgar
a540a0b674 Add logging around heartbeats 2017-12-06 17:57:50 -08:00
Chelsea Holland Komlo
927c0a4d88 change location of default kill signal 2017-12-06 17:48:25 -05:00
Alex Dadgar
503b63fa64 Merge pull request #3624 from hashicorp/v-go-getter
Update go-getter
2017-12-06 14:25:56 -08:00
Michael Lange
5acb3e8c6f Merge pull request #3621 from hashicorp/b-ui-timezones
UI: Drop timezones from timestamps
2017-12-06 14:16:08 -08:00
Michael Lange
289b52aa21 Merge pull request #3623 from hashicorp/f-ui-warn-uncaught-exceptions
UI: Warn uncaught exceptions to console
2017-12-06 14:11:22 -08:00
Michael Lange
e8147765a8 Merge pull request #3627 from hashicorp/b-ui-logs-horizontal-scrollbar
UI: Make sure the code element within a cli-window takes the full height
2017-12-06 14:09:15 -08:00
Chelsea Holland Komlo
b1eda324c6 code review fixups 2017-12-06 16:37:47 -05:00
Michael Lange
b1cc6280b0 Make sure the code element within a cli-window takes the full height 2017-12-06 13:36:18 -08:00
Chelsea Holland Komlo
20d1a3b54d fix up test fixture to properly parse 2017-12-06 16:23:55 -05:00
Michael Lange
19d900e896 A short guide for proxying to a different nomad cluster
when developing the UI
2017-12-06 12:38:38 -08:00
Chelsea Holland Komlo
0c17fd5a33 use assert library 2017-12-06 15:03:02 -05:00
Chelsea Holland Komlo
359613e115 fix up basic test
add conversion for KillSignal for api/struct representation of task
2017-12-06 14:36:45 -05:00
Chelsea Holland Komlo
a6936662b6 add missing new file 2017-12-06 14:36:45 -05:00
Chelsea Holland Komlo
8356c6183c extract signal helper into utils 2017-12-06 14:36:44 -05:00
Chelsea Holland Komlo
9e49836d4f move kill_signal to task level, extend to docker 2017-12-06 14:36:39 -05:00
Alex Dadgar
d7946d0887 Update go-getter 2017-12-06 11:16:17 -08:00
Rob Genova
39502b95fc Update README.md 2017-12-06 10:51:39 -08:00
Michael Lange
ee7faa5561 Warn errors in prod 2017-12-06 10:33:03 -08:00
Michael Lange
e982951f98 Use ModifyTime instead of ModifyIndex 2017-12-06 10:17:12 -08:00
Chelsea Holland Komlo
079e6b5fb1 allow controlling the stop signal in exec/raw_exec 2017-12-06 11:28:45 -05:00
Rob Genova
deba901a92 Update resources.html.erb 2017-12-05 21:30:07 -08:00