Commit Graph

15057 Commits

Author SHA1 Message Date
Danielle
df84e07c1a Merge pull request #5750 from hashicorp/dani/devcluster-standalone
devcluster: Add standalone server
2019-05-22 18:02:43 +02:00
Michael Schurter
a52c7c2cbf Merge pull request #5731 from hashicorp/b-ignore-dc
client: drop unused DC field from servers list
2019-05-22 08:42:15 -07:00
Mahmood Ali
fb38029ba9 Merge pull request #5752 from hashicorp/b-client-lock-invalidallocs
client: synchronize client.invalidAllocs access
2019-05-22 10:47:17 -04:00
Mahmood Ali
d1f12fd3cb client: synchronize client.invalidAllocs access
invalidAllocs may be accessed and manipulated from different goroutines,
so must be locked.
2019-05-22 09:37:49 -04:00
Mahmood Ali
3e353bdce2 Merge pull request #5711 from hashicorp/f-nomad-exec-part-05-cli-docs
Document `nomad exec` command
2019-05-22 09:31:23 -04:00
Mahmood Ali
3eb0389dc3 Merge pull request #5751 from hashicorp/update-changelog-20190522
sort and changelog entries
2019-05-22 09:03:32 -04:00
Mahmood Ali
aa72c01a81 changelog alloc exec and /api http client changes 2019-05-22 08:57:11 -04:00
Mahmood Ali
05e8f179ee sort changelog entries
In each section, entries should be sorted by component name (except for
core that appears in top), and then by line length.
2019-05-22 08:48:16 -04:00
Danielle Lancashire
7e882f5908 devcluster: Add standalone server
This adds a single-node configuration of a dev cluster, for use when
testing things that require state restoration or multiple clients, but don't
necessarily require a 3+ node cluster.
2019-05-22 14:21:09 +02:00
Danielle
fc45e171f6 Merge pull request #5749 from hashicorp/dani/restore-allocs
client: Pass servers contacted ch to allocrunner
2019-05-22 14:17:24 +02:00
Danielle Lancashire
92527c6b4e client: Pass servers contacted ch to allocrunner
This fixes an issue where batch and service workloads would never be
restarted due to indefinitely blocking on a nil channel.

It also raises the restoration logging message to `Info` to simplify log
analysis.
2019-05-22 13:47:35 +02:00
Mahmood Ali
2972ce15d1 fix httpClient error handling
If err is nil, we should use the newly cloned httpClient.
2019-05-21 21:29:15 -04:00
Michael Lange
c00d6a47e6 UI changelog entries 2019-05-21 15:10:48 -07:00
Michael Lange
ee419296ea Merge pull request #5748 from hashicorp/b-ui/prefix-regex
Include the _ prefix separator in both regexes
2019-05-21 14:44:14 -07:00
Michael Lange
afa5f4dc0e Include the _ prefix separator in both regexes
And include all prefix types in the test data
2019-05-21 14:20:40 -07:00
Michael Lange
121927f08e Merge pull request #5734 from hashicorp/f-ui/allocation-lifecycle
UI: Allocation lifecycle
2019-05-21 11:04:19 -07:00
Michael Lange
20028361c1 Use the TwoStepButton page object for integration testing too 2019-05-21 09:24:19 -07:00
Michael Lange
d33f4bfd49 Acceptance testing for allocation lifecycle 2019-05-21 09:24:19 -07:00
Michael Lange
a301e0f079 Restart a single task from the task detail page 2019-05-21 09:24:18 -07:00
Michael Lange
01a3450c08 Don't cancel watchers when transitioning to a sub-route 2019-05-21 09:24:18 -07:00
Michael Lange
3a8334e720 Watch the next allocation on the allocation index page 2019-05-21 09:24:17 -07:00
Michael Lange
69c6c34afa Support task restarting in the allocation adapter 2019-05-21 09:24:17 -07:00
Michael Lange
64b4bf6546 Add stop and restart buttons to the allocation index page 2019-05-21 09:24:16 -07:00
Michael Lange
4038434603 Allocation methods for stopping and restarting 2019-05-21 09:24:16 -07:00
Michael Lange
b33ff625db New with-headroom modifier for titles 2019-05-21 09:24:15 -07:00
Michael Lange
b41af1c67a Add cancel on click outside and disabled behaviors to two-step-button 2019-05-21 09:24:14 -07:00
Mahmood Ali
bedf483d37 Merge pull request #5739 from hashicorp/r-rm-logmon-syslog-deadcode
logmon: remove syslog server deadcode
2019-05-21 11:46:48 -04:00
Mahmood Ali
fcceaee9b4 Merge pull request #5742 from hashicorp/b-test-fixes-20190520
Grab bag of (primarily race) test fixes
2019-05-21 11:46:36 -04:00
Mahmood Ali
ae1b110864 Merge pull request #5740 from hashicorp/b-nomad-exec-term-race
exec: allow drivers to handle stream termination
2019-05-21 11:24:12 -04:00
Mahmood Ali
13caa42dff Merge pull request #5741 from hashicorp/b-alloc-race-20190521
client: synchronize access to `ar.alloc`
2019-05-21 11:04:58 -04:00
Mahmood Ali
61006b5b51 remove github.com/RackSec/srslog dependency
No longer used
2019-05-21 10:56:08 -04:00
Michael Schurter
a7747106c8 Merge pull request #5732 from hashicorp/b-eval-race
nomad: fix race in BlockedEvals
2019-05-21 07:34:53 -07:00
Mahmood Ali
af48f7d3dc client: synchronize access to ar.alloc
`allocRunner.alloc` is protected by `allocRunner.allocLock`, so let's
use `allocRunner.Alloc()` helper function to access it.
2019-05-21 09:55:05 -04:00
Mahmood Ali
ea2f96e585 tests: fix fifo lib race
Accidentally accessed outer `err` variable inside a goroutine
2019-05-21 09:49:56 -04:00
Mahmood Ali
56f564fa75 tests: fix data race in client TestDriverManager_Fingerprint_Periodic 2019-05-21 09:49:56 -04:00
Mahmood Ali
5e17907a0c tests: fix client TestFS_Stream data race
Close is invoked in a different goroutine from test
2019-05-21 09:49:56 -04:00
Mahmood Ali
db3241c0df tests: handle unicode matches
naive implementation should focus on ascii characters only
2019-05-21 09:41:23 -04:00
Mahmood Ali
1492d0c49a exec: allow drivers to handle stream termination
Without this change, alloc_endpoint cancel the context passed to handler
when we detect EOF.  This races driver in setting exit code; and we run
into a case where the exec process terminates cleanly yet we attempt to
mark it as failed with context error.

Here, we rely on the driver to handle errors returned from Stream and
without racing to set an error.
2019-05-21 09:40:25 -04:00
Mahmood Ali
42f0099bc2 logmon: remove syslog server deadcode
Remove unused syslog server related code that got replaced by the docker
logger in Nomad 0.9
2019-05-21 09:36:43 -04:00
Michael Schurter
b58282284d nomad: fix deadlock in UnblockClassAndQuota
Previous commit could introduce a deadlock if the capacityChangeCh was
full and the receiving side exited before freeing a slot for the sending
side could send. Flush would then block forever waiting to acquire the
lock just to throw the pending update away.

The race is around getting/setting the chan field, not chan operations,
so only lock around getting the chan field.
2019-05-20 15:41:52 -07:00
Michael Schurter
01a4ed1481 nomad: fix race in BlockedEvals
I assume the mutex was being released before sending on capacityChangeCh
to avoid blocking in the critical section, but:

1. This is race.
2. capacityChangeCh has a *huge* buffer (8096). If it's full things
   already seem Very Bad, and a little backpressure seems appropriate.
2019-05-20 15:26:20 -07:00
Michael Schurter
edd972519f client: drop unused DC field from servers list
See #5730 for details.
2019-05-20 14:19:15 -07:00
Michael Schurter
59946ff70f Merge pull request #5411 from hashicorp/b-snapshotafter
Block plan application until state store has caught up to raft
2019-05-20 14:03:10 -07:00
Michael Lange
203b54b246 Move addToPath to its own util 2019-05-20 11:52:47 -07:00
Michael Lange
0ecbfe6a82 Merge pull request #5721 from hashicorp/f-ui/watchable-cancellation-tokens
UI: Replace the adapter cancellation methods with a cancellation token system
2019-05-20 11:49:14 -07:00
Michael Schurter
85e1e0ba68 Fix links. 2019-05-20 11:44:47 -07:00
Michael Schurter
60adaf71fa Add PR link to changelog for #5702 2019-05-20 11:33:23 -07:00
Michael Schurter
b24aba2af3 Fix typo. 2019-05-20 11:27:16 -07:00
Michael Lange
3c1de2df91 Standardize on Abort over Cancel 2019-05-20 11:08:16 -07:00
Michael Lange
c68962078a Replace the adapter cancellation methods with a cancellation token system 2019-05-20 10:29:22 -07:00