Files
nomad/command/quota_delete_test.go
Tim Gross 3a11a0b1e1 quotas: refactor storage limit specification (#24785)
In anticipation of having quotas for dynamic host volumes, we want the user
experience of the storage limits to feel integrated with the other resource
limits. This is currently prevented by reusing the `Resources` type instead of
having a specific type for `QuotaResources`.

Update the quota limit/usage types to use a `QuotaResources` that includes a new
storage resources quota block. The wire format for the two types are compatible
such that we can migrate the existing variables limit in the FSM.

Also fixes improper parallelism in the quota init test where we change working
directory to avoid file write conflicts but this breaks when multiple tests are
executed in the same process.

Ref: https://github.com/hashicorp/nomad-enterprise/pull/2096
2025-01-13 09:25:00 -05:00

111 lines
2.6 KiB
Go

// Copyright (c) HashiCorp, Inc.
// SPDX-License-Identifier: BUSL-1.1
//go:build ent
// +build ent
package command
import (
"strings"
"testing"
"github.com/hashicorp/cli"
"github.com/hashicorp/nomad/api"
"github.com/hashicorp/nomad/ci"
"github.com/hashicorp/nomad/helper/pointer"
"github.com/hashicorp/nomad/helper/uuid"
"github.com/posener/complete"
"github.com/shoenig/test/must"
)
func TestQuotaDeleteCommand_Implements(t *testing.T) {
ci.Parallel(t)
var _ cli.Command = &QuotaDeleteCommand{}
}
func TestQuotaDeleteCommand_Fails(t *testing.T) {
ci.Parallel(t)
ui := cli.NewMockUi()
cmd := &QuotaDeleteCommand{Meta: Meta{Ui: ui}}
// Fails on misuse
if code := cmd.Run([]string{"some", "bad", "args"}); code != 1 {
t.Fatalf("expected exit code 1, got: %d", code)
}
if out := ui.ErrorWriter.String(); !strings.Contains(out, commandErrorText(cmd)) {
t.Fatalf("expected help output, got: %s", out)
}
ui.ErrorWriter.Reset()
if code := cmd.Run([]string{"-address=nope", "foo"}); code != 1 {
t.Fatalf("expected exit code 1, got: %d", code)
}
if out := ui.ErrorWriter.String(); !strings.Contains(out, "deleting quota") {
t.Fatalf("connection error, got: %s", out)
}
ui.ErrorWriter.Reset()
}
func TestQuotaDeleteCommand_Good(t *testing.T) {
ci.Parallel(t)
// Create a server
srv, client, url := testServer(t, true, nil)
defer srv.Shutdown()
ui := cli.NewMockUi()
cmd := &QuotaDeleteCommand{Meta: Meta{Ui: ui}}
// Create a quota to delete
qs := testQuotaSpec()
_, err := client.Quotas().Register(qs, nil)
must.NoError(t, err)
// Delete a namespace
if code := cmd.Run([]string{"-address=" + url, qs.Name}); code != 0 {
t.Fatalf("expected exit 0, got: %d; %v", code, ui.ErrorWriter.String())
}
quotas, _, err := client.Quotas().List(nil)
must.NoError(t, err)
must.SliceEmpty(t, quotas)
}
func TestQuotaDeleteCommand_AutocompleteArgs(t *testing.T) {
ci.Parallel(t)
srv, client, url := testServer(t, true, nil)
defer srv.Shutdown()
ui := cli.NewMockUi()
cmd := &QuotaDeleteCommand{Meta: Meta{Ui: ui, flagAddress: url}}
// Create a quota
qs := testQuotaSpec()
_, err := client.Quotas().Register(qs, nil)
must.NoError(t, err)
args := complete.Args{Last: "quot"}
predictor := cmd.AutocompleteArgs()
res := predictor.Predict(args)
must.Len(t, 1, res)
must.Eq(t, qs.Name, res[0])
}
// testQuotaSpec returns a test quota specification
func testQuotaSpec() *api.QuotaSpec {
return &api.QuotaSpec{
Name: "quota-test-" + uuid.Short(),
Limits: []*api.QuotaLimit{
{
Region: "global",
RegionLimit: &api.QuotaResources{
CPU: pointer.Of(100),
},
},
},
}
}