mirror of
https://github.com/kemko/nomad.git
synced 2026-01-01 16:05:42 +03:00
648bacda77
In the spirit of #25909, this PR removes testify dependencies from the scheduler package, along with reflect.DeepEqual removal. This is again a combination of semgrep and hx editing magic. --------- Co-authored-by: Tim Gross <tgross@hashicorp.com>
570 lines
14 KiB
Go
570 lines
14 KiB
Go
// Copyright (c) HashiCorp, Inc.
|
|
// SPDX-License-Identifier: BUSL-1.1
|
|
|
|
package scheduler
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/hashicorp/go-set/v3"
|
|
"github.com/hashicorp/nomad/ci"
|
|
"github.com/hashicorp/nomad/client/lib/numalib"
|
|
"github.com/hashicorp/nomad/helper/uuid"
|
|
"github.com/hashicorp/nomad/nomad/mock"
|
|
"github.com/hashicorp/nomad/nomad/structs"
|
|
psstructs "github.com/hashicorp/nomad/plugins/shared/structs"
|
|
"github.com/shoenig/test/must"
|
|
)
|
|
|
|
func anyMemoryNodeMatcher() *memoryNodeMatcher {
|
|
return &memoryNodeMatcher{
|
|
memoryNode: -1,
|
|
}
|
|
}
|
|
|
|
// deviceRequest takes the name, count and potential constraints and affinities
|
|
// and returns a device request.
|
|
func deviceRequest(name string, count uint64,
|
|
constraints []*structs.Constraint, affinities []*structs.Affinity) *structs.RequestedDevice {
|
|
return &structs.RequestedDevice{
|
|
Name: name,
|
|
Count: count,
|
|
Constraints: constraints,
|
|
Affinities: affinities,
|
|
}
|
|
}
|
|
|
|
// devNode returns a node containing two devices, an nvidia gpu and an intel
|
|
// FPGA.
|
|
func devNode() *structs.Node {
|
|
n := mock.NvidiaNode()
|
|
n.NodeResources.Devices = append(n.NodeResources.Devices, &structs.NodeDeviceResource{
|
|
Type: "fpga",
|
|
Vendor: "intel",
|
|
Name: "F100",
|
|
Attributes: map[string]*psstructs.Attribute{
|
|
"memory": psstructs.NewIntAttribute(4, psstructs.UnitGiB),
|
|
},
|
|
Instances: []*structs.NodeDevice{
|
|
{
|
|
ID: uuid.Generate(),
|
|
Healthy: true,
|
|
},
|
|
{
|
|
ID: uuid.Generate(),
|
|
Healthy: false,
|
|
},
|
|
},
|
|
})
|
|
return n
|
|
}
|
|
|
|
// multipleNvidiaNode returns a node containing multiple nvidia device types.
|
|
func multipleNvidiaNode() *structs.Node {
|
|
n := mock.NvidiaNode()
|
|
n.NodeResources.Devices = append(n.NodeResources.Devices, &structs.NodeDeviceResource{
|
|
Type: "gpu",
|
|
Vendor: "nvidia",
|
|
Name: "2080ti",
|
|
Attributes: map[string]*psstructs.Attribute{
|
|
"memory": psstructs.NewIntAttribute(11, psstructs.UnitGiB),
|
|
"cuda_cores": psstructs.NewIntAttribute(4352, ""),
|
|
"graphics_clock": psstructs.NewIntAttribute(1350, psstructs.UnitMHz),
|
|
"memory_bandwidth": psstructs.NewIntAttribute(14, psstructs.UnitGBPerS),
|
|
},
|
|
Instances: []*structs.NodeDevice{
|
|
{
|
|
ID: uuid.Generate(),
|
|
Healthy: true,
|
|
},
|
|
{
|
|
ID: uuid.Generate(),
|
|
Healthy: true,
|
|
},
|
|
},
|
|
})
|
|
return n
|
|
|
|
}
|
|
|
|
// collectInstanceIDs returns the IDs of the device instances
|
|
func collectInstanceIDs(devices ...*structs.NodeDeviceResource) []string {
|
|
var out []string
|
|
for _, d := range devices {
|
|
for _, i := range d.Instances {
|
|
out = append(out, i.ID)
|
|
}
|
|
}
|
|
return out
|
|
}
|
|
|
|
// Test that asking for a device that isn't fully specified works.
|
|
func TestDeviceAllocator_Allocate_GenericRequest(t *testing.T) {
|
|
ci.Parallel(t)
|
|
|
|
_, ctx := testContext(t)
|
|
n := devNode()
|
|
d := newDeviceAllocator(ctx, n)
|
|
must.NotNil(t, d)
|
|
|
|
// Build the request
|
|
ask := deviceRequest("gpu", 1, nil, nil)
|
|
|
|
mem := anyMemoryNodeMatcher()
|
|
out, score, err := d.createOffer(mem, ask)
|
|
must.NotNil(t, out)
|
|
must.Zero(t, score)
|
|
must.NoError(t, err)
|
|
|
|
// Check that we got the nvidia device
|
|
must.SliceLen(t, 1, out.DeviceIDs)
|
|
must.SliceContains(t, collectInstanceIDs(n.NodeResources.Devices[0]), out.DeviceIDs[0])
|
|
}
|
|
|
|
// Test that asking for a device that is fully specified works.
|
|
func TestDeviceAllocator_Allocate_FullyQualifiedRequest(t *testing.T) {
|
|
ci.Parallel(t)
|
|
|
|
_, ctx := testContext(t)
|
|
n := devNode()
|
|
d := newDeviceAllocator(ctx, n)
|
|
must.NotNil(t, d)
|
|
|
|
// Build the request
|
|
ask := deviceRequest("intel/fpga/F100", 1, nil, nil)
|
|
|
|
mem := anyMemoryNodeMatcher()
|
|
out, score, err := d.createOffer(mem, ask)
|
|
must.NotNil(t, out)
|
|
must.Zero(t, score)
|
|
must.NoError(t, err)
|
|
|
|
// Check that we got the nvidia device
|
|
must.SliceLen(t, 1, out.DeviceIDs)
|
|
must.SliceContains(t, collectInstanceIDs(n.NodeResources.Devices[1]), out.DeviceIDs[0])
|
|
}
|
|
|
|
// Test that asking for a device with too much count doesn't place
|
|
func TestDeviceAllocator_Allocate_NotEnoughInstances(t *testing.T) {
|
|
ci.Parallel(t)
|
|
|
|
_, ctx := testContext(t)
|
|
n := devNode()
|
|
d := newDeviceAllocator(ctx, n)
|
|
must.NotNil(t, d)
|
|
|
|
// Build the request
|
|
ask := deviceRequest("gpu", 4, nil, nil)
|
|
|
|
mem := anyMemoryNodeMatcher()
|
|
out, _, err := d.createOffer(mem, ask)
|
|
must.Nil(t, out)
|
|
must.ErrorContains(t, err, "no devices match request")
|
|
}
|
|
|
|
func TestDeviceAllocator_Allocate_NUMA_available(t *testing.T) {
|
|
ci.Parallel(t)
|
|
|
|
_, ctx := testContext(t)
|
|
n := devNode()
|
|
d := newDeviceAllocator(ctx, n)
|
|
|
|
ask := deviceRequest("nvidia/gpu/1080ti", 2, nil, nil)
|
|
|
|
mem := &memoryNodeMatcher{
|
|
memoryNode: 0,
|
|
topology: structs.MockWorkstationTopology(),
|
|
devices: set.From([]string{"nvidia/gpu/1080ti"}),
|
|
}
|
|
out, _, err := d.createOffer(mem, ask)
|
|
must.NoError(t, err)
|
|
must.SliceLen(t, 2, out.DeviceIDs) // DeviceIDs are actually instance ids
|
|
}
|
|
|
|
func TestDeviceAllocator_Allocate_NUMA_node1(t *testing.T) {
|
|
ci.Parallel(t)
|
|
|
|
_, ctx := testContext(t)
|
|
n := devNode()
|
|
n.NodeResources.Devices = append(n.NodeResources.Devices, &structs.NodeDeviceResource{
|
|
Type: "fpga",
|
|
Vendor: "xilinx",
|
|
Name: "7XA",
|
|
Instances: []*structs.NodeDevice{
|
|
{
|
|
ID: uuid.Generate(),
|
|
Healthy: true,
|
|
Locality: &structs.NodeDeviceLocality{
|
|
PciBusID: "00000000:09:01.0",
|
|
},
|
|
},
|
|
},
|
|
})
|
|
d := newDeviceAllocator(ctx, n)
|
|
|
|
ask := deviceRequest("xilinx/fpga/7XA", 1, nil, nil)
|
|
|
|
mem := &memoryNodeMatcher{
|
|
memoryNode: 1,
|
|
topology: structs.MockWorkstationTopology(),
|
|
devices: set.From([]string{"xilinx/fpga/7XA"}),
|
|
}
|
|
out, _, err := d.createOffer(mem, ask)
|
|
must.NoError(t, err)
|
|
must.SliceLen(t, 1, out.DeviceIDs)
|
|
}
|
|
|
|
// Test that asking for a device with constraints works
|
|
func TestDeviceAllocator_Allocate_Constraints(t *testing.T) {
|
|
ci.Parallel(t)
|
|
|
|
n := multipleNvidiaNode()
|
|
nvidia0 := n.NodeResources.Devices[0]
|
|
nvidia1 := n.NodeResources.Devices[1]
|
|
|
|
cases := []struct {
|
|
Name string
|
|
Note string
|
|
Constraints []*structs.Constraint
|
|
ExpectedDevice *structs.NodeDeviceResource
|
|
ExpectedDeviceIDs []string
|
|
NoPlacement bool
|
|
}{
|
|
{
|
|
Name: "gpu",
|
|
Note: "-gt",
|
|
Constraints: []*structs.Constraint{
|
|
{
|
|
LTarget: "${device.attr.cuda_cores}",
|
|
Operand: ">",
|
|
RTarget: "4000",
|
|
},
|
|
},
|
|
ExpectedDevice: nvidia1,
|
|
ExpectedDeviceIDs: collectInstanceIDs(nvidia1),
|
|
},
|
|
{
|
|
Name: "gpu",
|
|
Note: "-lt",
|
|
Constraints: []*structs.Constraint{
|
|
{
|
|
LTarget: "${device.attr.cuda_cores}",
|
|
Operand: "<",
|
|
RTarget: "4000",
|
|
},
|
|
},
|
|
ExpectedDevice: nvidia0,
|
|
ExpectedDeviceIDs: collectInstanceIDs(nvidia0),
|
|
},
|
|
{
|
|
Name: "nvidia/gpu",
|
|
Constraints: []*structs.Constraint{
|
|
// First two are shared across both devices
|
|
{
|
|
LTarget: "${device.attr.memory_bandwidth}",
|
|
Operand: ">",
|
|
RTarget: "10 GB/s",
|
|
},
|
|
{
|
|
LTarget: "${device.attr.memory}",
|
|
Operand: "is",
|
|
RTarget: "11264 MiB",
|
|
},
|
|
{
|
|
LTarget: "${device.attr.graphics_clock}",
|
|
Operand: ">",
|
|
RTarget: "1.4 GHz",
|
|
},
|
|
},
|
|
ExpectedDevice: nvidia0,
|
|
ExpectedDeviceIDs: collectInstanceIDs(nvidia0),
|
|
},
|
|
{
|
|
Name: "intel/gpu",
|
|
NoPlacement: true,
|
|
},
|
|
{
|
|
Name: "nvidia/gpu",
|
|
Note: "-no-placement",
|
|
Constraints: []*structs.Constraint{
|
|
{
|
|
LTarget: "${device.attr.memory_bandwidth}",
|
|
Operand: ">",
|
|
RTarget: "10 GB/s",
|
|
},
|
|
{
|
|
LTarget: "${device.attr.memory}",
|
|
Operand: "is",
|
|
RTarget: "11264 MiB",
|
|
},
|
|
// Rules both out
|
|
{
|
|
LTarget: "${device.attr.graphics_clock}",
|
|
Operand: ">",
|
|
RTarget: "2.4 GHz",
|
|
},
|
|
},
|
|
NoPlacement: true,
|
|
},
|
|
{
|
|
Name: "nvidia/gpu",
|
|
Note: "-contains-id",
|
|
Constraints: []*structs.Constraint{
|
|
{
|
|
LTarget: "${device.ids}",
|
|
Operand: "set_contains",
|
|
RTarget: nvidia0.Instances[1].ID,
|
|
},
|
|
},
|
|
ExpectedDevice: nvidia0,
|
|
ExpectedDeviceIDs: []string{nvidia0.Instances[1].ID},
|
|
},
|
|
}
|
|
|
|
for _, c := range cases {
|
|
t.Run(c.Name+c.Note, func(t *testing.T) {
|
|
_, ctx := testContext(t)
|
|
d := newDeviceAllocator(ctx, n)
|
|
must.NotNil(t, d)
|
|
|
|
// Build the request
|
|
ask := deviceRequest(c.Name, 1, c.Constraints, nil)
|
|
|
|
mem := anyMemoryNodeMatcher()
|
|
out, score, err := d.createOffer(mem, ask)
|
|
if c.NoPlacement {
|
|
must.Nil(t, out)
|
|
} else {
|
|
must.NotNil(t, out)
|
|
must.Zero(t, score)
|
|
must.NoError(t, err)
|
|
|
|
// Check that we got the right nvidia device instance, and
|
|
// specific device instance IDs if mustd
|
|
must.Len(t, 1, out.DeviceIDs)
|
|
must.SliceContains(t, collectInstanceIDs(c.ExpectedDevice), out.DeviceIDs[0])
|
|
must.SliceContainsSubset(t, c.ExpectedDeviceIDs, out.DeviceIDs)
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
// Test that asking for a device with affinities works
|
|
func TestDeviceAllocator_Allocate_Affinities(t *testing.T) {
|
|
ci.Parallel(t)
|
|
|
|
n := multipleNvidiaNode()
|
|
nvidia0 := n.NodeResources.Devices[0]
|
|
nvidia1 := n.NodeResources.Devices[1]
|
|
|
|
cases := []struct {
|
|
Name string
|
|
Affinities []*structs.Affinity
|
|
ExpectedDevice *structs.NodeDeviceResource
|
|
ZeroScore bool
|
|
}{
|
|
{
|
|
Name: "gpu",
|
|
Affinities: []*structs.Affinity{
|
|
{
|
|
LTarget: "${device.attr.cuda_cores}",
|
|
Operand: ">",
|
|
RTarget: "4000",
|
|
Weight: 60,
|
|
},
|
|
},
|
|
ExpectedDevice: nvidia1,
|
|
},
|
|
{
|
|
Name: "gpu",
|
|
Affinities: []*structs.Affinity{
|
|
{
|
|
LTarget: "${device.attr.cuda_cores}",
|
|
Operand: "<",
|
|
RTarget: "4000",
|
|
Weight: 10,
|
|
},
|
|
},
|
|
ExpectedDevice: nvidia0,
|
|
},
|
|
{
|
|
Name: "gpu",
|
|
Affinities: []*structs.Affinity{
|
|
{
|
|
LTarget: "${device.attr.cuda_cores}",
|
|
Operand: ">",
|
|
RTarget: "4000",
|
|
Weight: -20,
|
|
},
|
|
},
|
|
ZeroScore: true,
|
|
ExpectedDevice: nvidia0,
|
|
},
|
|
{
|
|
Name: "nvidia/gpu",
|
|
Affinities: []*structs.Affinity{
|
|
// First two are shared across both devices
|
|
{
|
|
LTarget: "${device.attr.memory_bandwidth}",
|
|
Operand: ">",
|
|
RTarget: "10 GB/s",
|
|
Weight: 20,
|
|
},
|
|
{
|
|
LTarget: "${device.attr.memory}",
|
|
Operand: "is",
|
|
RTarget: "11264 MiB",
|
|
Weight: 20,
|
|
},
|
|
{
|
|
LTarget: "${device.attr.graphics_clock}",
|
|
Operand: ">",
|
|
RTarget: "1.4 GHz",
|
|
Weight: 90,
|
|
},
|
|
},
|
|
ExpectedDevice: nvidia0,
|
|
},
|
|
}
|
|
|
|
for _, c := range cases {
|
|
t.Run(c.Name, func(t *testing.T) {
|
|
_, ctx := testContext(t)
|
|
d := newDeviceAllocator(ctx, n)
|
|
must.NotNil(t, d)
|
|
|
|
// Build the request
|
|
ask := deviceRequest(c.Name, 1, nil, c.Affinities)
|
|
|
|
mem := anyMemoryNodeMatcher()
|
|
out, score, err := d.createOffer(mem, ask)
|
|
must.NotNil(t, out)
|
|
must.NoError(t, err)
|
|
if c.ZeroScore {
|
|
must.Zero(t, score)
|
|
} else {
|
|
must.NonZero(t, score)
|
|
}
|
|
|
|
// Check that we got the nvidia device
|
|
must.SliceLen(t, 1, out.DeviceIDs)
|
|
must.SliceContains(t, collectInstanceIDs(c.ExpectedDevice), out.DeviceIDs[0])
|
|
})
|
|
}
|
|
}
|
|
|
|
func Test_equalBusID(t *testing.T) {
|
|
must.True(t, equalBusID("0000:03:00.1", "00000000:03:00.1"))
|
|
must.False(t, equalBusID("0000:03:00.1", "0000:03:00.0"))
|
|
}
|
|
|
|
func Test_memoryNodeMatcher(t *testing.T) {
|
|
ci.Parallel(t)
|
|
|
|
cases := []struct {
|
|
name string
|
|
memoryNode int // memory node in consideration
|
|
topology *numalib.Topology // cpu cores and device bus associativity
|
|
taskNumaDevices *set.Set[string] // devices that require numa associativity
|
|
instance string // asking if this particular instance (id) satisfies the request
|
|
device *structs.NodeDeviceResource // device group that contains specifics about instance(s)
|
|
exp bool
|
|
}{
|
|
{
|
|
name: "ws: single gpu match on node 0",
|
|
memoryNode: 0,
|
|
topology: structs.MockWorkstationTopology(),
|
|
taskNumaDevices: set.From([]string{"nvidia/gpu/t1000"}),
|
|
instance: "GPU-T1000-01",
|
|
device: &structs.NodeDeviceResource{
|
|
Vendor: "nvidia",
|
|
Type: "gpu",
|
|
Name: "t1000",
|
|
Instances: []*structs.NodeDevice{
|
|
{
|
|
ID: "GPU-T1000-01",
|
|
Locality: &structs.NodeDeviceLocality{
|
|
PciBusID: "0000:02:00.1",
|
|
},
|
|
},
|
|
},
|
|
},
|
|
exp: true,
|
|
},
|
|
{
|
|
name: "ws: single gpu no match on node 1",
|
|
memoryNode: 1,
|
|
topology: structs.MockWorkstationTopology(),
|
|
taskNumaDevices: set.From([]string{"nvidia/gpu/t1000"}),
|
|
instance: "GPU-T1000-01",
|
|
device: &structs.NodeDeviceResource{
|
|
Vendor: "nvidia",
|
|
Type: "gpu",
|
|
Name: "t1000",
|
|
Instances: []*structs.NodeDevice{
|
|
{
|
|
ID: "GPU-T1000-01",
|
|
Locality: &structs.NodeDeviceLocality{
|
|
PciBusID: "0000:02:00.1",
|
|
},
|
|
},
|
|
},
|
|
},
|
|
exp: false,
|
|
},
|
|
{
|
|
name: "ws: net card match on node 0",
|
|
memoryNode: 0,
|
|
topology: structs.MockWorkstationTopology(),
|
|
taskNumaDevices: set.From([]string{"nvidia/gpu/t1000", "net/type1"}),
|
|
instance: "NET-T1-01",
|
|
device: &structs.NodeDeviceResource{
|
|
Type: "net",
|
|
Name: "nic100",
|
|
Instances: []*structs.NodeDevice{
|
|
{
|
|
ID: "NET-T1-01",
|
|
Locality: &structs.NodeDeviceLocality{
|
|
PciBusID: "0000:03:00.2",
|
|
},
|
|
},
|
|
},
|
|
},
|
|
exp: true,
|
|
},
|
|
{
|
|
name: "ws: any memory node",
|
|
memoryNode: -1,
|
|
exp: true,
|
|
},
|
|
{
|
|
name: "ws: device is not requested to be numa aware",
|
|
memoryNode: 0,
|
|
taskNumaDevices: set.From([]string{"amd/gpu/t1000"}),
|
|
instance: "NET-T2-01",
|
|
device: &structs.NodeDeviceResource{
|
|
Type: "net",
|
|
Name: "nic200",
|
|
Instances: []*structs.NodeDevice{
|
|
{
|
|
ID: "NET-T2-01",
|
|
},
|
|
},
|
|
},
|
|
exp: true,
|
|
},
|
|
}
|
|
|
|
for _, tc := range cases {
|
|
t.Run(tc.name, func(t *testing.T) {
|
|
m := &memoryNodeMatcher{
|
|
memoryNode: tc.memoryNode,
|
|
topology: tc.topology,
|
|
devices: tc.taskNumaDevices,
|
|
}
|
|
result := m.Matches(tc.instance, tc.device)
|
|
must.Eq(t, tc.exp, result)
|
|
})
|
|
}
|
|
}
|