kemko/nomad
1
0
Fork 0
mirror of https://github.com/kemko/nomad.git synced 2026-01-04 17:35:43 +03:00
Code Issues Packages Projects Releases Wiki Activity

Fix s3 example URLs in the artifacts docs (#15123)

Browse Source 
* Fix s3 URLs so that they work

Unfortunately, s3 urls prefixed with https:// do NOT work with the underlying go-getter library. As such, this fixes the examples so that they are working examples that won't cause problems for people reading the docs.
See discussion in https://github.com/hashicorp/nomad/issues/1113 circa 2016.

* Use s3:// protocol schema for artifact examples

Per the discussion in https://github.com/hashicorp/nomad/pull/15123,
we're going to use the explicit s3 protocol in the examples since that
is the likeliest to work in all scenarios
This commit is contained in:
twunderlich-grapl
2022-11-07 14:14:57 -05:00
committed by GitHub
parent 1a1ce363e7
commit 1b5eedc07a
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
website/content/docs/job-specification/artifact.mdx
View File

@@ -210,7 +210,7 @@ This example uses path-based notation on a publicly-accessible bucket:
```hcl
artifact {
source = "https://my-bucket-example.s3-us-west-2.amazonaws.com/my_app.tar.gz"
source = "s3://my-bucket-example.s3-us-west-2.amazonaws.com/my_app.tar.gz"
}
```
@@ -240,7 +240,7 @@ Alternatively you can use virtual hosted style:
```hcl
artifact {
source = "https://my-bucket-example.s3-eu-west-1.amazonaws.com/my_app.tar.gz"
source = "s3://my-bucket-example.s3-eu-west-1.amazonaws.com/my_app.tar.gz"
}
```