kemko/nomad
1
0
Fork 0
mirror of https://github.com/kemko/nomad.git synced 2026-01-01 16:05:42 +03:00
Code Issues Packages Projects Releases Wiki Activity

checklist: remove steps for openapi for rpc (#20515)

Browse Source
This commit is contained in:
Seth Hoenig
2024-05-02 08:53:45 -05:00
committed by GitHub
parent 3f866a7e82
commit 422d62df89
1 changed files with 0 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
contributing/checklist-rpc-endpoint.md
View File

@@ -39,15 +39,6 @@ Prefer adding a new message to changing any existing RPC messages.
* RPCs triggered by an internal process may not need support
* Check ACLs as an optimization
* [ ] Endpoint added/updated in the [`nomad-openapi`](https://github.com/hashicorp/nomad-openapi) repository.
* New endpoints will need to be configured in that repository's `generator` package.
* Updated endpoints may require the `generator` configuration to change, especially if parameters or headers change.
* If the accepted or returned `struct` schema changes, the Nomad version references in `generator/go.mod` will need
to be updated. Once the version is updated, regenerate the spec and all all clients so that the new schema is
reflected in the spec and thus the generated models.
* If `QueryOptions`, `QueryMeta`, `WriteOptions`, or `WriteMeta` change, the `v1` framework will need to updated to
support the change.
* [ ] `nomad/core_sched.go` sends many RPCs
* `ServersMeetMinimumVersion` asserts that the server cluster is
upgraded, so use this to guard sending the new RPC, else send the old RPC