kemko/nomad
1
0
Fork 0
mirror of https://github.com/kemko/nomad.git synced 2026-01-04 17:35:43 +03:00
Code Issues Packages Projects Releases Wiki Activity

Revert "E2E: skip Vault 1.16.1 for JWT compatibility test (#20301)" (#20484)

Browse Source 
This reverts commit 45b36371a12ffae5b5bfaaeadb08f801fb6bc98d. Now that Vault
1.16.2 has shipped, the E2E test will pick up only a working version.

Closes: https://github.com/hashicorp/nomad/issues/20298
This commit is contained in:
Tim Gross
2024-04-26 09:36:09 -04:00
committed by GitHub
parent 5f64e42d73
commit ff2d9de592
1 changed files with 1 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
e2e/vaultcompat/vaultcompat_test.go
View File

@@ -43,11 +43,6 @@ var (
// 1.11.0 is when Vault added support for `user_claim_json_pointer`.
// https://github.com/hashicorp/vault/pull/15593
minJWTVersion = goversion.Must(goversion.NewVersion("1.11.0"))
// skipJWTVersion is a version that has a known issue with JWT. Once 1.16.2
// ships, we can remove this as it won't be downloaded and tested anymore.
// See: https://github.com/hashicorp/nomad/issues/20298
skipJWTVersion = goversion.Must(goversion.NewVersion("1.16.1"))
)
func TestVaultCompat(t *testing.T) {
@@ -75,7 +70,7 @@ func testVaultBuild(t *testing.T, b build) {
testVaultLegacy(t, b)
})
if version.GreaterThanOrEqual(minJWTVersion) && !version.Equal(skipJWTVersion) {
if version.GreaterThanOrEqual(minJWTVersion) {
t.Run("jwt", func(t *testing.T) {
testVaultJWT(t, b)
})